You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-17] [$250] Android - search-Search results are opened with delay #62026
Version Number: 9.1.45-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Launch app
Login with account with more chats
Tab Search icon and then click any chat
Expected Result:
Tapping on a chat, it must be opened immediately without showing previously visited page is seen briefly
Actual Result:
Tapping on a chat, it is opened little bit delayed and previously visited page is seen briefly
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6830896_1747226601972.Screenrecorder-2025-05-14-18-03-50-558.mp4
changed the title [-]Android - search-Search results are opened with delay[/-][+][$250] Android - search-Search results are opened with delay[/+]on May 20, 2025
@bernhardoj 's proposal looks promising. If backHistory is causing delays, we can split the logic into separate files for web and native. For the mweb, we can add promise/callback handling, while for native and other platforms (except mweb), we can call the action immediately.
changed the title [-][$250] Android - search-Search results are opened with delay[/-][+][Due for payment 2025-06-17] [$250] Android - search-Search results are opened with delay[/+]on Jun 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.63-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@johncschuster@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This is a common navigation flow, so dont think we need the specific Regression test is needed for this search list navigation delay.
Activity
melvin-bot commentedon May 14, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon May 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The report is opened with delay when opening it from the search modal.
What is the root cause of that problem?
When we select an item, we delay the action with a promise.
App/src/components/Search/SearchRouter/SearchRouter.tsx
Lines 290 to 296 in 11385b8
As written, it's for mobile chrome only. Even though it's immediately resolved, it looks like it still delays on Android.
App/src/libs/Navigation/helpers/backHistory/index.ts
Lines 3 to 21 in 11385b8
What changes do you think we should make in order to solve the problem?
For non mWeb Android, we should immediately calls the action. We can follow the Modal.close pattern.
App/src/libs/actions/Modal.ts
Lines 46 to 55 in 11385b8
So, instead of returning a promise, it accepts a callback to be calls later.
We can also create a separate file for web and native.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
melvin-bot commentedon May 20, 2025
@johncschuster Huh... This is 4 days overdue. Who can take care of this?
[-]Android - search-Search results are opened with delay[/-][+][$250] Android - search-Search results are opened with delay[/+]melvin-bot commentedon May 20, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021924952971705229540
melvin-bot commentedon May 20, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)jayeshmangwani commentedon May 22, 2025
@bernhardoj 's proposal looks promising. If
backHistoryis causing delays, we can split the logic into separate files for web and native. For the mweb, we can add promise/callback handling, while for native and other platforms (except mweb), we can call the action immediately.🎀 👀 🎀 C+ reviewed
25 remaining items
[-][$250] Android - search-Search results are opened with delay[/-][+][Due for payment 2025-06-17] [$250] Android - search-Search results are opened with delay[/+]melvin-bot commentedon Jun 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.63-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 10, 2025
@jayeshmangwani @johncschuster @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
johncschuster commentedon Jun 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
jayeshmangwani commentedon Jun 17, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: fix: duplicate history in mobile chrome #61297 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This is a common navigation flow, so dont think we need the specific Regression test is needed for this search list navigation delay.
melvin-bot commentedon Jun 17, 2025
Payment Summary
Upwork Job
BugZero Checklist (@johncschuster)
johncschuster commentedon Jun 17, 2025
Payment Summary
Contributor: @bernhardoj due $250 via NewDot
Contributor+: @jayeshmangwani due $250 via NewDot
garrettmknight commentedon Jun 19, 2025
$250 approved for @jayeshmangwani
bernhardoj commentedon Jun 20, 2025
Requested in ND.
JmillsExpensify commentedon Jul 2, 2025
$250 approved for @bernhardoj