You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-28] [Due for payment 2025-05-27] Expense - Optimistic expense report preview not showing after creating an expense while being offline #62144
Version Number: 9.1.46-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):sdiojoisnjsdoi@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create a new workspace.
Go to workspace chat.
Click + > Create expense > Manual.
Go offline
Submit a manual expense.
Expected Result:
Expense preview will appear immediately after creating an expense (even if offline).
Actual Result:
Optimistic preview doesn't show up. The preview only appears after coming back online and after the request RequestMoney finishes
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Looking at the video, that delay is very small, I wonder if it could be something related to how production code is compiled vs staging code (if there is any difference in that).
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aldo-expensify@johncschuster@aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
changed the title [-][Due for payment 2025-05-27] Expense - Optimistic expense report preview not showing after creating an expense while being offline[/-][+][Due for payment 2025-05-28] [Due for payment 2025-05-27] Expense - Optimistic expense report preview not showing after creating an expense while being offline[/+]on May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aldo-expensify@johncschuster@aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 15, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 15, 2025
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 15, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
vincdargento commentedon May 15, 2025
@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
aldo-expensify commentedon May 15, 2025
I'm about to leave to a dentist appointment, I'll be out for around 1.5 hours, if this needs to be solved earlier, please reassign :)
aldo-expensify commentedon May 16, 2025
Looking at the video, that delay is very small, I wonder if it could be something related to how production code is compiled vs staging code (if there is any difference in that).
30 remaining items
melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
melvin-bot commentedon May 20, 2025
@aldo-expensify @johncschuster @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
johncschuster commentedon May 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Filter out report previews that shouldn't be shown in ReportPreview & MoneyRequestReportView #62002 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
aldo-expensify commentedon May 20, 2025
I forgot to comment, the revert PR was CP'ed here: https://expensify.slack.com/archives/C07J32337/p1747416094897619?thread_ts=1747397031.154729&cid=C07J32337 and I tested that it fixed the issue.
johncschuster commentedon May 21, 2025
Got it. Thanks! Does this need to be paid out then?
aldo-expensify commentedon May 21, 2025
I don't think so, we just did a revert.
[-][Due for payment 2025-05-27] Expense - Optimistic expense report preview not showing after creating an expense while being offline[/-][+][Due for payment 2025-05-28] [Due for payment 2025-05-27] Expense - Optimistic expense report preview not showing after creating an expense while being offline[/+]melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
melvin-bot commentedon May 21, 2025
@aldo-expensify @johncschuster @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
johncschuster commentedon May 23, 2025
Closing since this doesn't need to be paid out.