Skip to content

[Due for payment 2025-05-28] [Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page #62145

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+sj8snd91@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Account has no workspace
  1. Launch Expensify app
  2. Go to Workspaces
  3. Tap Workspaces
  4. Tap New workspace
  5. Tap app back button

Expected Result:

Account icon on the bottom tab will not be highlighted

Actual Result:

Account icon on the bottom tab is briefly highlighted when returning from create workspace page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6832523_1747342828772.ScreenRecording_05-16-2025_04-57-46_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021923136175455443616
  • Upwork Job ID: 1923136175455443616
  • Last Price Increase: 2025-05-15
  • Automatic offers:
    • Krishna2323 | Contributor | 107333223
Issue OwnerCurrent Issue Owner: @maddylewis

Activity

  1. melvin-bot commented on May 15, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on May 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on May 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. neil-marcellini commented on May 15, 2025

    @neil-marcellini
    Contributor

    That's super minor, we might be able to let it through. I'll make it external and see if I can find the cause.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 15, 2025
  6. melvin-bot commented on May 15, 2025

    @melvin-bot
  7. changed the title [-]Account icon on bottom tab is briefly highlighted when returning from create workspace page[/-] [+][$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/+] on May 15, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 15, 2025
  9. melvin-bot commented on May 15, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  10. Krishna2323 commented on May 15, 2025

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Account icon on bottom tab is briefly highlighted when returning from create workspace page

    What is the root cause of that problem?

    • Regression from this PR, we forgot to change the selectedTab to NAVIGATION_TABS.WORKSPACES.

    bottomContent={shouldUseNarrowLayout && <NavigationTabBar selectedTab={NAVIGATION_TABS.SETTINGS} />}

    What changes do you think we should make in order to solve the problem?

    • Update selectedTab to NAVIGATION_TABS.WORKSPACES

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Result

  11. 27 remaining items

  12. melvin-bot commented on May 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on May 20, 2025

    @melvin-bot

    @jayeshmangwani @maddylewis @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/-] [+][Due for payment 2025-05-28] [Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/+] on May 21, 2025
  16. melvin-bot commented on May 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-28. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on May 21, 2025

    @melvin-bot

    @jayeshmangwani @maddylewis @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. jayeshmangwani commented on May 27, 2025

    @jayeshmangwani
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    I don’t think we need to add a dedicated regression test for the bottom highlight. It’s part of the obvious flow and doesn’t require specific coverage - it should be caught through general testing.

  19. maddylewis commented on May 27, 2025

    @maddylewis
    Contributor

    Payment Overview + Regression Test

  20. garrettmknight commented on Jun 5, 2025

    @garrettmknight
    Contributor

    $250 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions