You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-28] [Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page #62145
Version Number: 9.1.46-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+sj8snd91@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Account has no workspace
Launch Expensify app
Go to Workspaces
Tap Workspaces
Tap New workspace
Tap app back button
Expected Result:
Account icon on the bottom tab will not be highlighted
Actual Result:
Account icon on the bottom tab is briefly highlighted when returning from create workspace page
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6832523_1747342828772.ScreenRecording_05-16-2025_04-57-46_1.1.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Account icon on bottom tab is briefly highlighted when returning from create workspace page[/-][+][$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@maddylewis@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/-][+][Due for payment 2025-05-28] [Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/+]on May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@maddylewis@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
I don’t think we need to add a dedicated regression test for the bottom highlight. It’s part of the obvious flow and doesn’t require specific coverage - it should be caught through general testing.
Activity
melvin-bot commentedon May 15, 2025
Triggered auto assignment to @neil-marcellini (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 15, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
neil-marcellini commentedon May 15, 2025
That's super minor, we might be able to let it through. I'll make it external and see if I can find the cause.
melvin-bot commentedon May 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021923136175455443616
[-]Account icon on bottom tab is briefly highlighted when returning from create workspace page[/-][+][$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/+]melvin-bot commentedon May 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)Krishna2323 commentedon May 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Account icon on bottom tab is briefly highlighted when returning from create workspace page
What is the root cause of that problem?
selectedTabtoNAVIGATION_TABS.WORKSPACES.App/src/pages/workspace/WorkspacesListPage.tsx
Line 501 in 07ba343
What changes do you think we should make in order to solve the problem?
selectedTabtoNAVIGATION_TABS.WORKSPACESWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Result
27 remaining items
melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 20, 2025
@jayeshmangwani @maddylewis @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/-][+][Due for payment 2025-05-28] [Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page[/+]melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@jayeshmangwani @maddylewis @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jayeshmangwani commentedon May 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles #60184
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
I don’t think we need to add a dedicated regression test for the bottom highlight. It’s part of the obvious flow and doesn’t require specific coverage - it should be caught through general testing.
maddylewis commentedon May 27, 2025
Payment Overview + Regression Test
garrettmknight commentedon Jun 5, 2025
$250 approved for @jayeshmangwani