Skip to content

[Due for payment 2025-05-28] [Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page #62156

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj891@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in to Expensifail account.
  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace chat.
  4. Submit an expense to the workspace chat.
  5. Go to self DM.
  6. Track a manual expense.
  7. Click Share it with my account.
  8. Select any accountant.
  9. On confirmation page, click More.
  10. Click Report.

Expected Result:

Report list will open.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2025
  2. melvin-bot commented on May 16, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 16, 2025

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 16, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 16, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nkdengineer commented on May 16, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Not here page opens.

    What is the root cause of that problem?

    It comes from #61839.

    When we share with the accountant, the transaction.reportID string is 0 so it doesn't fall back to the reportID from participant.

    const reportID = transaction?.reportID || transaction?.participants?.at(0)?.reportID;

    What changes do you think we should make in order to solve the problem?

    We should update the reportID to get from the participant if the transaction.reportID is 0

    const reportID = transaction?.reportID === '0' ? transaction?.participants?.at(0)?.reportID : transaction?.reportID;
    

    const reportID = transaction?.reportID || transaction?.participants?.at(0)?.reportID;

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. jnowakow commented on May 16, 2025

    @jnowakow
    Contributor

    @nkdengineer's solution seems correct. Should I fix it since it's regression from my PR or should it be him?

  8. techievivek commented on May 16, 2025

    @techievivek
    Contributor

    Ideally, the author of a PR is responsible for fixing any regressions it causes, unless they're unavailable for some reason.

  9. 16 remaining items

  10. techievivek commented on May 20, 2025

    @techievivek
    Contributor

    Yeah, good to clean this up but not worth blocking the deploy anymore since the user is able to share the expense with accountant. CC @jnowakow

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 20, 2025
  12. changed the title [-]Report field opens Not here page when sharing expense to accountant on confirmation page[/-] [+][Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/+] on May 20, 2025
  13. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jnowakow does not require payment (Contractor)
    • @DylanDylann requires payment through NewDot Manual Requests
  14. melvin-bot commented on May 20, 2025

    @melvin-bot

    @DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. luacmartins commented on May 20, 2025

    @luacmartins
    Contributor

    I think that is expected for the flow. The transaction is unreported and when we select to share it with our accountant, we still don't have a report

  16. techievivek commented on May 21, 2025

    @techievivek
    Contributor

    It should be good to close this, then, since the reported behaviour doesn't currently exist in our product. This was a regression, so we don't need any payment here.

  17. changed the title [-][Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/-] [+][Due for payment 2025-05-28] [Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/+] on May 21, 2025
  18. melvin-bot commented on May 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jnowakow does not require payment (Contractor)
    • @DylanDylann requires payment through NewDot Manual Requests
  19. melvin-bot commented on May 21, 2025

    @melvin-bot

    @DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions