You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-28] [Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page #62156
Version Number: 9.1.46-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sj891@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Report field opens Not here page when sharing expense to accountant on confirmation page[/-][+][Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/+]on May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@DylanDylann@muttmuure@DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
It should be good to close this, then, since the reported behaviour doesn't currently exist in our product. This was a regression, so we don't need any payment here.
changed the title [-][Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/-][+][Due for payment 2025-05-28] [Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/+]on May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@DylanDylann@muttmuure@DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 16, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 16, 2025
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 16, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 16, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon May 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Not here page opens.
What is the root cause of that problem?
It comes from #61839.
When we share with the accountant, the
transaction.reportIDstring is0so it doesn't fall back to the reportID from participant.App/src/pages/iou/request/step/IOURequestStepReport.tsx
Line 25 in eecf578
What changes do you think we should make in order to solve the problem?
We should update the
reportIDto get from the participant if thetransaction.reportIDis0App/src/pages/iou/request/step/IOURequestStepReport.tsx
Line 25 in eecf578
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
jnowakow commentedon May 16, 2025
@nkdengineer's solution seems correct. Should I fix it since it's regression from my PR or should it be him?
techievivek commentedon May 16, 2025
Ideally, the author of a PR is responsible for fixing any regressions it causes, unless they're unavailable for some reason.
16 remaining items
techievivek commentedon May 20, 2025
Yeah, good to clean this up but not worth blocking the deploy anymore since the user is able to share the expense with accountant. CC @jnowakow
[-]Report field opens Not here page when sharing expense to accountant on confirmation page[/-][+][Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/+]melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 20, 2025
@DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
luacmartins commentedon May 20, 2025
I think that is expected for the flow. The transaction is unreported and when we select to share it with our accountant, we still don't have a report
techievivek commentedon May 21, 2025
It should be good to close this, then, since the reported behaviour doesn't currently exist in our product. This was a regression, so we don't need any payment here.
[-][Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/-][+][Due for payment 2025-05-28] [Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page[/+]melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]