Skip to content

[Due for payment 2025-12-17] [$250] Expense - Expense preview doesn´t show receipt thumbnail on workspace member´s side #62182

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6119602&group_by=cases:section_id&group_order=asc&group_id=296762
Email or phone of affected tester (no customers): ibellicotest+768@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Have two accounts opened in two different devices or environments.
Prerequisite 2: User A has at least one workspace available.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Tap on chat header and select "Members"
  4. Invite User B as member.
  5. Switch to User B account.
  6. Open the workspace chat.
  7. Switch to User A account again.
  8. Create a manual expense on workspace chat.
  9. Return to User B account.
  10. Note that expense is received, but receipt thumbnail is not displayed.

Expected Result:

Receipt thumbnail should be visible for workspace member when receiving a new expense.

Actual Result:

When an expense is created on a workspace chat, preview is displayed without receipt thumbnail on member´s side.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6832695_1747364952410.Thumbnail.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021924504618975315267
  • Upwork Job ID: 1924504618975315267
  • Last Price Increase: 2025-05-26
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2025
  2. melvin-bot commented on May 16, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. gijoe0295 commented on May 16, 2025

    @gijoe0295
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense preview doesn´t show receipt thumbnail on workspace member´s side

    What is the root cause of that problem?

    B only receives the report preview action data, the child transaction data is not send by the Pusher so lastThreeReceipts is empty.

    const lastThreeTransactions = transactions?.slice(-3) ?? [];
    const lastThreeReceipts = lastThreeTransactions.map((transaction) => ({...getThumbnailAndImageURIs(transaction), transaction}));

    So we don't display receipt preview:

    total={numberOfRequests}
    size={CONST.RECEIPT.MAX_REPORT_PREVIEW_RECEIPTS}
    />

    I also found another issue is when you refresh the page, the receipt preview does show but the report amount does not:

    Image

    This is because the child transaction data is eventually returned by BE, but the IOU report data is (still) not. We did have logic to get the amount from the action message text:

    const splits = actionMessage.split(' ');

    But weirdly that after refreshing, the BE sets the action message text to Report not found, so we cannot get the amount at all:

    Image

    What changes do you think we should make in order to solve the problem?

    To fix the first issue, we can use the report preview action action.childMoneyRequestCount to determine the number of child transactions to display empty receipt thumbnails accordingly.

    const lastThreeReceipts = lastThreeTransactions.length > 0
        ? lastThreeTransactions.map((transaction) => ({...getThumbnailAndImageURIs(transaction), transaction}))
        :  Array(action?.childMoneyRequestCount ?? 0).fill({isEmptyReceipt: true});

    Only BE fix will resolve the second issue.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    1. Fix the Pusher to sent linked transactions and IOU report data along with the report preview action
    2. Run openReport(iouReportID) in the FE to manually fetch IOU report and transactions data. We can update the current logic in ReportScreen for this.
  4. melvin-bot commented on May 19, 2025

    @melvin-bot

    @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. dylanexpensify commented on May 19, 2025

    @dylanexpensify
    Contributor

    clarifying here

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 19, 2025
  7. changed the title [-]Expense - Expense preview doesn´t show receipt thumbnail on workspace member´s side[/-] [+][$250] Expense - Expense preview doesn´t show receipt thumbnail on workspace member´s side[/+] on May 19, 2025
  8. melvin-bot commented on May 19, 2025

    @melvin-bot
  9. dylanexpensify commented on May 19, 2025

    @dylanexpensify
    Contributor

    confirmed!

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 19, 2025
  11. 127 remaining items

  12. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@dylanexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1924504618975315267/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. melvin-bot commented on Dec 22, 2025

    @melvin-bot

    @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

  14. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  15. melvin-bot commented on Dec 26, 2025

    @melvin-bot

    @dylanexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  16. melvin-bot commented on Jan 2, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @sobitneupane, @mountiny, @dylanexpensify, @rayane-d eroding to Weekly issue.

  17. dylanexpensify commented on Jan 6, 2026

    @dylanexpensify
    Contributor
  18. dylanexpensify commented on Jan 13, 2026

    @dylanexpensify
    Contributor

    @sobitneupane breaking my heart man

  19. sobitneupane commented on Jan 14, 2026

    @sobitneupane
    Contributor

    Sorry for the delay, @dylanexpensify I was OOO for the past 3 weeks.

    Regression Test Proposal

    Precondition:

    • Have two accounts (User A and User B) opened on two different devices or environments.
    • User A has at least one workspace available.

    Test:

    1. Open the app as User A.
    2. Open any workspace chat.
    3. Tap the chat header and select Members.
    4. Invite User B as a member.
    5. Switch to User B's account.
    6. Open the same workspace chat.
    7. Switch back to User A's account.
    8. Create three manual expenses in the workspace chat.
    9. Switch again to User B's account.
    10. Verify that
      • the report preview displays a placeholder.
      • the placeholder shows the "Hidden" icon.
      • the placeholder shows the "Open for details" text.
      • the placeholder includes a "View report" action button.
      • the placeholder displays the report title and status.
      • the placeholder does not display the expenses count.
      • the placeholder does not display any expenses.
      • the placeholder does not display the report total.
      • the placeholder does not display left or right icon buttons for the expenses carousel.
      • the report preview action has correct actor name and avatars

    Do we agree 👍 or 👎

  20. sobitneupane commented on Jan 14, 2026

    @sobitneupane
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      When an admin invites a user to a submitter's workspace chat room, then the submitter creates an expense report in the workspace chat, the invited member can see the report in the chat immediately. But, because we don't share the report itself with them, it appears broken from their perspective. The PR implement this report preview access placeholder that only displays the report title and status with a "View report" button.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  21. garrettmknight commented on Mar 16, 2026

    @garrettmknight
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions