You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-30] [$250] mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message #62215
Version Number: V9.1.46-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):slottwo1vappa1@gmail.com Issue reported by: Applause Internal Team Device used: Redminote note 10s android 13 App Component: Other
🚨 Edited by proposal-police: This proposal was edited at 2025-05-17 02:23:27 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message
What is the root cause of that problem?
We immediately shows an error message when no content is found for a route. During page refresh, there's a brief moment when the route information isn't available yet, causing the "We couldn't find any help content for this route" message to appear momentarily before the actual content loads.
changed the title [-]mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message[/-][+][$250] mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message[/+]on May 16, 2025
Upon refreshing the page, the routeName is temporarily set to an empty string (''), which results in an invalid route value. Consequently, the "We couldn't find help content" message is shown prematurely.
Why does routeName become '' during refresh?
When the page is refreshed, the navigation container isn't yet ready. As a result, navigationRef.getRootState() returns undefined.
What changes do you think we should make in order to solve the problem?
When the navigation container is not ready, we should avoid rendering any help content and instead show a loading indicator (or render nothing).
We should add a loading state that handles the initial navigation setup:
const [isLoading, setIsLoading] = useState(true);
// Set loading to false after navigation state is available
useEffect(() => {
if (state?.name) {
setIsLoading(false);
}
}, [state?.name]);
// Show loading indicator when state is not ready
if (isLoading) {
return <ActivityIndicator />;
}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We need to test that the Help content shows a loading state when the navigation is not ready, and only renders error messages when navigation is ready but no matching content is found.
We should simulate page refreshes and verify that the error message doesn't appear during navigation state initialization.
📣 @rmoise! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193@Christinadobrzyn@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Go to staging.new.expensify
Tab help.
Reload the page.
Verify that there's a loading indicator while the content of the help page is being fetched.
After the loading indicator disappears, the content of help page appears.
Activity
melvin-bot commentedon May 16, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.drminh2807 commentedon May 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message
What is the root cause of that problem?
useRootNavigationStatetakes a small time to getfindFocusedRouteApp/src/components/SidePanel/HelpComponents/HelpContent.tsx
Lines 35 to 43 in f467c9f
What changes do you think we should make in order to solve the problem?
We should return nothing when route is empty
App/src/components/SidePanel/getHelpContent.tsx
Lines 11 to 15 in f467c9f
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
or we can return null in HelpContent by check routeName empty
ryntgh commentedon May 16, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-17 02:23:27 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message
What is the root cause of that problem?
We immediately shows an error message when no content is found for a route. During page refresh, there's a brief moment when the route information isn't available yet, causing the "We couldn't find any help content for this route" message to appear momentarily before the actual content loads.
App/src/components/SidePanel/getHelpContent.tsx
Lines 22 to 25 in 371b439
What changes do you think we should make in order to solve the problem?
We can return null or a loading indicator when the route is empty or still loading
App/src/components/SidePanel/HelpComponents/HelpContent.tsx
Line 98 in 371b439
Return null
Or loading indicator with a timeout that will show the error message if the route doesn't become available within a reasonable time
App/src/components/SidePanel/HelpComponents/HelpContent.tsx
Line 98 in 371b439
Might need to adjust the styling
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
melvin-bot commentedon May 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021923514807256763357
[-]mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message[/-][+][$250] mWeb - Help - Refreshing Help page briefly displays we couldn't find help content message[/+]melvin-bot commentedon May 16, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)rmoise commentedon May 16, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-17 10:22:53 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The appropriate help content is determined based on the
routedata:App/src/components/SidePanel/HelpComponents/HelpContent.tsx
Lines 56 to 59 in 32d67b3
App/src/components/SidePanel/getHelpContent.tsx
Lines 25 to 26 in 32d67b3
This
routedata is derived from therouteName.Upon refreshing the page, the
routeNameis temporarily set to an empty string (''), which results in an invalidroutevalue. Consequently, the "We couldn't find help content" message is shown prematurely.Why does
routeNamebecome''during refresh?navigationRef.getRootState()returnsundefined.routeNameto default to''at:App/src/components/SidePanel/HelpComponents/HelpContent.tsx
Line 40 in 32d67b3
What changes do you think we should make in order to solve the problem?
When the navigation container is not ready, we should avoid rendering any help content and instead show a loading indicator (or render nothing).
We should add a loading state that handles the initial navigation setup:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We need to test that the Help content shows a loading state when the navigation is not ready, and only renders error messages when navigation is ready but no matching content is found.
We should simulate page refreshes and verify that the error message doesn't appear during navigation state initialization.
melvin-bot commentedon May 16, 2025
📣 @rmoise! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
21 remaining items
melvin-bot commentedon May 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 23, 2025
@hungvu193 @Christinadobrzyn @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
hungvu193 commentedon May 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/56490/files#r2113055032
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Christinadobrzyn commentedon May 29, 2025
Regression test - https://github.com/Expensify/Expensify/issues/505903
Payment summary here- #62215 (comment)
Payment scheduled for tomorrow - moving to daily
melvin-bot commentedon Jun 2, 2025
@Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!
Christinadobrzyn commentedon Jun 2, 2025
Sorry I was ooo sick on Friday...
Payment summary here- #62215 (comment)
@hungvu193 please make sure to request payment via ND. Closing!
garrettmknight commentedon Jun 3, 2025
$250 approved for @hungvu193