Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
- Open a submitted card expense as approver (viewing an expense with no attendees selected)
- Click the Attendees button
- Observe the RHN
Expected Result:
RBR should not displayed or wait until the form is submitted
Actual Result:
RBR displayed immediately after opening the Attendees
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
CleanShot.2025-05-19.at.10.56.44.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021924919128693635846
- Upwork Job ID: 1924919128693635846
- Last Price Increase: 2025-05-27
Activity
melvin-bot commentedon May 19, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon May 19, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-19 21:41:11 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Attendee selector shows form error as soon as you open up the RHP
What is the root cause of that problem?
shouldShowErrorMessagewill become true as soon as the page is opened andattendeeslength is 0.App/src/pages/iou/request/MoneyRequestAttendeeSelector.tsx
Line 242 in 16a4d7b
What changes do you think we should make in order to solve the problem?
shouldShowErrorMessageand set that to true when we click confirm button andattendeeslength is 0.App/src/pages/iou/request/MoneyRequestAttendeeSelector.tsx
Lines 244 to 253 in 16a4d7b
shouldShowErrorMessageto false whenaddAttendeeToSelectionis called.App/src/pages/iou/request/MoneyRequestAttendeeSelector.tsx
Lines 200 to 237 in 16a4d7b
shouldShowErrorMessageis false andattendeeslength is 0.App/src/pages/iou/request/MoneyRequestAttendeeSelector.tsx
Lines 266 to 276 in 16a4d7b
attendees.length < 1is true and we have an option inhandleConfirmSelection, we can calladdAttendeeToSelectionwith the option.FormHelpMessageandButtonwithFormAlertWithSubmitButton. Like we do inAssigneeStepcomponent.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Result
shawnborton commentedon May 20, 2025
cc @francoisl for visibility
shawnborton commentedon May 20, 2025
And @allroundexperts - is this a regression from implementation?
allroundexperts commentedon May 20, 2025
Um... I am not sure @shawnborton. This was implemented quite some time ago and I jumped into this project at the end.
Can I be assigned here?
shawnborton commentedon May 20, 2025
Fine by me, but let's see what @alexpensify thinks.
alexpensify commentedon May 20, 2025
To clarify, @allroundexperts, do you want to help with the review or write the PR to fix the issue?
allroundexperts commentedon May 20, 2025
I'll write the fix for this, but before that we need to confirm from @francoisl if this is a backend bug. Normally, every transaction has yourself as an attendee. In this case, it's not happening.
francoisl commentedon May 20, 2025
Ideally, when you create an expense and are the only attendee, we don't send any data for attendees in the API request.
Put another way, "no attendees" means that you are the one and only attendee. Being the attendee of your expense is the default value, so we don't need to store that extra information.
The changes I'd recommend are:
We'll especially need the latter change to make expenses compatible with Expensify Classic, because we also don't store attendees by default when creating expenses on Classic.
49 remaining items
parasharrajat commentedon Jun 23, 2025
Makes sense.
trjExpensify commentedon Jun 23, 2025
From the attendee tracking design doc, there was supposed to be a
Recentssection for previously selected attendees, andContactsfor everyone else (which will include any external attendees you add). I think that makes sense still.shawnborton commentedon Jun 23, 2025
allroundexperts commentedon Jun 23, 2025
@parasharrajat I think we don't need to make any changes to my PR then?
parasharrajat commentedon Jun 24, 2025
It's fine to make the design look as above, but we still have that issue, so I guess we will move the current user details to the Contacts section as per the design doc.
We will have to keep changes regarding the recent contacts section to show that section as per the design doc.
melvin-bot commentedon Jul 17, 2025
This issue has not been updated in over 15 days. @francoisl, @alexpensify, @parasharrajat, @allroundexperts eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
parasharrajat commentedon Jul 17, 2025
PR of this issue #63729 was deployed to PROD 2 weeks back. This is ready for payment. @alexpensify
parasharrajat commentedon Jul 17, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Attendee Tracking: Created AttendeeSelectionPage #48008 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
alexpensify commentedon Jul 18, 2025
Payment Summary
Contributor: @allroundexperts due $250 via NewDot
Contributor+: @parasharrajat due $250 via NewDot
Please submit a request in Chat, thanks!
parasharrajat commentedon Jul 28, 2025
Payment requested as per #62325 (comment)
twisterdotcom commentedon Jul 31, 2025
@parasharrajat has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-2a00-a51f-b33e-5afbf256b281trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.