You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-05] [$250] Expense-App opens expense report instead of returning to confirm page after selecting a report #62343
Version Number: 9.1.46-12 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#62183 Email or phone of affected tester (no customers):applausetester+dwoduwndw9u@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon May 20, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 20, 2025
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 20, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 20, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon May 20, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-20 06:21:49 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
App opens the expense report.
What is the root cause of that problem?
It comes from #61839. We always dismiss the modal and navigate to the expense report even if we're in the create flow.
App/src/pages/iou/request/step/IOURequestStepReport.tsx
Lines 29 to 40 in a95171a
What changes do you think we should make in order to solve the problem?
We should only dismiss the modal if we're in the edit flow. Otherwise, we should goBack.
App/src/pages/iou/request/step/IOURequestStepReport.tsx
Lines 29 to 40 in a95171a
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nabi-ebrahimi commentedon May 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense-App opens expense report instead of returning to confirm page after selecting a report
What is the root cause of that problem?
We always dismiss the modal and open the report.
What changes do you think we should make in order to solve the problem?
We should always go back when the user clicks on a report. here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
jnowakow commentedon May 20, 2025
@nkdengineer's proposal looks good at first glance but this bug comes from my PR so probably I'm responsible for fixing it, right?
41 remaining items
melvin-bot commentedon Jun 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021930650906705661328
melvin-bot commentedon Jun 5, 2025
Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.
sakluger commentedon Jun 5, 2025
Summarizing payment on this issue:
Contributor: @nkdengineer $250, sent offer via Upwork (Update: Paid)
Contributor+: @allgandalf $250, sent offer via Upwork
melvin-bot commentedon Jun 9, 2025
@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!
CortneyOfstad commentedon Jun 9, 2025
Thanks @sakluger for holding down the fort while I was OoO!
CortneyOfstad commentedon Jun 9, 2025
@allgandalf looks like we're waiting for you to accept the offer in Upwork and once that is done, I can get you paid ASAP. Thanks!
melvin-bot commentedon Jun 11, 2025
@allgandalf Eep! 4 days overdue now. Issues have feelings too...
CortneyOfstad commentedon Jun 11, 2025
Payment Summary
@allgandalf — paid $250 via Upwork
@nkdengineer — paid $250 via Upwork