Skip to content

[Due for payment 2025-06-05] [$250] Expense-App opens expense report instead of returning to confirm page after selecting a report #62343

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.46-12
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #62183
Email or phone of affected tester (no customers): applausetester+dwoduwndw9u@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in to Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense to the workspace chat.
  4. Click + > Create expense > Manual.
  5. Enter amount > Next.
  6. On confirmation page, click More.
  7. Click Report.
  8. Click on the selected report.

Expected Result:

App will return to confirmation page.

Actual Result:

App opens the expense report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021930650906705661328
  • Upwork Job ID: 1930650906705661328
  • Last Price Increase: 2025-06-05
Issue OwnerCurrent Issue Owner: @allgandalf

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 20, 2025
  2. melvin-bot commented on May 20, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 20, 2025

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nkdengineer commented on May 20, 2025

    @nkdengineer
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-05-20 06:21:49 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App opens the expense report.

    What is the root cause of that problem?

    It comes from #61839. We always dismiss the modal and navigate to the expense report even if we're in the create flow.

    const selectReport = (item: ReportListItem) => {
    if (!transaction) {
    return;
    }
    if (item.value !== transaction.reportID) {
    setTransactionReport(transaction.transactionID, item.value, !isEditing);
    if (isEditing) {
    changeTransactionsReport([transaction.transactionID], item.value);
    }
    }
    Navigation.dismissModalWithReport({reportID: item.value});
    };

    What changes do you think we should make in order to solve the problem?

    We should only dismiss the modal if we're in the edit flow. Otherwise, we should goBack.

    if (item.value !== transaction.reportID) {
        setTransactionReport(transaction.transactionID, item.value, !isEditing);
        if (isEditing) {
            changeTransactionsReport([transaction.transactionID], item.value);
        } 
    }
    if (isEditing) {
        Navigation.dismissModalWithReport({reportID: item.value});
    } else {
        Navigation.goBack(backTo);
    }
    

    const selectReport = (item: ReportListItem) => {
    if (!transaction) {
    return;
    }
    if (item.value !== transaction.reportID) {
    setTransactionReport(transaction.transactionID, item.value, !isEditing);
    if (isEditing) {
    changeTransactionsReport([transaction.transactionID], item.value);
    }
    }
    Navigation.dismissModalWithReport({reportID: item.value});
    };

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. nabi-ebrahimi commented on May 20, 2025

    @nabi-ebrahimi

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense-App opens expense report instead of returning to confirm page after selecting a report

    What is the root cause of that problem?

    We always dismiss the modal and open the report.

    What changes do you think we should make in order to solve the problem?

    We should always go back when the user clicks on a report. here

       const selectReport = (item: ReportListItem) => {
            if (!transaction) {
                return;
            }
            if (item.value !== transaction.reportID) {
                setTransactionReport(transaction.transactionID, item.value, !isEditing);
                if (isEditing) {
                    changeTransactionsReport([transaction.transactionID], item.value);
                }
            }
    
            Navigation.goBack(backTo);
        };

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N / A

    What alternative solutions did you explore? (Optional)

  8. jnowakow commented on May 20, 2025

    @jnowakow
    Contributor

    @nkdengineer's proposal looks good at first glance but this bug comes from my PR so probably I'm responsible for fixing it, right?

  9. 41 remaining items

  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 5, 2025
  11. melvin-bot commented on Jun 5, 2025

    @melvin-bot
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 5, 2025
  13. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

  14. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 5, 2025
  15. sakluger commented on Jun 5, 2025

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @nkdengineer $250, sent offer via Upwork (Update: Paid)
    Contributor+: @allgandalf $250, sent offer via Upwork

  16. melvin-bot commented on Jun 9, 2025

    @melvin-bot

    @sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. CortneyOfstad commented on Jun 9, 2025

    @CortneyOfstad
    Contributor

    Thanks @sakluger for holding down the fort while I was OoO!

  18. CortneyOfstad commented on Jun 9, 2025

    @CortneyOfstad
    Contributor

    @allgandalf looks like we're waiting for you to accept the offer in Upwork and once that is done, I can get you paid ASAP. Thanks!

  19. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    @allgandalf Eep! 4 days overdue now. Issues have feelings too...

  20. CortneyOfstad commented on Jun 11, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @allgandalf — paid $250 via Upwork
    @nkdengineer — paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions