Skip to content

[Due for payment 2025-08-11] [$250] Expense - Report field on confirmation page shows submitted report, but the expense is created in a new report #62415

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.47-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+200511kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Delayed submissions is set to Manually.
  • Add approvals is enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Click Submit on the expense preview.
  5. Click on the expense preview.
  6. Click report header.
  7. Click Title, rename and save it (to remember easily).
  8. Go back to the main workspace chat.
  9. Click + > Create expense > Manual.
  10. Enter amount > Next.
  11. On confirmation page, click Show more.
  12. Note that Report field shows the expense report from Step 3.
  13. Click Create expense.

Expected Result:

In Step 12, the Report field on the confirmation page should show a new report.

Actual Result:

In Step 12, the Report field on the confirmation page shows the submitted report from Step 3.
In Step 13, after submitting the expense, the expense is created in a new report, instead of the selected report as stated in Step 12.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925137384397419631
  • Upwork Job ID: 1925137384397419631
  • Last Price Increase: 2025-05-21
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 20, 2025
  2. melvin-bot commented on May 20, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on May 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on May 20, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on May 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. vincdargento commented on May 20, 2025

    @vincdargento
    Author

    @bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. marcaaron commented on May 20, 2025

    @marcaaron
    Contributor

    This PR seems related...

    #62003 – Fix "Pay" & "Approve" buttons inside the report & when expenses are held

    Though, looking at the changes and I'm not too sure. This could be an API issue as well.

  8. marcaaron commented on May 20, 2025

    @marcaaron
    Contributor

    @cristipaval can you confirm what the behavior is here. It seems like we're making changes in this PR. But not clear whether it would be worse to revert that at this point or accept this minor inconsistency (feels like the latter).

  9. 41 remaining items

  10. bfitzexpensify commented on Aug 12, 2025

    @bfitzexpensify
    Contributor

    @DylanDylann please complete the BZ checklist

    Offer sent via Upwork @daledah

  11. DylanDylann commented on Aug 12, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NO, this is a case wasn't considered before

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Delayed submissions is set to Manually. Add approvals is enabled.

    Test:

    1. Go to workspace chat.
    2. Submit an expense.
    3. Click Submit on the expense preview.
    4. Click + > Create expense > Manual.
    5. Enter amount > Next.
    6. On confirmation page, click Show more.
    7. Verify that: In reports field, the Report field on the confirmation page should show a new report.

    Do we agree 👍 or 👎

  12. bfitzexpensify commented on Aug 13, 2025

    @bfitzexpensify
    Contributor

    Payment summary:

    @DylanDylann due $250 via NewDot manual request

  13. bfitzexpensify commented on Aug 15, 2025

    @bfitzexpensify
    Contributor

    I am heading OOO until September 1st - adding a BZ buddy

    Current status:

  14. removed their assignment
    on Aug 15, 2025
  15. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 15, 2025
  16. melvin-bot commented on Aug 15, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  17. CortneyOfstad commented on Aug 19, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @daledah — paid $250 via Upwork
    @DylanDylann – to be paid $250 via NewDot

    Regression Test

    https://github.com/Expensify/Expensify/issues/535788

  18. quinthar commented on Oct 17, 2025

    @quinthar
    Contributor

    Approved $250 to @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions