Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.47-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6138771
Email or phone of affected tester (no customers): applausetester+sdsdomjo@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
- Create two workspaces.
- Workspace A: Delayed submissions - enabled, Add approvals - enabled, Make or track payments - enabled
- Workspace B: Delayed submissions - enabled, Add approvals - disabled, Make or track payments - enabled
- Go to staging.new.expensify.com
- Go to workspace chat A
- Submit two expenses
- Click Submit on the expense preview
- Go to expense report
- Hold one of the expenses
- Note that Approve button shows the full amount instead of pending (unheld) amount
- Go to workspace chat B
- Submit two expenses
- Go to expense report
- Hold one of the expenses
- Click Submit
- Note that Pay button shows the pending (unheld) amount instead of full amount
Expected Result:
When an expense is held, Approve button and Pay button should be consistent and display only total or pending (unheld) amount
Actual Result:
When an expense is held
- Approve button shows total amount
- Pay button shows pending (unheld) amount
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6837310_1747765570285.20250521_021822.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021924948246695944420
- Upwork Job ID: 1924948246695944420
- Last Price Increase: 2025-05-20
- Automatic offers:
- brunovjk | Reviewer | 107456286
- Tony-MK | Contributor | 107456287
Activity
melvin-bot commentedon May 20, 2025
Triggered auto assignment to @cead22 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 20, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 20, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Expense - Approve and Pay button show different amount when an expense is held[/-][+][$250] Expense - Approve and Pay button show different amount when an expense is held[/+]melvin-bot commentedon May 20, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021924948246695944420
27 remaining items
melvin-bot commentedon Jun 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 4, 2025
@brunovjk @trjExpensify @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
brunovjk commentedon Jun 10, 2025
I don't believe any payment is necessary here. Our PR has been reverted here and our issue has been resolved in another issue/PR. Thanks.
trjExpensify commentedon Jun 10, 2025
Cool, sounds good. Closing it out!
Tony-MK commentedon Jun 12, 2025
Hey, @trjExpensify, I think might be eligible for some compensation as the proposed PR was deployed to staging. However other contributor fixed this issue, it seems that the other issue/PR would have made the PR obsolete. What do you think?
trjExpensify commentedon Jun 13, 2025
Ah, so $125 for the PR that was deployed but minus the regression?
Tony-MK commentedon Jun 16, 2025
Yeah, that's fine. Thanks.
trjExpensify commentedon Jun 16, 2025
Payment summary as follows:
Paid you both via Upwork, closing!