Skip to content

[Due for payment 2025-06-16] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page #62461

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.47-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: (#61886)
Email or phone of affected tester (no customers): Applause ws17 search
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: User Settings

Action Performed:

  1. Launch app
  2. Open a chat
  3. Send a message - https://staging.new.expensify.com/onboarding/migrated-user-welcome
  4. Tap on the link

Note : when opening link from browser, migrated modal shown but from opening chat directs to reports page. Pr : #61886

Expected Result:

Tapping on migrated user welcome link musnt navigate to reports page.

Actual Result:

Tapping on migrated user welcome link navigates to reports page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6837852_1747807504000.Screenrecorder-2025-05-21-11-32-30-981.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925316908768913249
  • Upwork Job ID: 1925316908768913249
  • Last Price Increase: 2025-05-28
  • Automatic offers:
    • thelullabyy | Contributor | 107534127
Issue OwnerCurrent Issue Owner: @lydiabarclay

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 21, 2025
  2. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. thelullabyy commented on May 21, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Tapping on the migrated user welcome link currently navigates the user to the Reports page instead of keeping them on the intended welcome screen.

    What is the root cause of that problem?

    • When the migrated user welcome link is tapped, it opens the MigratedUserWelcomeModal.
    • Inside this modal, due to the condition at line 66 not being met, the fallback logic at lines 69–71 is executed, which navigates the user to the Reports page.

    What changes do you think we should make in order to solve the problem?

    1. Update the route definition in ROUTES.ts to accept an optional shouldOpenSearch parameter:
        MIGRATED_USER_WELCOME_MODAL: {
            route: 'onboarding/migrated-user-welcome',
            getRoute: (shouldOpenSearch?: boolean) => getUrlWithBackToParam(
                `onboarding/migrated-user-welcome?${shouldOpenSearch ? 'shouldOpenSearch=true' : ''}`,
                undefined,
                false
            ),
        },
    
    1. In NavigationRoot.tsx, stop passing true to the getRoute() function:
        Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute());
    
    1. Instead, pass true when navigating from useOnboardingFlow.ts:
        Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(true));
    
    1. In MigratedUserWelcomeModal.tsx, update the isFromRoot variable to reflect shouldOpenSearch:
        const shouldOpenSearch = route?.params?.shouldOpenSearch === 'true';
    
    1. Update the condition at line 66 to use !shouldOpenSearch:
        if (!!(hasBeenAddedToNudgeMigration && !dismissedProductTraining?.migratedUserWelcomeModal) || !shouldOpenSearch) {
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • N/A

    What alternative solutions did you explore? (Optional)

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 21, 2025
  5. changed the title [-]Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/-] [+][$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/+] on May 21, 2025
  6. melvin-bot commented on May 21, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 21, 2025
  8. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  9. huult commented on May 22, 2025

    @huult
    Contributor

    Assign me because I am the owner of the PR

  10. thelullabyy commented on May 22, 2025

    @thelullabyy
    Contributor

    @arosiclair This issue isn’t caused by that PR, and the problem that PR was trying to solve is different from what's described here.

    Also, since this issue is labeled as external, I think we can treat it like any other external issue that contributors are free to work on.

  11. thelullabyy commented on May 27, 2025

    @thelullabyy
    Contributor

    @fedirjh When you have a moment, could you please review my proposal?

  12. 33 remaining items

  13. melvin-bot commented on Jun 9, 2025

    @melvin-bot

    @fedirjh @lydiabarclay @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. lydiabarclay commented on Jun 11, 2025

    @lydiabarclay
    Contributor

    @fedirjh can you confirm whether there are multiple PRs here?

  15. fedirjh commented on Jun 12, 2025

    @fedirjh
    Contributor

    @lydiabarclay It's just one PR deployed to prod 3 days ago, it seems automation was broken.

  16. fedirjh commented on Jun 12, 2025

    @fedirjh
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: This should have been fixed in fix isssue migrated user welcome modal no response #61886, author is aware of that.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    This is a minor edge case, no need for a regression test.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  17. lydiabarclay commented on Jun 12, 2025

    @lydiabarclay
    Contributor

    Ok great! If it was deployed 3 days ago, then the payment date will be 6/16/25. Thanks for filling out that checklist ahead of time @fedirjh !

  18. changed the title [-][Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/-] [+][Due for payment 2025-06-16] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/+] on Jun 12, 2025
  19. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    @lydiabarclay Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  20. lydiabarclay commented on Jun 16, 2025

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @thelullabyy paid $250 via Upwork
    Contributor+: @fedirjh due $250 via NewDot

    ✅ No regression test

  21. laurenreidexpensify commented on Aug 6, 2025

    @laurenreidexpensify
    Contributor

    $250 approved in New Expensify for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions