You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-16] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page #62461
Version Number: V9.1.47-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: (#61886) Email or phone of affected tester (no customers): Applause ws17 search Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: User Settings
Inside this modal, due to the condition at line 66 not being met, the fallback logic at lines 69–71 is executed, which navigates the user to the Reports page.
What changes do you think we should make in order to solve the problem?
Update the route definition in ROUTES.ts to accept an optional shouldOpenSearch parameter:
changed the title [-]Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/-][+][$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/+]on May 21, 2025
@fedirjh@lydiabarclay@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This is a minor edge case, no need for a regression test.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
changed the title [-][Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/-][+][Due for payment 2025-06-16] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/+]on Jun 12, 2025
Activity
melvin-bot commentedon May 21, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon May 21, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
MigratedUserWelcomeModal.What changes do you think we should make in order to solve the problem?
ROUTES.tsto accept an optionalshouldOpenSearchparameter:NavigationRoot.tsx, stop passingtrueto thegetRoute()function:truewhen navigating fromuseOnboardingFlow.ts:MigratedUserWelcomeModal.tsx, update theisFromRootvariable to reflectshouldOpenSearch:!shouldOpenSearch:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
[-]Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/-][+][$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/+]melvin-bot commentedon May 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021925316908768913249
melvin-bot commentedon May 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)huult commentedon May 22, 2025
Assign me because I am the owner of the PR
thelullabyy commentedon May 22, 2025
@arosiclair This issue isn’t caused by that PR, and the problem that PR was trying to solve is different from what's described here.
Also, since this issue is labeled as
external, I think we can treat it like any other external issue that contributors are free to work on.thelullabyy commentedon May 27, 2025
@fedirjh When you have a moment, could you please review my proposal?
33 remaining items
melvin-bot commentedon Jun 9, 2025
@fedirjh @lydiabarclay @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
lydiabarclay commentedon Jun 11, 2025
@fedirjh can you confirm whether there are multiple PRs here?
fedirjh commentedon Jun 12, 2025
@lydiabarclay It's just one PR deployed to prod 3 days ago, it seems automation was broken.
fedirjh commentedon Jun 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This should have been fixed in fix isssue migrated user welcome modal no response #61886, author is aware of that.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This is a minor edge case, no need for a regression test.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
lydiabarclay commentedon Jun 12, 2025
Ok great! If it was deployed 3 days ago, then the payment date will be 6/16/25. Thanks for filling out that checklist ahead of time @fedirjh !
[-][Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/-][+][Due for payment 2025-06-16] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page[/+]melvin-bot commentedon Jun 16, 2025
@lydiabarclay Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
lydiabarclay commentedon Jun 16, 2025
Payment Summary
Contributor: @thelullabyy paid $250 via Upwork
Contributor+: @fedirjh due $250 via NewDot
✅ No regression test
laurenreidexpensify commentedon Aug 6, 2025
$250 approved in New Expensify for @fedirjh