Skip to content

[Due for payment 2025-06-11] [Simplified Actions] Incorrect system message for amount change after P2P expense becomes unreported #62722

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #58020
Email or phone of affected tester (no customers): applausetester+sjdoidwsn11j12@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Submit two expenses to any user.
  3. In 1:1 DM, click on the expense preview.
  4. Click More > Delete.
  5. Delete the report.
  6. Go to self DM.
  7. Click on any expenses from the deleted report.
  8. Click Amount.
  9. Edit the amount and save it.

Expected Result:

The system message for amount change will be "changed the amount to y (previously x)".

Actual Result:

The system message for amount change is "changed the amount to y (previously x)", then changes to "set the amount to y".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2025
  2. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. twilight2294 commented on May 24, 2025

    @twilight2294
    Contributor

    BE bug

  7. pecanoro commented on May 26, 2025

    @pecanoro
    Contributor

    @garrettmknight Are you able to reproduce? My message doesn't change so not sure if I am missing some step:

    Image

  8. pecanoro commented on May 26, 2025

    @pecanoro
    Contributor

    Ok, I managed to reproduce, it only happens if the report was from 1:1 and not in a workspace

  9. 17 remaining items

  10. moved this to Second Cohort - HIGH in [#whatsnext] #migrateon May 28, 2025
  11. changed the title [-][Simplified Actions] Incorrect system message for amount change after expense becomes unreported[/-] [+][Simplified Actions] Incorrect system message for amount change after P2P expense becomes unreported[/+] on May 28, 2025
  12. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 4, 2025
  14. changed the title [-][Simplified Actions] Incorrect system message for amount change after P2P expense becomes unreported[/-] [+][Due for payment 2025-06-11] [Simplified Actions] Incorrect system message for amount change after P2P expense becomes unreported[/+] on Jun 4, 2025
  15. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allgandalf requires payment (Needs manual offer from BZ)
  17. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    @allgandalf @garrettmknight @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. allgandalf commented on Jun 9, 2025

    @allgandalf
    Contributor

    Lets close this one

  19. luacmartins commented on Jun 9, 2025

    @luacmartins
    Contributor

    Closing!

  20. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions