Skip to content

[Due for payment 2025-06-05] Expense - Expenses that are moved to self DM do not appear in the unreported expense list #62723

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #58020
Email or phone of affected tester (no customers): applausetester+sjdoidwsn11j12@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two expenses to the workspace chat.
  4. Click on the expense preview to go to expense report.
  5. Click More > Delete.
  6. Delete the report.
  7. Go to self DM.
  8. The expenses from the deleted report are moved to self DM.
  9. Go to workspace chat.
  10. Click + > Create report to create an empty report.
  11. Click Add expense.
  12. Click Add unreported expense.

Expected Result:

The expenses that are moved to self DM will appear in the unreported expense list.

Actual Result:

The expenses that are moved to self DM do not appear in the unreported expense list.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2025
  2. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mountiny commented on May 26, 2025

    @mountiny
    Contributor

    This is because the OpenUnreportedExpensesPage was not called yet

  7. mountiny commented on May 26, 2025

    @mountiny
    Contributor

    Creating an empty report is behind beta so I think we can demote this

  8. 18 remaining items

  9. DylanDylann commented on Jun 6, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug: Not a bug, this seems a new feature
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Not a bug, this seems a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Create a lot of unreported expenses +50
    2. Clear onyx and relog to your account.
    3. Enter expense report that has option to add expenses in primary/secondary actions.
    4. Choose option to Add unreported expenses.
    5. Make sure that unreported expenses load.
    6. Scroll to the bottom and make sure more expenses are being loaded.

    Do we agree 👍 or 👎

  10. melvin-bot commented on Jun 10, 2025

    @melvin-bot

    @JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

  11. JmillsExpensify commented on Jun 11, 2025

    @JmillsExpensify
    Contributor

    Payment summary: $250 for @DylanDylann via Newdot

  12. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    @JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

  13. JmillsExpensify commented on Jun 18, 2025

    @JmillsExpensify
    Contributor

    @DylanDylann updated the payment summary. Please request via NewDot. Closing this one.

  14. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Jun 18, 2025
  15. trjExpensify commented on Aug 12, 2025

    @trjExpensify
    Contributor

    Are we adding a regression test for this?

    Can confirm the payment summary here is correct.

  16. JmillsExpensify commented on Aug 12, 2025

    @JmillsExpensify
    Contributor

    Yeah I'll add it.

  17. JmillsExpensify commented on Aug 12, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

  18. quinthar commented on Aug 13, 2025

    @quinthar
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions