You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2025-06-02] Expense - GBR on the workspace chat does not disappear from LHN after deleting expense report #62724
Version Number: 9.1.51-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new feature If this was caught during regression testing, add the test name, ID and link from TestRail:#58020 Email or phone of affected tester (no customers):hndisuhdbishdi@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses to the workspace chat.
Click on the expense preview to go to expense report.
Click More > Delete.
Delete the report.
Expected Result:
GBR on the workspace chat will disappear from LHN after deleting the report.
Actual Result:
GBR on the workspace chat does not disappear from LHN after deleting the report.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
GBR on the workspace chat does not disappear from LHN after deleting expense report
What is the root cause of that problem?
When we delete a report, we do not set the hasOutstandingChildRequest to false of the parent report, this causes the GBR to stay until we open the report again and the OpenReport API sends the correct value of hasOutstandingChildRequest. this is the RCA:
/** Deletes a report and unreports all transactions on the report along with its reportActions, any linked reports and any linked IOU report actions. */
Hey @mallenexpensify , I am not due of any payment here, This is a regression issue, and i reviewed the PR raised by the contributor, so compensation due here, we are good to close this one
Activity
melvin-bot commentedon May 24, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 24, 2025
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 24, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 24, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
twilight2294 commentedon May 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
GBR on the workspace chat does not disappear from LHN after deleting expense report
What is the root cause of that problem?
When we delete a report, we do not set the
hasOutstandingChildRequestto false of the parent report, this causes the GBR to stay until we open the report again and theOpenReportAPI sends the correct value ofhasOutstandingChildRequest. this is the RCA:App/src/libs/actions/Report.ts
Lines 4604 to 4606 in 26cd22c
What changes do you think we should make in order to solve the problem?
update the
deleteAppReportto optimistically removehasOutstandingChildRequestand revert the change in failure data as well.Screen.Recording.2025-05-26.at.2.22.22.PM.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
luacmartins commentedon May 26, 2025
@allgandalf are you able to take a look at this one?
35 remaining items
melvin-bot commentedon Jun 4, 2025
Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.
mallenexpensify commentedon Jun 4, 2025
@twilight2294 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021930081155633445976
twilight2294 commentedon Jun 4, 2025
@mallenexpensify I accepted the offer, thanks !
mallenexpensify commentedon Jun 6, 2025
Apologies @twilight2294, can you please apply to this job instead? There was a glitch in Upwork and the previous link wasn't to this job, I canceled that contract without payment. https://www.upwork.com/jobs/~021930081155633445976
twilight2294 commentedon Jun 9, 2025
I accepted @mallenexpensify , apparently i got job offer directly so i accepted it instead of applying
mallenexpensify commentedon Jun 10, 2025
Contributor: @twilight2294 paid $250 via Upwork
allgandalf commentedon Jun 10, 2025
Hey @mallenexpensify , I am not due of any payment here, This is a regression issue, and i reviewed the PR raised by the contributor, so compensation due here, we are good to close this one
allgandalf commentedon Jun 10, 2025
Left a summary here too:
#62724 (comment)
mallenexpensify commentedon Jun 11, 2025
Thanks @allgandalf , I was clearly confused. I removed your payment details above.