Skip to content

[$250] [Due for payment 2025-06-02] Expense - GBR on the workspace chat does not disappear from LHN after deleting expense report #62724

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #58020
Email or phone of affected tester (no customers): hndisuhdbishdi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two expenses to the workspace chat.
  4. Click on the expense preview to go to expense report.
  5. Click More > Delete.
  6. Delete the report.

Expected Result:

GBR on the workspace chat will disappear from LHN after deleting the report.

Actual Result:

GBR on the workspace chat does not disappear from LHN after deleting the report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021930081155633445976
  • Upwork Job ID: 1930081155633445976
  • Last Price Increase: 2025-06-04

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2025
  2. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. twilight2294 commented on May 26, 2025

    @twilight2294
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    GBR on the workspace chat does not disappear from LHN after deleting expense report

    What is the root cause of that problem?

    When we delete a report, we do not set the hasOutstandingChildRequest to false of the parent report, this causes the GBR to stay until we open the report again and the OpenReport API sends the correct value of hasOutstandingChildRequest. this is the RCA:

    App/src/libs/actions/Report.ts

    Lines 4604 to 4606 in 26cd22c

    /** Deletes a report and unreports all transactions on the report along with its reportActions, any linked reports and any linked IOU report actions. */
    function deleteAppReport(reportID: string | undefined) {
    if (!reportID) {

    What changes do you think we should make in order to solve the problem?

    update the deleteAppReport to optimistically remove hasOutstandingChildRequest and revert the change in failure data as well.

        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`,
            value: {hasOutstandingChildRequest: false},
        });
    
        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`,
            value: {hasOutstandingChildRequest: report?.hasOutstandingChildRequest},
        });
    Screen.Recording.2025-05-26.at.2.22.22.PM.mov

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  7. luacmartins commented on May 26, 2025

    @luacmartins
    Contributor

    @allgandalf are you able to take a look at this one?

  8. 35 remaining items

  9. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 4, 2025
  11. mallenexpensify commented on Jun 4, 2025

    @mallenexpensify
    Contributor

    @twilight2294 can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021930081155633445976

  12. twilight2294 commented on Jun 4, 2025

    @twilight2294
    Contributor

    @mallenexpensify I accepted the offer, thanks !

  13. mallenexpensify commented on Jun 6, 2025

    @mallenexpensify
    Contributor

    Apologies @twilight2294, can you please apply to this job instead? There was a glitch in Upwork and the previous link wasn't to this job, I canceled that contract without payment. https://www.upwork.com/jobs/~021930081155633445976

  14. twilight2294 commented on Jun 9, 2025

    @twilight2294
    Contributor

    Image

    I accepted @mallenexpensify , apparently i got job offer directly so i accepted it instead of applying

  15. mallenexpensify commented on Jun 10, 2025

    @mallenexpensify
    Contributor

    Contributor: @twilight2294 paid $250 via Upwork

  16. allgandalf commented on Jun 10, 2025

    @allgandalf
    Contributor

    Hey @mallenexpensify , I am not due of any payment here, This is a regression issue, and i reviewed the PR raised by the contributor, so compensation due here, we are good to close this one

  17. allgandalf commented on Jun 10, 2025

    @allgandalf
    Contributor

    Left a summary here too:

    #62724 (comment)

  18. mallenexpensify commented on Jun 11, 2025

    @mallenexpensify
    Contributor

    Thanks @allgandalf , I was clearly confused. I removed your payment details above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions