Skip to content

[$250] Report -"Wating for you to submit expense" becomes infinite loading when changing report´s WS #62729

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6164495&group_by=cases:section_id&group_order=asc&group_id=377520
Email or phone of affected tester (no customers): ibellicotest+878@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least two workspaces available.
Prerequisite 2: Workspace one, has delayed submissions and approvals enabled.
Prerequisite 3. Workspace two, has delayed submissions and approvals disabled.

  1. Open the Expensify app.
  2. Open a workspace chat.
  3. Submit two different manual expenses.
  4. Open the report of the just created expenses.
  5. Tap on "More" and select "Change Workspace"
  6. Select another workspace.
  7. Navigate to the workspace where the expenses were sent.
  8. Note that report preview, now shows "View" instead of "Submit"
  9. Open the report.
  10. Note that infinite loading is displayed where the message "Waiting for you to submit expense (s)" was shown.

Expected Result:

The message "Waiting for you to submit expense (s)" should still be displayed on report, after moving it to a different workspace.

Actual Result:

Infinite loading is displayed instead of the "Waiting for you to submit expense (s)" message after moving a report to a different workspace. Also, the report now shows a "View" button on preview and inside report, instead of "Submit". To submit the expenses on report, the user now has to tap on "More" and select "Submit".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021927025090765295288
  • Upwork Job ID: 1927025090765295288
  • Last Price Increase: 2025-05-26
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2025
  2. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on May 25, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

    • Fix change workspace condition #62062: This PR refactors the logic for displaying the 'Change workspace' secondary action option and involves File changes in MoneyReportHeader.tsx, which is likely part of the report handling flow after a workspace change.
  7. lakchote commented on May 26, 2025

    @lakchote
    Contributor

    Could it be related to #62363?

    cc @SzymczakJ @mountiny @DylanDylann

  8. lakchote commented on May 26, 2025

    @lakchote
    Contributor

    It definitely looks like it is the issue, as Expense - Next step action shows skeleton loading when workflows are disabled is fixed by reverting it (see #62685 (comment)).

  9. 22 remaining items

  10. Beamanator commented on May 26, 2025

    @Beamanator
    Contributor

    Any updates here? I'm considering demoting due to this comment: #62729 (comment)

    I also agree that this is a very specific setup so NAB - but should def be fixed soon 🙏

  11. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 26, 2025
  12. mountiny commented on May 26, 2025

    @mountiny
    Contributor

    I am demoting because it seems like the next step is not returned from the be. We can update it there to return the right next step in this case

  13. Beamanator commented on May 26, 2025

    @Beamanator
    Contributor

    noiceeeee

  14. SzymczakJ commented on May 27, 2025

    @SzymczakJ
    Contributor

    I still cannot reproduce this

    Screen.Recording.2025-05-27.at.13.03.34.mov

    I asked @JakubKorytko to try to reproduce this

  15. JakubKorytko commented on May 27, 2025

    @JakubKorytko
    Member

    Reproduced on staging, mWeb Android (fresh account, 2 fresh workspaces).

    Reproduced.mov

    Not reproducible on main, mWeb Android (new account with the same settings, same expense amounts, categories & merchants)

    Not.reproduced.mov

    The only difference between the two videos is that there is no concierge message in the second one. However, there is also no concierge message in the original post, so it's probably not related. I guess it has been fixed somewhere, but it's not on staging yet.

  16. mountiny commented on May 27, 2025

    @mountiny
    Contributor

    Ok maybe we will just wait and some other change fixed this in main

  17. mountiny commented on May 28, 2025

    @mountiny
    Contributor

    Waiting for deploy

  18. trjExpensify commented on May 30, 2025

    @trjExpensify
    Contributor

    We've deployed. @jponikarchuk can we get a retest?

  19. mountiny commented on May 30, 2025

    @mountiny
    Contributor
  20. jponikarchuk commented on May 30, 2025

    @jponikarchuk
    Author

    @trjExpensify Issue is not reproducible anymore. Infinite loading is not experienced now.

    screen-20250530-115253.mp4
  21. mountiny commented on May 30, 2025

    @mountiny
    Contributor

    Legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions