Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #61170
Email or phone of affected tester (no customers): applausetester+ag.qbd@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 14
App Component: Search
Action Performed:
Pre-conditions:
Have a workspace with an accounting integration connected.
Use an Expensifail account that is a workspace admin.
Workspace admin is set as the preferred exporter in the accounting integration settings.
- Go to staging.new.expensify.com
- Log in as workspace admin
- Go to the Reports tab
- Verify the "To-do" options in the LHN
Expected Result:
The Export option should be displayed in the LHN of the Reports tab because the user logged in is an exporter for the accounting integration.
Actual Result:
The Export option is missing from the LHN of the Reports tab.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021926813035197192880
- Upwork Job ID: 1926813035197192880
- Last Price Increase: 2025-05-26
Activity
melvin-bot commentedon May 25, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 25, 2025
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 25, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 25, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
BlameGPT commentedon May 25, 2025
Possible culprit PRs for this issue
Please 👍 or 👎
ChavdaSachin commentedon May 25, 2025
Temporary disabled until the feature is is under development 77f1fe7
[-]Reports-Export option is missing from the LHN of the Reports tab[/-][+][$250] Reports-Export option is missing from the LHN of the Reports tab[/+]melvin-bot commentedon May 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021926813035197192880
melvin-bot commentedon May 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)carlosmiceli commentedon May 26, 2025
I think this is the PR that's causing this: #61170 cc @JS00001
Adding external to see if we find a quick fix, that PR is huge so ideally we don't revert.
nkdengineer commentedon May 26, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-26 02:26:23 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Export option is missing from the LHN of the Reports tab.
What is the root cause of that problem?
After we connect an accounting integration except SageIntacct, the policy owner is displayed as the selected exporter but the exporter data doesn't exist. It's selected because we fallback the condition to the policy owner. The exporter data only exists after we select any option in the exporter page.
App/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx
Line 52 in 526a0e4
App/src/pages/workspace/accounting/qbd/export/QuickbooksDesktopPreferredExporterConfigurationPage.tsx
Line 60 in 526a0e4
App/src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx
Line 71 in 526a0e4
App/src/pages/workspace/accounting/netsuite/export/NetSuitePreferredExporterSelectPage.tsx
Line 65 in 526a0e4
App/src/pages/workspace/accounting/intacct/export/SageIntacctPreferredExporterPage.tsx
Line 53 in 526a0e4
Then
showExportSuggestioncondition isfalseand no export option in LHN even we remove&& falseconditionApp/src/libs/SearchUIUtils.ts
Lines 958 to 971 in 526a0e4
What changes do you think we should make in order to solve the problem?
We should fallback all exporter checks with the policy owner here
App/src/libs/SearchUIUtils.ts
Lines 958 to 969 in 526a0e4
and here
App/src/pages/workspace/accounting/intacct/export/SageIntacctPreferredExporterPage.tsx
Line 53 in 526a0e4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
If we should only show this option if the exporter data exist, we should remove the fallback the policy owner from the
isSelectedcondition here. So this will not confuse users that they are exporters but no export option is shown.App/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx
Line 52 in 526a0e4
App/src/pages/workspace/accounting/qbd/export/QuickbooksDesktopPreferredExporterConfigurationPage.tsx
Line 60 in 526a0e4
App/src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx
Line 71 in 526a0e4
App/src/pages/workspace/accounting/netsuite/export/NetSuitePreferredExporterSelectPage.tsx
Line 65 in 526a0e4
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
getusha commentedon May 26, 2025
@carlosmiceli i think this is intentional #61170 (comment)
JS00001 commentedon May 26, 2025
This is intentional, closing for now
IuliiaHerets commentedon May 26, 2025
Issue is not repro on build v9.1.51-4. The "To-do" options are no longer shown