Skip to content

[$250] Reports-Export option is missing from the LHN of the Reports tab #62751

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #61170
Email or phone of affected tester (no customers): applausetester+ag.qbd@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 14
App Component: Search

Action Performed:

Pre-conditions:
Have a workspace with an accounting integration connected.
Use an Expensifail account that is a workspace admin.
Workspace admin is set as the preferred exporter in the accounting integration settings.

  1. Go to staging.new.expensify.com
  2. Log in as workspace admin
  3. Go to the Reports tab
  4. Verify the "To-do" options in the LHN

Expected Result:

The Export option should be displayed in the LHN of the Reports tab because the user logged in is an exporter for the accounting integration.

Actual Result:

The Export option is missing from the LHN of the Reports tab.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021926813035197192880
  • Upwork Job ID: 1926813035197192880
  • Last Price Increase: 2025-05-26
Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 25, 2025
  2. melvin-bot commented on May 25, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 25, 2025

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 25, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 25, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on May 25, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

    • Suggested Search & Filter Revamp #61170: This PR implements suggested search features, ensuring that 'Export' is only visible when a user is an exporter for the accounting integrations, which relates to the expected behavior for the Reports section.
    • Adjust copy for various report actions #60171: This PR includes actions related to exporting expenses to accounting integrations. It features tests checking the export options visible to users, aligning closely with the issue of the missing 'Export' option.
    • Fix change workspace condition #62062: This PR refactors the logic for displaying the 'Change workspace' option based on user roles and report status. While not directly related to exporting, it impacts the report functionality and potentially the visibility of various actions within the Reports tab.

    Please 👍 or 👎

  7. ChavdaSachin commented on May 25, 2025

    @ChavdaSachin
    Contributor

    Temporary disabled until the feature is is under development 77f1fe7

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 26, 2025
  9. changed the title [-]Reports-Export option is missing from the LHN of the Reports tab[/-] [+][$250] Reports-Export option is missing from the LHN of the Reports tab[/+] on May 26, 2025
  10. melvin-bot commented on May 26, 2025

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 26, 2025
  12. melvin-bot commented on May 26, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

  13. carlosmiceli commented on May 26, 2025

    @carlosmiceli
    Contributor

    I think this is the PR that's causing this: #61170 cc @JS00001
    Adding external to see if we find a quick fix, that PR is huge so ideally we don't revert.

  14. nkdengineer commented on May 26, 2025

    @nkdengineer
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-05-26 02:26:23 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Export option is missing from the LHN of the Reports tab.

    What is the root cause of that problem?

    After we connect an accounting integration except SageIntacct, the policy owner is displayed as the selected exporter but the exporter data doesn't exist. It's selected because we fallback the condition to the policy owner. The exporter data only exists after we select any option in the exporter page.

    isSelected: (qboConfig?.export?.exporter ?? policy?.owner) === exporter.email,

    isSelected: (currentExporter || policy?.owner) === exporter.email,

    isSelected: (config?.export?.exporter ?? policyOwner) === exporter.email,

    isSelected: (config?.exporter ?? policyOwner) === exporter.email,

    isSelected: exportConfiguration?.exporter === policyOwner,

    Then showExportSuggestion condition is false and no export option in LHN even we remove && false condition

    const showExportSuggestion =
    Object.values(policies).filter<OnyxTypes.Policy>((policy): policy is OnyxTypes.Policy => {
    if (!policy || !email) {
    return false;
    }
    const isIntacctExporter = policy.connections?.intacct?.config?.export?.exporter === email;
    const isNetSuiteExporter = policy.connections?.netsuite?.options.config?.exporter === email;
    const isQuickbooksDesktopExporter = policy.connections?.quickbooksDesktop?.config?.export?.exporter === email;
    const isQuickbooksOnlineExporter = policy.connections?.quickbooksOnline?.config?.export?.exporter === email;
    const isXeroExporter = policy.connections?.xero?.config?.export?.exporter === email;
    return isIntacctExporter || isNetSuiteExporter || isQuickbooksDesktopExporter || isQuickbooksOnlineExporter || isXeroExporter;
    }).length > 0 && false;

    What changes do you think we should make in order to solve the problem?

    We should fallback all exporter checks with the policy owner here

    const showExportSuggestion =
    Object.values(policies).filter<OnyxTypes.Policy>((policy): policy is OnyxTypes.Policy => {
    if (!policy || !email) {
    return false;
    }
    const isIntacctExporter = policy.connections?.intacct?.config?.export?.exporter === email;
    const isNetSuiteExporter = policy.connections?.netsuite?.options.config?.exporter === email;
    const isQuickbooksDesktopExporter = policy.connections?.quickbooksDesktop?.config?.export?.exporter === email;
    const isQuickbooksOnlineExporter = policy.connections?.quickbooksOnline?.config?.export?.exporter === email;
    const isXeroExporter = policy.connections?.xero?.config?.export?.exporter === email;

    and here

    isSelected: exportConfiguration?.exporter === policyOwner,

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    If we should only show this option if the exporter data exist, we should remove the fallback the policy owner from the isSelected condition here. So this will not confuse users that they are exporters but no export option is shown.

    isSelected: (qboConfig?.export?.exporter ?? policy?.owner) === exporter.email,

    isSelected: (currentExporter || policy?.owner) === exporter.email,

    isSelected: (config?.export?.exporter ?? policyOwner) === exporter.email,

    isSelected: (config?.exporter ?? policyOwner) === exporter.email,

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  15. getusha commented on May 26, 2025

    @getusha
    Contributor

    @carlosmiceli i think this is intentional #61170 (comment)

  16. JS00001 commented on May 26, 2025

    @JS00001
    Contributor

    This is intentional, closing for now

  17. IuliiaHerets commented on May 26, 2025

    @IuliiaHerets

    Issue is not repro on build v9.1.51-4. The "To-do" options are no longer shown

    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions