You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-27] [$250] Expense - Error when submitting unreported per diem expense to workspace without per diem rates #62797
Version Number: 9.1.51-4 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail:#62784 Email or phone of affected tester (no customers):applausetester+20389sd@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
There are two workspace - one has per diem rates, the other one does not have per diem rates.
Go to staging.new.expensify.com
Go to workspace chat that has per diem rates.
Create two per diem expenses in the workspace chat.
Click on the expense preview to go to expense report.
Click More > Delete.
Delete the report.
Go to self DM.
8.Click on the per diem expense.
Click on the report header.
Click Submit it to someone.
Select a workspace that does not have per diem rates.
Click Create expense.
Go to transaction thread.
Expected Result:
Unreported per diem expense can be submitted to workspace that does not have per diem rate,
or,
workspace that does not have per diem rates should not appear on the share list in Step 11.
Actual Result:
Error shows up when submitting unreported per diem expense to workspace that does not have per diem rate
In Step 11, workspace that does not have per diem rates appears on the share list.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Payment Summary
Contributor: @twilight2294 paid $250 via Upwork = $250 (paid)
Contributor+: @allroundexperts due $250 via NewDot = $250 (needs to be requested)
Activity
melvin-bot commentedon May 26, 2025
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 26, 2025
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 26, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon May 26, 2025
💬 A slack conversation has been started in #expensify-open-source
vincdargento commentedon May 26, 2025
@flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
54 remaining items
flaviadefaria commentedon Jun 27, 2025
Payment Summary
Contributor: @twilight2294 paid $250 via Upwork = $250 (paid)
Contributor+: @allroundexperts due $250 via NewDot = $250 (needs to be requested)
flaviadefaria commentedon Jun 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
flaviadefaria commentedon Jun 27, 2025
Oops I almost forgot the checklist.... @allroundexperts can you fill out the checklist above? Thanks!
melvin-bot commentedon Jun 30, 2025
@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
flaviadefaria commentedon Jun 30, 2025
Friendly bump here @allroundexperts
allroundexperts commentedon Jun 30, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: As mentioned by @luacmartins, this was caused by [CP Staging] Removed the ability to select individual contacts when sharing a per diem expense #62784
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/520858
Regression Test Proposal
Precondition:
Test:
Verify that the unreported per diem expense can be submitted to workspace that does not have per diem rate,
Do we agree 👍 or 👎
flaviadefaria commentedon Jul 2, 2025
Payment Summary
Contributor: @twilight2294 paid $250 via Upwork = $250 (paid)
Contributor+: @allroundexperts due $250 via NewDot = $250 (needs to be requested)
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.