Skip to content

[Due for payment 2025-06-27] [$250] Expense - Error when submitting unreported per diem expense to workspace without per diem rates #62797

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found while executing QA for PR #62784

Version Number: 9.1.51-4
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #62784
Email or phone of affected tester (no customers): applausetester+20389sd@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • There are two workspace - one has per diem rates, the other one does not have per diem rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat that has per diem rates.
  3. Create two per diem expenses in the workspace chat.
  4. Click on the expense preview to go to expense report.
  5. Click More > Delete.
  6. Delete the report.
  7. Go to self DM.
    8.Click on the per diem expense.
  8. Click on the report header.
  9. Click Submit it to someone.
  10. Select a workspace that does not have per diem rates.
  11. Click Create expense.
  12. Go to transaction thread.

Expected Result:

Unreported per diem expense can be submitted to workspace that does not have per diem rate,

or,

workspace that does not have per diem rates should not appear on the share list in Step 11.

Actual Result:

Error shows up when submitting unreported per diem expense to workspace that does not have per diem rate

In Step 11, workspace that does not have per diem rates appears on the share list.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021929898557076411956
  • Upwork Job ID: 1929898557076411956
  • Last Price Increase: 2025-06-03
  • Automatic offers:
    • twilight2294 | Contributor | 107619300
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @allroundexperts

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 26, 2025
  2. melvin-bot commented on May 26, 2025

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 26, 2025

    @melvin-bot

    Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on May 26, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on May 26, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. vincdargento commented on May 26, 2025

    @vincdargento
    Author

    @flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. 54 remaining items

  8. flaviadefaria commented on Jun 27, 2025

    @flaviadefaria
    Contributor

    Payment Summary

    Contributor: @twilight2294 paid $250 via Upwork = $250 (paid)
    Contributor+: @allroundexperts due $250 via NewDot = $250 (needs to be requested)

  9. flaviadefaria commented on Jun 27, 2025

    @flaviadefaria
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  10. flaviadefaria commented on Jun 27, 2025

    @flaviadefaria
    Contributor

    Oops I almost forgot the checklist.... @allroundexperts can you fill out the checklist above? Thanks!

  11. melvin-bot commented on Jun 30, 2025

    @melvin-bot

    @flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. flaviadefaria commented on Jun 30, 2025

    @flaviadefaria
    Contributor

    Friendly bump here @allroundexperts

  13. allroundexperts commented on Jun 30, 2025

    @allroundexperts
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    Regression Test Proposal

    Precondition:

    • Login to an account that has two workspaces, one with Per Diem rates enabled, and other without them

    Test:

    1. Go to workspace chat that has per diem rates.
    2. Create two per diem expenses in the workspace chat.
    3. Click on the expense preview to go to expense report.
    4. Click More > Delete.
    5. Delete the report.
    6. Go to self DM.
    7. Click on the per diem expense.
    8. Click on the report header.
    9. Click Submit it to someone.
    10. Select a workspace that does not have per diem rates.
    11. Click Create expense.
    12. Go to transaction thread.

    Verify that the unreported per diem expense can be submitted to workspace that does not have per diem rate,

    Do we agree 👍 or 👎

  14. flaviadefaria commented on Jul 2, 2025

    @flaviadefaria
    Contributor

    Payment Summary
    Contributor: @twilight2294 paid $250 via Upwork = $250 (paid)
    Contributor+: @allroundexperts due $250 via NewDot = $250 (needs to be requested)

  15. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    approved $250 for @allroundexperts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions