Repository navigation
[HOLD for payment 2022-01-11] Mobile apps - User is unable to paste an amount in the IOU amount modal #6285
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Copy any amount to the clipboard (e.g 1232.32)
- Navigate to a conversation in NewDot
- Request money
- Try to paste the amount you copied before in the mount field
Expected Result:
User is able to paste content in the amount field in mobile
Actual Result:
User is unable to paste content in the amount field in mobile
Workaround:
Enter the amount manually
Platform:
Where is this issue occurring?
- iOS
- Android
Version Number: 1.1.14-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1636688055149900
Activity
MelvinBot commentedon Nov 12, 2021
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.[-]User is unable to paste an amount in the IOU amount modal [/-][+]Mobile apps - User is unable to paste an amount in the IOU amount modal [/+]MelvinBot commentedon Nov 12, 2021
Triggered auto assignment to @Christinadobrzyn (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.39 remaining items
tgolen commentedon Dec 27, 2021
PR has been submitted and is under review.
[-]Mobile apps - User is unable to paste an amount in the IOU amount modal [/-][+][HOLD for payment 2022-01-11] Mobile apps - User is unable to paste an amount in the IOU amount modal [/+]botify commentedon Jan 4, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-11. 🎊
akshayasalvi commentedon Jan 4, 2022
@parasharrajat @tgolen There's an issue with this PR and I need some help. #7023 linked issue shows two keyboards in
Android Chrome.It seems that
inputmodeis not working as expected withkeyboardTypeforreact-native-web.TextInputcomponent. There is no handling forinputMode, and ourinputmode/inputModegets ignored.https://github.com/necolas/react-native-web/blob/081a128db325f9ee10c359e304e9f6cc7f4f9c56/packages/react-native-web/src/exports/TextInput/index.js#L136-L161
How should we proceed with this? Should we be updating
react-native-webparasharrajat commentedon Jan 4, 2022
Sorry, I was not a reviewer of the PR.
inputModeis a browser attribute an RN-web only supports props that are part of native RN spec. So you would have to usesetNativePropsto set this. It can't be passed asinputModeprop. Try that and let me know if that does not work.akshayasalvi commentedon Jan 5, 2022
I tried on the emulator it isn't working. I'll try to test on a real device.
Christinadobrzyn commentedon Jan 13, 2022
Hi there! @parasharrajat sorry to ask but can you give me an update on paying this? We're past the original Hold of Payment date but it looks like there might be other PRs in the works? Can you link the PR to track for paying this (if it's different). Thanks!
parasharrajat commentedon Jan 13, 2022
@Christinadobrzyn You should track #6811 for payment.
Christinadobrzyn commentedon Jan 13, 2022
After 7 days in production without any regressions so paid @akshayasalvi in Upwork for the job!
@parasharrajat were you the C+ on this project?
parasharrajat commentedon Jan 15, 2022
@Christinadobrzyn No, but I helped in finding the right solution.