You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-19] [$250] Expense report - 'Comments' sub-header is not displayed in the chat. #63076
Version Number: v9.1.54-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6184971 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: All platforms App Component: Other
There's also a weird behaviour that I'm not sure if it's a bug: If there's no comments, then the "Comments" sub header will display briefly when loading then disappears. We can discuss this later if needed.
Screen.Recording.2025-05-30.at.01.20.15.mov
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense report - 'Comments' sub-header is not displayed in the chat.[/-][+][$250] Expense report - 'Comments' sub-header is not displayed in the chat.[/+]on May 30, 2025
@daledah Thanks for the proposal. I think we should extract the view logic outside the !isEmpty(transactions) condition. Can you please update your proposal?
Please note - I'll be OoO through Friday. If this issue needs BZ action while I'm out, please remove me, reapply the BZ label so another BZ member is assigned, and than re-add me as an assignee so I can check back in on Monday. Thank you! 😃
changed the title [-][$250] Expense report - 'Comments' sub-header is not displayed in the chat.[/-][+][Due for payment 2025-06-19] [$250] Expense report - 'Comments' sub-header is not displayed in the chat.[/+]on Jun 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.65-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@OfstadC@s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, I think this is a minor bug that does not need a test
Activity
melvin-bot commentedon May 29, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon May 29, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-29 18:22:49 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
'Comments' sub-header is not displayed above the first comment.
What is the root cause of that problem?
We only display the sub header when there's transactions
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Line 199 in 3fa3aba
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 318 to 324 in 3fa3aba
What changes do you think we should make in order to solve the problem?
We should display only the "Comments" sub header when there's comment and no transactions
Add here
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Line 352 in 3fa3aba
Or move this sub header to outside of
!isEmpty(transactions)check.App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 329 to 343 in 649eff9
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None, UI issue
What alternative solutions did you explore? (Optional)
We can extract this sub header:
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 317 to 331 in 3fa3aba
Into a new component. Implement like below
Then add it after here
App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
Line 624 in 5f9d2d2
There's also a weird behaviour that I'm not sure if it's a bug: If there's no comments, then the "Comments" sub header will display briefly when loading then disappears. We can discuss this later if needed.
Screen.Recording.2025-05-30.at.01.20.15.mov
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon May 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021928524875839888926
[-]Expense report - 'Comments' sub-header is not displayed in the chat.[/-][+][$250] Expense report - 'Comments' sub-header is not displayed in the chat.[/+]melvin-bot commentedon May 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)s77rt commentedon May 31, 2025
@daledah Thanks for the proposal. I think we should extract the view logic outside the
!isEmpty(transactions)condition. Can you please update your proposal?OfstadC commentedon Jun 3, 2025
Please note - I'll be OoO through Friday. If this issue needs BZ action while I'm out, please remove me, reapply the BZ label so another BZ member is assigned, and than re-add me as an assignee so I can check back in on Monday. Thank you! 😃
s77rt commentedon Jun 3, 2025
Not overdue ^
17 remaining items
[-][$250] Expense report - 'Comments' sub-header is not displayed in the chat.[/-][+][Due for payment 2025-06-19] [$250] Expense report - 'Comments' sub-header is not displayed in the chat.[/+]melvin-bot commentedon Jun 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.65-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 12, 2025
@s77rt @OfstadC @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
s77rt commentedon Jun 15, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Improve MoneyRequestReportView #58903 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, I think this is a minor bug that does not need a test
OfstadC commentedon Jun 19, 2025
Payment Summary
Thank you!
JmillsExpensify commentedon Jun 26, 2025
$250 approved for @s77rt