You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense #63081
Version Number: 9.1.54-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+918@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome App Component: Search
Action Performed:
Prerequisite: Account has at least one workspace created.
Prerequisite 2: Workspace has delayed submissions enabled.
Open the Expensify app.
Open any workspace chat.
Submit a manual expense to it.
Once redirected to chat again, tap on the search icon on the top right corner.
Note that expense report preview shows "Submitted XX$" despite expense not being submitted yet.
Expected Result:
Expense report preview shouldn´t display an expense as submitted when it wasn´t submitted yet.
Actual Result:
Expense report preview on search, shows the message "Submitted XX$" for an expense that wasn´t submitted yet.
Please re-state the problem that we are trying to solve in this issue.
Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense
What is the root cause of that problem?
The last message of the expense report is the iou action linked to last expense and we display a submitted copy with the amount here for this type of iou actions here
What changes do you think we should make in order to solve the problem?
We can display another copy to represent expenses and the copy can be suggested by the design team but we can use some parameters as the amount and even prepend the requestor like the current one (when it is not the current user).
For instance, currently the message of the iou action the BE sets follows the format $XX expense so we can use a similar copy.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
WE can update the tests or create one to assert that the last message text of the expene report when the last action is an expense is aligned with the changes we make.
What alternative solutions did you explore? (Optional)
changed the title [-]Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense[/-][+][$250] Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense[/+]on May 30, 2025
Activity
melvin-bot commentedon May 29, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon May 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense
What is the root cause of that problem?
The last message of the expense report is the iou action linked to last expense and we display a submitted copy with the amount here for this type of iou actions here
App/src/libs/OptionsListUtils.ts
Lines 741 to 743 in 4ed579d
App/src/libs/ReportUtils.ts
Lines 4358 to 4365 in b436ae8
What changes do you think we should make in order to solve the problem?
We can display another copy to represent expenses and the copy can be suggested by the design team but we can use some parameters as the amount and even prepend the requestor like the current one (when it is not the current user).
App/src/libs/ReportUtils.ts
Lines 4358 to 4365 in b436ae8
For instance, currently the
messageof the iou action the BE sets follows the format$XX expenseso we can use a similar copy.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
WE can update the tests or create one to assert that the last message text of the expene report when the last action is an expense is aligned with the changes we make.
What alternative solutions did you explore? (Optional)
bernhardoj commentedon May 30, 2025
This is being handled here.
[-]Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense[/-][+][$250] Search - Expense report preview on search shows "Submitted XX$" for an unsubmitted expense[/+]melvin-bot commentedon May 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021928504743481126876
melvin-bot commentedon May 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)lydiabarclay commentedon May 30, 2025
@bernhardoj can this be closed then?
bernhardoj commentedon May 31, 2025
Yes