You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WAITING ON CHECKLIST] [$250] Travel Report - Error message appears when report is approved before submission #63137
Precondition: The account is signed up and set in OD. Flight is booked via ND.
Workflows set up in Workspace:
Delay Submission: Manual
Approval enable
Payment enable
Steps:
ND: Go to the Travel Reports
Open the Trips
Select the Expense matches with the flight
Click on the More button
Click on the Approve button
Expected Result:
The More menu should not have the approve option for a non-submit report
Actual Result:
The Approve option display in the More menu and after select it display an error message and after refresh the report back to the Submit status. The error message not translate to Spanish.
changed the title [-]Travel Report - Error message appears when report is approved before submission[/-][+][$250] Travel Report - Error message appears when report is approved before submission[/+]on Jun 3, 2025
changed the title [-][Due for payment 2025-07-10] [$250] Travel Report - Error message appears when report is approved before submission[/-][+][WAITING ON CHECKLIST] [$250] Travel Report - Error message appears when report is approved before submission[/+]on Jul 11, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This issue was caught during an existing regression test, also it is hard to reproduce, so I don't think we need a regression test here.
Activity
melvin-bot commentedon May 30, 2025
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 2, 2025
@slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Travel Report - Error message appears when report is approved before submission[/-][+][$250] Travel Report - Error message appears when report is approved before submission[/+]melvin-bot commentedon Jun 3, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021929956396194396389
melvin-bot commentedon Jun 3, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (
External)melvin-bot commentedon Jun 9, 2025
@ahmedGaber93 Eep! 4 days overdue now. Issues have feelings too...
53 remaining items
melvin-bot commentedon Jul 7, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.laurenreidexpensify commentedon Jul 7, 2025
Reassigning as Stevie is OOO
jliexpensify commentedon Jul 7, 2025
Payment Summary
Upwork job
jliexpensify commentedon Jul 11, 2025
Paid and job closed. Bump @ahmedGaber93 for the checklist please!
[-][Due for payment 2025-07-10] [$250] Travel Report - Error message appears when report is approved before submission[/-][+][WAITING ON CHECKLIST] [$250] Travel Report - Error message appears when report is approved before submission[/+]ahmedGaber93 commentedon Jul 11, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/57678/files#r2200615895
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This issue was caught during an existing regression test, also it is hard to reproduce, so I don't think we need a regression test here.
ahmedGaber93 commentedon Jul 11, 2025
@jliexpensify checklist have completed, sorry for the delay 🙏.
jliexpensify commentedon Jul 13, 2025
Thanks @ahmedGaber93, closing! @linhvovan29546 - payment summary here
trjExpensify commentedon Nov 5, 2025
approved $250 for @ahmedGaber93.