Skip to content

[WAITING ON CHECKLIST] [$250] Travel Report - Error message appears when report is approved before submission #63137

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6184929&group_by=cases:section_id&group_order=asc&group_id=314227
Email or phone of affected tester (no customers): applausetester+vq+290503@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Chat Report View

Action Performed:

Precondition: The account is signed up and set in OD. Flight is booked via ND.
Workflows set up in Workspace:
Delay Submission: Manual
Approval enable
Payment enable
Steps:

  1. ND: Go to the Travel Reports
  2. Open the Trips
  3. Select the Expense matches with the flight
  4. Click on the More button
  5. Click on the Approve button

Expected Result:

The More menu should not have the approve option for a non-submit report

Actual Result:

The Approve option display in the More menu and after select it display an error message and after refresh the report back to the Submit status. The error message not translate to Spanish.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021929956396194396389
  • Upwork Job ID: 1929956396194396389
  • Last Price Increase: 2025-06-24
  • Automatic offers:
    • linhvovan29546 | Contributor | 107808333
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 30, 2025
  2. melvin-bot commented on May 30, 2025

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    @slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 3, 2025
  5. changed the title [-]Travel Report - Error message appears when report is approved before submission[/-] [+][$250] Travel Report - Error message appears when report is approved before submission[/+] on Jun 3, 2025
  6. melvin-bot commented on Jun 3, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 3, 2025
  8. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

  9. melvin-bot commented on Jun 9, 2025

    @melvin-bot

    @ahmedGaber93 Eep! 4 days overdue now. Issues have feelings too...

  10. 53 remaining items

  11. melvin-bot commented on Jul 7, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  12. laurenreidexpensify commented on Jul 7, 2025

    @laurenreidexpensify
    Contributor

    Reassigning as Stevie is OOO

  13. jliexpensify commented on Jul 7, 2025

    @jliexpensify
    Contributor

    Payment Summary

    Upwork job

  14. jliexpensify commented on Jul 11, 2025

    @jliexpensify
    Contributor

    Paid and job closed. Bump @ahmedGaber93 for the checklist please!

  15. changed the title [-][Due for payment 2025-07-10] [$250] Travel Report - Error message appears when report is approved before submission[/-] [+][WAITING ON CHECKLIST] [$250] Travel Report - Error message appears when report is approved before submission[/+] on Jul 11, 2025
  16. ahmedGaber93 commented on Jul 11, 2025

    @ahmedGaber93
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other: Applause Internal Team
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/57678/files#r2200615895

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    This issue was caught during an existing regression test, also it is hard to reproduce, so I don't think we need a regression test here.

  17. ahmedGaber93 commented on Jul 11, 2025

    @ahmedGaber93
    Contributor

    @jliexpensify checklist have completed, sorry for the delay 🙏.

  18. jliexpensify commented on Jul 13, 2025

    @jliexpensify
    Contributor
  19. trjExpensify commented on Nov 5, 2025

    @trjExpensify
    Contributor

    approved $250 for @ahmedGaber93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions