Skip to content

Scan - Receipt preview does not take full width on the confirmation page #63279

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.55-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #62837
Email or phone of affected tester (no customers): dsisudniosusd@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.5
App Component: Money Requests

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Tap + > Create expense > Scan.
  4. Upload a receipt.

Expected Result:

Receipt preview will take full width on the confirmation page.

Actual Result:

Receipt preview does not take full width on the confirmation page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6849081_1748897955630.ScreenRecording_06-03-2025_04-57-17_1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 2, 2025
  2. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. BlameGPT commented on Jun 2, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

  6. github-actions commented on Jun 2, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. roryabraham commented on Jun 3, 2025

    @roryabraham
    Contributor

    almost certainly front-end. @marcaaron I'll nab this one from you

  8. roryabraham commented on Jun 3, 2025

    @roryabraham
    Contributor

    @Expensify/design @bernhardoj I suspect this is a side-effect of #62837

    Edit: Confirmed ✅

  9. roryabraham commented on Jun 3, 2025

    @roryabraham
    Contributor

    Should be fixed by #63296

  10. shawnborton commented on Jun 3, 2025

    @shawnborton
    Contributor

    Hmm I thought @bernhardoj fixed this?

    I think we do want some kind of max-width of these receipt thumbnails for those medium sized tablet devices. Will this cover that?

    That's why we specifically chose 440px as we thought it would be fine for even wider phones. In the bug report created, Applause is saying they use an iPhone 15 Pro Max. That has screen dimensions of 1290 x 2796 pixels, and when you divide that by 3, you get 430 width by 932 tall. We use 20px of inner padding, so 430-20-20 = 390px of area that the receipt needs to cover. Are we sure this isn't some other kind of bug, given that the receipt should have a max width of 440px?

  11. roryabraham commented on Jun 3, 2025

    @roryabraham
    Contributor

    Should be fixed, but the iOS staging deploy failed for an unrelated reason. got a fix ready for that: #63383

  12. roryabraham commented on Jun 3, 2025

    @roryabraham
    Contributor

    Confirmed this was fixed by #63213. Since it was fixed by the contributor and C+ that introduced it, no payments are due here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions