Skip to content

[Due for payment 2025-06-12] [Due for payment 2025-06-11] Reports - "Approve" button doesn´t disappear from expense preview of a held expense #63380

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.56-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+964@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Submit a manual expense to it.
  4. Tap on "Submit" on expense preview.
  5. Navigate to "Reports".
  6. Note that an "Approve" button can be seen on the preview of the just submitted expense.
  7. Open the expense and tap on "More"
  8. Hold the expense.
  9. Return to expenses list.
  10. Note that the "Approve" button didn´t disappear from preview.

Expected Result:

"Approve" button shouldn´t be visible on the preview of a held expense.

Actual Result:

After holding an expense, preview in "Reports" section still shows the "Approve" button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6849855_1748969688787.Approve_Hold.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 3, 2025
  2. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 3, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on Jun 3, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

  7. nlemma commented on Jun 3, 2025

    @nlemma
    Author

    @stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. samranahm commented on Jun 3, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - "Approve" button doesn´t disappear from expense preview of a held expense

    What is the root cause of that problem?

    We are explicitly retuning true here for Hold expense

    const isOneExpenseReportOnHold = isOneExpenseReport && isReportOnHold;
    if (isProcessingReport || isOneExpenseReportOnHold) {

    What changes do you think we should make in order to solve the problem?

    We should move this check above and return false

    const isOneExpenseReportOnHold = isOneExpenseReport && isReportOnHold;
    if (isProcessingReport || isOneExpenseReportOnHold) {

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  9. 22 remaining items

  10. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    @rlinoz @stephanieelliott @rlinoz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. changed the title [-][Due for payment 2025-06-11] Reports - "Approve" button doesn´t disappear from expense preview of a held expense[/-] [+][Due for payment 2025-06-12] [Due for payment 2025-06-11] Reports - "Approve" button doesn´t disappear from expense preview of a held expense[/+] on Jun 5, 2025
  12. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-12. 🎊

  13. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    @rlinoz @stephanieelliott @rlinoz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on Jun 12, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

  16. martasudol commented on Jun 17, 2025

    @martasudol
    Contributor

    Should we close it?

  17. rlinoz commented on Jun 17, 2025

    @rlinoz
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user

    • 3b. Expensify employee

    • 3c. Contributor

    • 3d. QA

    • 3z. Other:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Original PR got reverted

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions