Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.56-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+964@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Search
Action Performed:
Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.
- Open the staging.new.expensify.com website.
- Open any workspace chat.
- Submit a manual expense to it.
- Tap on "Submit" on expense preview.
- Navigate to "Reports".
- Note that an "Approve" button can be seen on the preview of the just submitted expense.
- Open the expense and tap on "More"
- Hold the expense.
- Return to expenses list.
- Note that the "Approve" button didn´t disappear from preview.
Expected Result:
"Approve" button shouldn´t be visible on the preview of a held expense.
Actual Result:
After holding an expense, preview in "Reports" section still shows the "Approve" button.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jun 3, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 3, 2025
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 3, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 3, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
BlameGPT commentedon Jun 3, 2025
Possible culprit PRs for this issue
nlemma commentedon Jun 3, 2025
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
samranahm commentedon Jun 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - "Approve" button doesn´t disappear from expense preview of a held expense
What is the root cause of that problem?
We are explicitly retuning true here for Hold expense
App/src/libs/ReportPrimaryActionUtils.ts
Lines 113 to 115 in 78579e7
What changes do you think we should make in order to solve the problem?
We should move this check above and return false
App/src/libs/ReportPrimaryActionUtils.ts
Lines 113 to 115 in 78579e7
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
22 remaining items
melvin-bot commentedon Jun 4, 2025
@rlinoz @stephanieelliott @rlinoz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-06-11] Reports - "Approve" button doesn´t disappear from expense preview of a held expense[/-][+][Due for payment 2025-06-12] [Due for payment 2025-06-11] Reports - "Approve" button doesn´t disappear from expense preview of a held expense[/+]melvin-bot commentedon Jun 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-12. 🎊
melvin-bot commentedon Jun 5, 2025
@rlinoz @stephanieelliott @rlinoz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jun 12, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Jun 16, 2025
@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...
martasudol commentedon Jun 17, 2025
Should we close it?
rlinoz commentedon Jun 17, 2025
BugZero Checklist:
Source of bug:
Where bug was reported:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Original PR got reverted
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.