Repository navigation
Hold expense - Unable to hold expense via checkbox if the expense thread is not opened first #63502
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6206790
Email or phone of affected tester (no customers): sdjosdinjsdodinsj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests
Action Performed:
- Go to staging.new.expensify.com
- Create a workspace.
- Go to workspace chat.
- Submit two expenses.
- Click on the expense preview to go to expense report.
- Do not open any expense.
- Select any expense via checkbox.
- Click More > Hold.
- Enter reason and save it.
- The expense is still not held.
- Click on the same expense row then close it.
- Click More > Hold.
- Enter reason and save it.
- Now the expense is held, only after the expense is opened.
Expected Result:
In Step 10, the expense will be held via checkbox and More option when the expense thread is not opened previously.
Actual Result:
In Step 10, the expense cannot be held via checkbox and More option when the expense thread is not opened previously.
In Step 14, the expense can only be held after the expense thread is opened at least once.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jun 4, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 4, 2025
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 4, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 4, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
BlameGPT commentedon Jun 4, 2025
Possible culprit PRs for this issue
samranahm commentedon Jun 4, 2025
Unable to produce on latest main
francoisl commentedon Jun 4, 2025
Same here, it's working fine on
mainbut I can repro locally on the tag9.1.59-0-staging. Something probably got merged recently that fixes this.francoisl commentedon Jun 4, 2025
Most likely PR 62329. Running some tests to confirm.
francoisl commentedon Jun 4, 2025
Reverting #62329 on
mainreintroduces the issue, so it means that's the PR that fixed it. I'll request a CP and look for the PR that from the checklist that caused the issue in the first place later.melvin-bot commentedon Jun 4, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
roryabraham commentedon Jun 5, 2025
Wasn't able to reproduce on staging
roryabraham commentedon Jun 5, 2025
requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1749153456114119
IuliiaHerets commentedon Jun 5, 2025
@roryabraham Not repro on Mac 15.5 Desktop 15.5, build 9.1.59-7
Recording.442.mp4
francoisl commentedon Jun 5, 2025
Nice, no one can repro anymore, let's demote. Thanks for the retest.