You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - There is an empty space above the report title in the distance report preview #63797
Version Number: v9.1.63-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): n/a Issue reported by: Applause Internal Team Device used: Mac 15.4.1-Safari, Desktop, iPhone 13 iOS 18.4.1 Safari, Hybrid App Component: Money Requests
Please re-state the problem that we are trying to solve in this issue.
When a report title in the MoneyRequestReportPreview wraps to multiple lines, an empty horizontal bar appears above the first line. This gap comes from a dummy spacer view that was intended to reserve room for the icon but instead adds unwanted vertical space whenever the title is long.
What is the root cause of that problem?
The FixIconPadding view only sets a vertical height inside the <Text>. Once the title wraps, that spacer becomes its own inline box above the text, creating the gap .. the issue is noteceable with long titles
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Jun 9, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.abzokhattab commentedon Jun 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a report title in the MoneyRequestReportPreview wraps to multiple lines, an empty horizontal bar appears above the first line. This gap comes from a dummy spacer view that was intended to reserve room for the icon but instead adds unwanted vertical space whenever the title is long.
What is the root cause of that problem?
The
FixIconPaddingview only sets a vertical height inside the<Text>. Once the title wraps, that spacer becomes its own inline box above the text, creating the gap .. the issue is noteceable with long titlesApp/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 648 to 655 in 82da537
What changes do you think we should make in order to solve the problem?
FixIconPaddingentirely .. as the related issues are no longer reproducable --> [Better Expense Report View] Expense Report Preview #58479 (comment) and [Due for payment 2025-04-30] [Better Expense Report View] [$125] Android Hybrid - The thumps up icon truncated at the finger on approve report #59534so it could be removed.
POC
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
nkdengineer commentedon Jun 10, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is an extra space above the report title in the distance report preview when submitting it to a user with @applause.expensifail.com domain.
What is the root cause of that problem?
We're using FixIconPadding in
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 648 to 655 in 82da537
which adds more space at the top. But we can't remove it because of this explanation
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 86 to 87 in 74fc9b9
What changes do you think we should make in order to solve the problem?
FixIconPaddingshould be used when approvedOrSettledIcon is not undefinedor
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jun 13, 2025
@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
adelekennedy commentedon Jun 16, 2025
this is pretty minor