Skip to content

[Due for payment 2026-03-31] [$250] Chat - After deleting mention, concierge whisper is still shown #63874

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.63-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Open a room chat
  3. Send a mention
  4. Delete the mention

Expected Result:

After deleting mention, concierge whisper must also be removed as happens while deleting expenses

Actual Result:

After deleting mention, concierge whisper is still shown

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6855851_1749575213029.Screenrecorder-2025-06-10-22-33-30-349.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021935005357853496223
  • Upwork Job ID: 1935005357853496223
  • Last Price Increase: 2025-09-23
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 10, 2025
  2. melvin-bot commented on Jun 10, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. truph01 commented on Jun 11, 2025

    @truph01
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • After deleting a mention, the corresponding concierge whisper message is still shown in the report.

    What is the root cause of that problem?

    • When a mention message is deleted, we only mark that specific message (ADDCOMMENT) as deleted and hide it from the report.
    • However, the associated concierge message (ACTIONABLEREPORTMENTIONWHISPER) remains visible because there is no mechanism in place to identify and hide it when its related mention message is deleted.

    What changes do you think we should make in order to solve the problem?

    • When a mention message is sent (ADDCOMMENT), the BE also generates a corresponding concierge message (ACTIONABLEREPORTMENTIONWHISPER).

    • Currently, there is no way to determine the relationship between the ADDCOMMENT and its related ACTIONABLEREPORTMENTIONWHISPER.

    • To address this, we should update the backend to include an additional property in the generated ACTIONABLEREPORTMENTIONWHISPER action—for example, linkedReportActionID—that stores the ID of the original ADDCOMMENT action.

    • On the frontend, we can then update the following function:

      function shouldReportActionBeVisible(reportAction: OnyxEntry<ReportAction>, key: string | number, canUserPerformWriteAction?: boolean): boolean {

      to include logic that hides the whisper message if the linked ADDCOMMENT has been deleted:

    
    if (
        isActionableReportMentionWhisper(reportAction) &&
        isDeletedAction(getReportAction(reportAction.reportID, reportAction.linkedReportActionID))
    ) {
        return false;
    }
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • Add tests for the shouldReportActionBeVisible.

    What alternative solutions did you explore? (Optional)

  4. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    @muttmuure Huh... This is 4 days overdue. Who can take care of this?

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 17, 2025
  6. changed the title [-]Chat - After deleting mention, concierge whisper is still shown[/-] [+][$250] Chat - After deleting mention, concierge whisper is still shown[/+] on Jun 17, 2025
  7. melvin-bot commented on Jun 17, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 17, 2025
  9. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 17, 2025
  10. 153 remaining items

  11. melvin-bot commented on Mar 24, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1935005357853496223/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. jayeshmangwani commented on Apr 1, 2026

    @jayeshmangwani
    Contributor

    Regression Test Proposal

    1. Open any room chat (not a DM).
    2. Send a message that @mentions a user who is not a member of the room.
    3. Verify that an actionable mention whisper appears, prompting you to invite the user.
    4. Send a message that includes a room name that does not yet exist.
    5. Verify that an actionable whisper appears, prompting you to create the room.
    6. Delete the message containing the @mention (long-press → Delete).
    7. Verify that the associated actionable mention whisper is no longer visible in the chat after deletion.

    Do we agree 👍 or 👎

  14. jayeshmangwani commented on Apr 1, 2026

    @jayeshmangwani
    Contributor

    This isn’t a regression from any PR (FE or BE); it’s more of a new feature, so I’ve proposed a regression test above.

    cc: @deetergp

  15. mallenexpensify commented on Apr 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @jayeshmangwani due $250 via NewDot

    ^ Test case created

    thx

  16. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Apr 2, 2026
  17. laurenreidexpensify commented on Apr 15, 2026

    @laurenreidexpensify
    Contributor

    New Expensify Approved: @jayeshmangwani $250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions