Skip to content

The violations are formatted incorrectly on the reports page when there are two or more descriptions #64059

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation (hyperlinked to channel name): #expensify_product

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create a workspace
  3. Click to workspace chat > create 2 expenses with the same receipt
  4. Click in to the report

Expected Result:

The violations are formatted correctly on the reports page when there are two or more descriptions.

Actual Result:

The violations are formatted incorrectly on the reports page when there are two or more descriptions.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

Image

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @clarajones-expensify
Issue OwnerCurrent Issue Owner: @eh2077

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2025
  2. melvin-bot commented on Jun 12, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Jun 12, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. mountiny commented on Jun 12, 2025

    @mountiny
    Contributor

    Discussing with @joekaufmanexpensify if the copy should be updated instead in slack

  5. joekaufmanexpensify commented on Jun 12, 2025

    @joekaufmanexpensify
    Contributor

    Responded here 👍

  6. mountiny commented on Jun 12, 2025

    @mountiny
    Contributor

    @dukenv0307 so for the 530 case we want Can't auto-match receipt due to a broken bank connection.

    And then the rter.brokenBankConnection (not 530) we want the same error logic as is the brokenConnection is true

    • we would also want to make sure the RBRMessages skip the empty strings

    Can you raise a PR for this please and let me know if anything is unclear

  7. allgandalf commented on Jun 12, 2025

    @allgandalf
    Contributor

    I was able to reproduce this issue by importing the onyx state , can i be assinged as the C+ here as per this slack post:

    https://expensify.slack.com/archives/C02NK2DQWUX/p1749726573522609

    Image

  8. added
    ReviewingHas a PR in review
    and removed on Jun 12, 2025
  9. 19 remaining items

  10. melvin-bot commented on Aug 8, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  11. laurenreidexpensify commented on Aug 8, 2025

    @laurenreidexpensify
    Contributor

    @clarajones-expensify I am OOO next week, can you please help with the payment on this when @eh2077 completes checklist thanks

  12. clarajones-expensify commented on Aug 8, 2025

    @clarajones-expensify
    Contributor

    @eh2077 - would you fill out this checklist? thank you!

  13. eh2077 commented on Aug 8, 2025

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/50793/files#r2263263689

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      No, I think we can skip adding regression test because we have added unit tests to cover the changes.

  14. eh2077 commented on Aug 8, 2025

    @eh2077
    Contributor

    @clarajones-expensify Thanks for the reminder. Checklist completed, thanks

  15. clarajones-expensify commented on Aug 8, 2025

    @clarajones-expensify
    Contributor

    Payment Summary

    Contributor: @dukenv0307 due $250 via NewDot
    Contributor+: @eh2077 due $250 via NewDot

  16. flaviadefaria commented on Aug 13, 2025

    @flaviadefaria
    Contributor

    $250 approved for @eh2077

  17. quinthar commented on Aug 13, 2025

    @quinthar
    Contributor

    $250 approved for @eh2077

  18. garrettmknight commented on Oct 24, 2025

    @garrettmknight
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions