Repository navigation
Profile - Unable to add symbols or spaces when adding phone number as secondary login #6414
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing #6293
Action Performed:
- Navigate to NewDot and login
- Go to settings > profile
- Tap add phone number
- Input a phone number using any of symbols -, (, ) or spaces (e.g. +1 (222) 222 2222)
Expected Result:
User able to add phone number with symbols without any error
Actual Result:
Unable to add symbols, tapping symbols in key board does nothing
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: v1.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Issue was found when executing #6293
Bug5341121_number.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Activity
OSBotify commentedon Nov 23, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Nov 23, 2021
Triggered auto assignment to @chiragsalian (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.parasharrajat commentedon Nov 23, 2021
Not a deploy blocker.
Unfortunately, this was neither added to the to-do list of the issue nor discussed in the PR review. So I missed it.
To fix this,
a. It involves allowing special chars in the phone input.
b. Validating the input with these chars.
c. sanitizing the input before sending it to it backend.
parasharrajat commentedon Nov 23, 2021
Due to this, I don't consider it now as part of the original issue. But I would like to fix this, let me know if I can submit a PR asap.
chiragsalian commentedon Nov 23, 2021
For sure, go ahead and create and submit a PR @parasharrajat.
MelvinBot commentedon Nov 23, 2021
📣 @parasharrajat You have been assigned to this job by @chiragsalian!
Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
parasharrajat commentedon Nov 23, 2021
let me know what should be done about it.
chiragsalian commentedon Nov 23, 2021
Thats fine that we don't show brackets for native devices. Thanks for working on the issue rajat.
chiragsalian commentedon Nov 23, 2021
I totally missed noticing we had phone input in AddSecondaryLoginPage as well.
chiragsalian commentedon Nov 23, 2021
Fix has been deployed to staging. @kavimuru can you retest once you get the chance and close the issue if its been resolved.
MelvinBot commentedon Nov 23, 2021
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.chiragsalian commentedon Nov 23, 2021
@laurenreidexpensify, so this is a deploy blocker and rajat helped us out with the fix. So from this SO could you make sure that rajat gets paid for his work 🙂
laurenreidexpensify commentedon Nov 24, 2021
https://www.upwork.com/jobs/~01ecf594dff9cb8480
@parasharrajat have sent you the offer in UW
isagoico commentedon Nov 24, 2021
Retest for the PR #6433 was a pass! I think we can remove the deploy blocker label here
chiragsalian commentedon Nov 24, 2021
Awesome, closing issue as well since we have another one tracking its progress to production.