Skip to content

[Due for payment 2025-07-25] [Due for payment 2025-07-18] Improve performance of loading report transactions across components #64163

Closed

Description

@TMisiukiewicz

Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1749048372222309

Problem
Multiple components throughout the app independently filter the entire transaction collection using Onyx selectors to get transactions for specific reports, which causes significant performance overhead.

Solution
Create a centralized transactions computation that group transactions by report IDs and store it as derived value.

Results for creating an expense in an expense chat for 7k reports and 350 transactions: 8.2s → 5.9s (~30% improvement)

Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. TMisiukiewicz commented on Jun 13, 2025

    @TMisiukiewicz
    ContributorAuthor

    cc @mountiny can I get assigned please?

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 13, 2025
  3. melvin-bot commented on Jun 13, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jun 23, 2025

    @melvin-bot

    @TMisiukiewicz Huh... This is 4 days overdue. Who can take care of this?

  5. TMisiukiewicz commented on Jun 23, 2025

    @TMisiukiewicz
    ContributorAuthor

    PR is approved by C+

  6. TMisiukiewicz commented on Jun 30, 2025

    @TMisiukiewicz
    ContributorAuthor

    Getting back to this after #63655 revert

  7. melvin-bot commented on Jun 30, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. 21 remaining items

  9. changed the title [-][Due for payment 2025-07-18] Improve performance of loading report transactions across components[/-] [+][Due for payment 2025-07-25] [Due for payment 2025-07-18] Improve performance of loading report transactions across components[/+] on Jul 18, 2025
  10. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-25. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    @eVoloshchak @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. RachCHopkins commented on Jul 21, 2025

    @RachCHopkins
    Contributor

    Waiting on checklist please @eVoloshchak

  13. eVoloshchak commented on Jul 21, 2025

    @eVoloshchak
    Contributor

    @RachCHopkins, not sure if checklist is needed here, this wasn't a bug, rather a performance improvement, so there is no PR that has caused this and no regression tests needed

  14. RachCHopkins commented on Jul 23, 2025

    @RachCHopkins
    Contributor

    Thanks @eVoloshchak! In that case, @roryabraham is this a Standard $250 pricetag?

  15. roryabraham commented on Jul 23, 2025

    @roryabraham
    Contributor
  16. melvin-bot commented on Jul 25, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@RachCHopkins)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. RachCHopkins commented on Jul 28, 2025

    @RachCHopkins
    Contributor

    Payment Summary:

    No Upwork job.

    🟢 to request payment @eVoloshchak!

  18. garrettmknight commented on Dec 18, 2025

    @garrettmknight
    Contributor

    $250 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions