Skip to content

[Due for payment 2025-09-04] Hover-to-view for receipt thumbnails #64195

Closed

Description

@MitchExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: NA
Reproducible in staging?: NA
Reproducible in production?: NA
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/508387
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07HPDRELLD/p1746728363364249?thread_ts=1746661519.862399&cid=C07HPDRELLD

Action Performed:

  1. Go to Reports or Expenses on desktop or web
  2. Hover your cursor over any receipt thumbnail (If no receipt image exists this feature is not expected to work)

Expected Result (New Feature):

Hovering over a receipt thumbnail will expand the entire receipt image

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

CleanShot.2025-05-22.at.10.18.20.mp4
Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    NewFeatureSomething to build that is a new item.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 13, 2025
  2. melvin-bot commented on Jun 13, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 13, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jun 13, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  5. melvin-bot commented on Jun 13, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  6. gijoe0295 commented on Jun 13, 2025

    @gijoe0295
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    New feature: Hover-to-view for receipt thumbnails

    What is the root cause of that problem?

    New feature

    What changes do you think we should make in order to solve the problem?

    Overall: In ReceiptCell here, use the Tooltip component and its renderTooltipContent prop to render the ReceiptImage and the ReceiptAudit on hover. For reference, I'll call this a receipt tooltip from now on.

    1. For the receipt tooltip container, we have 2 options:
      • Show the receipt image size as is, we keep its original aspect ratio
      • Set a fixed aspect ratio and width, like what we did we receipt image in expense report

    Image

    I think we should go with the latter choice. If so, we should specify maxWidth for the Tooltip component and width, aspectRatio for wrapperStyle. In the below POC, I used maxWidth and width as 360 and aspectRatio as 10/16 (portrait).

    1. For the receipt image itself, we can reuse the receipt image in ReceiptCell here (of course we need to create a variable for reusability)

    2. For the receipt audit text, we wrap ReceiptAudit component here inside a View with absolute positioning and zIndex to let it float on the receipt image. We also need a few new props to customize the style of this audit text.

    But here comes a question: What the audit text color should be like on different backgrounds of receipt images?

    We should extract the logic to get the notes and shouldShowAuditResult from MoneyRequestView here to a separate function to reuse in this case.

    1. We only show this tooltip if there's receipt image (either an eReceipt, a receipt image, a PDF thumbnail,...). So the Tooltip's shouldRender should be:
    shouldRender={!!source && !failedToLoad}

    failedToLoad can happen in PDFThumbnail and ThumbnailImage component. We need a callback param onFailedToLoad in ReceiptImage to set this state properly

    1. Other styling, implementation details can be discussed in PR

    POC

    Screen.Recording.2025-06-14.at.06.03.51.mp4

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  7. 111 remaining items

  8. changed the title [-]Hover-to-view for receipt thumbnails[/-] [+][Due for payment 2025-09-04] Hover-to-view for receipt thumbnails[/+] on Aug 28, 2025
  9. melvin-bot commented on Aug 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Aug 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.99-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Kicu requires payment (Needs manual offer from BZ)
    • @allroundexperts requires payment through NewDot Manual Requests
    • @borys3kk does not require payment (Contractor)
  11. melvin-bot commented on Aug 28, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  12. melvin-bot commented on Sep 4, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @Kicu paid $(AMOUNT) via Upwork (LINK)
    • Reviewer: @allroundexperts owed $250 via NewDot
    • Contributor: @borys3kk is from an agency-contributor and not due payment

    BugZero Checklist (@alexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. alexpensify commented on Sep 4, 2025

    @alexpensify
    Contributor

    Payment Summary

    Contributor: @Kicu and @mjasikowski Agency - N/A
    Contributor+: @allroundexperts due $250 via NewDot

  14. borys3kk commented on Sep 9, 2025

    @borys3kk
    Contributor

    Hi, just checking in are you satisfied with how this feature currently works, or would you still like to add the zoom and pan functionality (as shown in the issue recording)?
    cc @shawnborton

  15. shawnborton commented on Sep 9, 2025

    @shawnborton
    Contributor

    Good q - I kind of think it's pretty solid as it is. In the very least, let's live with it for now and make enhancements after we get more customers experiencing it.

  16. mountiny commented on Sep 9, 2025

    @mountiny
    Contributor
  17. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    approved $250 for @allroundexperts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions