You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-04] Hover-to-view for receipt thumbnails #64195
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️
Please re-state the problem that we are trying to solve in this issue.
New feature: Hover-to-view for receipt thumbnails
What is the root cause of that problem?
New feature
What changes do you think we should make in order to solve the problem?
Overall: In ReceiptCellhere, use the Tooltip component and its renderTooltipContent prop to render the ReceiptImage and the ReceiptAudit on hover. For reference, I'll call this a receipt tooltip from now on.
For the receipt tooltip container, we have 2 options:
Show the receipt image size as is, we keep its original aspect ratio
Set a fixed aspect ratio and width, like what we did we receipt image in expense report
I think we should go with the latter choice. If so, we should specify maxWidth for the Tooltip component and width, aspectRatio for wrapperStyle. In the below POC, I used maxWidth and width as 360 and aspectRatio as 10/16 (portrait).
For the receipt image itself, we can reuse the receipt image in ReceiptCellhere (of course we need to create a variable for reusability)
For the receipt audit text, we wrap ReceiptAudit component here inside a View with absolute positioning and zIndex to let it float on the receipt image. We also need a few new props to customize the style of this audit text.
But here comes a question: What the audit text color should be like on different backgrounds of receipt images?
We should extract the logic to get the notes and shouldShowAuditResult from MoneyRequestViewhere to a separate function to reuse in this case.
We only show this tooltip if there's receipt image (either an eReceipt, a receipt image, a PDF thumbnail,...). So the Tooltip's shouldRender should be:
shouldRender={!!source&&!failedToLoad}
failedToLoad can happen in PDFThumbnail and ThumbnailImage component. We need a callback param onFailedToLoad in ReceiptImage to set this state properly
Other styling, implementation details can be discussed in PR
POC
Screen.Recording.2025-06-14.at.06.03.51.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.99-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Hi, just checking in are you satisfied with how this feature currently works, or would you still like to add the zoom and pan functionality (as shown in the issue recording)?
cc @shawnborton
Good q - I kind of think it's pretty solid as it is. In the very least, let's live with it for now and make enhancements after we get more customers experiencing it.
Activity
melvin-bot commentedon Jun 13, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 13, 2025
Triggered auto assignment to @Christinadobrzyn (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.melvin-bot commentedon Jun 13, 2025
melvin-bot commentedon Jun 13, 2025
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)gijoe0295 commentedon Jun 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
New feature: Hover-to-view for receipt thumbnails
What is the root cause of that problem?
New feature
What changes do you think we should make in order to solve the problem?
Overall: In
ReceiptCellhere, use theTooltipcomponent and itsrenderTooltipContentprop to render theReceiptImageand theReceiptAuditon hover. For reference, I'll call this a receipt tooltip from now on.I think we should go with the latter choice. If so, we should specify
maxWidthfor theTooltipcomponent andwidth,aspectRatioforwrapperStyle. In the below POC, I usedmaxWidthandwidthas360andaspectRatioas10/16(portrait).For the receipt image itself, we can reuse the receipt image in
ReceiptCellhere (of course we need to create a variable for reusability)For the receipt audit text, we wrap
ReceiptAuditcomponent here inside aViewwith absolute positioning andzIndexto let it float on the receipt image. We also need a few new props to customize the style of this audit text.But here comes a question: What the audit text color should be like on different backgrounds of receipt images?
We should extract the logic to get the
notesandshouldShowAuditResultfromMoneyRequestViewhere to a separate function to reuse in this case.Tooltip'sshouldRendershould be:failedToLoadcan happen inPDFThumbnailandThumbnailImagecomponent. We need a callback paramonFailedToLoadinReceiptImageto set this state properlyPOC
Screen.Recording.2025-06-14.at.06.03.51.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
111 remaining items
[-]Hover-to-view for receipt thumbnails[/-][+][Due for payment 2025-09-04] Hover-to-view for receipt thumbnails[/+]melvin-bot commentedon Aug 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.99-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 28, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Sep 4, 2025
Payment Summary
Upwork Job
BugZero Checklist (@alexpensify)
alexpensify commentedon Sep 4, 2025
Payment Summary
Contributor: @Kicu and @mjasikowski Agency - N/A
Contributor+: @allroundexperts due $250 via NewDot
borys3kk commentedon Sep 9, 2025
Hi, just checking in are you satisfied with how this feature currently works, or would you still like to add the zoom and pan functionality (as shown in the issue recording)?
cc @shawnborton
shawnborton commentedon Sep 9, 2025
Good q - I kind of think it's pretty solid as it is. In the very least, let's live with it for now and make enhancements after we get more customers experiencing it.
mountiny commentedon Sep 9, 2025
Yeah thanks @borys3kk @Kicu @allroundexperts @shawnborton @dannymcclain @mjasikowski to getting this done!
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.