Skip to content

[BZ Check] [$250] onboarding-Concierge test drive task in Test drive receiver account directs to hmm not here #64292

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.97-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): slottwo1+f@gmail.com
Issue reported by: Applause Internal Team
Device used: windows 10 chrome
App Component: Other

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Sign up with a new account - choose get paid back flow
    3.Complete the test drive with another fake user who you can log into
    4.Log into the test drive receivers account
    5.Open concierge
  3. Click test drive task

Expected Result:

Concierge test drive task in Test drive receiver account must not direct to hmm not here page.

Actual Result:

Concierge test drive task in Test drive receiver account directs to hmm not here page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6862013_1750109708326.bandicam_2025-06-17_02-57-13-627.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021934985225189765472
  • Upwork Job ID: 1934985225189765472
  • Last Price Increase: 2025-06-17
  • Automatic offers:
    • thelullabyy | Contributor | 107738873
Issue OwnerCurrent Issue Owner: @ishpaul777

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 17, 2025
  2. melvin-bot commented on Jun 17, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. thelullabyy commented on Jun 17, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • When a concierge test drive task is viewed from the test drive receiver account, it incorrectly redirects to the "Hmm, not here" page.

    What is the root cause of that problem?

    • The taskReportID used in the navigation logic:
      onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(taskReportID, undefined, undefined, undefined, undefined, Navigation.getActiveRoute()))}

      is undefined unless the task report has already been opened once. This causes the navigation to attempt opening r/undefined, resulting in the error page.

    What changes do you think we should make in order to solve the problem?

    Currently, the code retrieves the taskReportID as follows:

    const taskReportID = taskReport?.reportID;

    We propose updating it to:

    const taskReportID = taskReport?.reportID ?? getOriginalMessage(action).taskReportID;

    This fallback ensures that even if taskReport data hasn't been fetched yet, the original message's taskReportID can be used to navigate to the correct report, which will then load its data as needed.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • N/A

    What alternative solutions did you explore? (Optional)

  4. dmkt9 commented on Jun 17, 2025

    @dmkt9
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-06-17 03:38:36 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Concierge test drive task in Test drive receiver account directs to hmm not here page.

    What is the root cause of that problem?

    • Because taskReport hasn’t been fetched yet, the taskReport passed to TaskPreview is undefined.
    • When we click on the item, navigation happens here. Since taskReport is undefined, taskReportID also becomes undefined, causing this issue.
      onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(taskReportID, undefined, undefined, undefined, undefined, Navigation.getActiveRoute()))}

    What changes do you think we should make in order to solve the problem?

    const taskReportID = action?.childReportID ?? taskReport?.reportID;

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 17, 2025
  6. changed the title [-]onboarding-Concierge test drive task in Test drive receiver account directs to hmm not here[/-] [+][$250] onboarding-Concierge test drive task in Test drive receiver account directs to hmm not here[/+] on Jun 17, 2025
  7. melvin-bot commented on Jun 17, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 17, 2025
  9. melvin-bot commented on Jun 17, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  10. zanyrenney commented on Jun 17, 2025

    @zanyrenney
    Contributor

    Broken workflow and quality issue.

  11. zanyrenney commented on Jun 17, 2025

    @zanyrenney
    Contributor

    Hey @ishpaul777 would you be able to please review the proposal above?

  12. 30 remaining items

  13. mallenexpensify commented on Jul 7, 2025

    @mallenexpensify
    Contributor

    @zanyrenney is out, I'll help with payment here

    Contributor: @thelullabyy paid $250 via Upwork
    Contributor+: @ishpaul777 due $250 via NewDot

    @thelullabyy can you please accept the job and reply here once you have?
    https://www.upwork.com/nx/wm/offer/107738873

    @ishpaul777 can you finished the BZ checklist above and inc the test case steps? Thx
    #64292 (comment)

  14. changed the title [-][Due for payment 2025-07-04] [$250] onboarding-Concierge test drive task in Test drive receiver account directs to hmm not here[/-] [+][BZ Check] [$250] onboarding-Concierge test drive task in Test drive receiver account directs to hmm not here[/+] on Jul 7, 2025
  15. thelullabyy commented on Jul 8, 2025

    @thelullabyy
    Contributor

    @mallenexpensify Thx, I accepted the job!

  16. mallenexpensify commented on Jul 8, 2025

    @mallenexpensify
    Contributor

    @thelullabyy paid, payment post updated above.
    BZ checklist when you get a min @ishpaul777

    thx

  17. ishpaul777 commented on Jul 9, 2025

    @ishpaul777
    Contributor

    will completed checklist today

  18. ishpaul777 commented on Jul 9, 2025

    @ishpaul777
    Contributor

    Checklist is done!

  19. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

  20. ishpaul777 commented on Jul 15, 2025

    @ishpaul777
    Contributor

    this is good to close

  21. mallenexpensify commented on Jul 16, 2025

    @mallenexpensify
    Contributor
  22. twisterdotcom commented on Aug 11, 2025

    @twisterdotcom
    Contributor

    @ishpaul777 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-53df-aa5a-99d4-5404ab5e0751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions