Skip to content

"Add work email address" button doesn't show up and text copy is not the correct one  #6439

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create new gmail account on New Expensify App (Build 1.1.16-1)
  2. Add an "OPEN" Bank Account
  3. Verify the bank account is added with a button to add work email address

Expected Result:

Bank Account added and a button to add work email address. Also the copy of the text reads:
image

Actual Result:

The Bank Account is added but the button to add work email address doesn't show up. A button with "Chat with Concierge" appears instead. Also copy of the text is not the correct one, it reads:
image

Workaround:

No workaround to finish the PR steps #6319

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.16-2

Reproducible in staging?: Yes
Reproducible in production?: N/A (New Feature)

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

Issue reported by:
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Nov 23, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. isagoico commented on Nov 23, 2021

    @isagoico
    Author

    Issue is failing PR #6319

  3. OSBotify commented on Nov 23, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. luacmartins commented on Nov 23, 2021

    @luacmartins
    Contributor
  5. luacmartins commented on Nov 23, 2021

    @luacmartins
    Contributor

    Even though the PR was deployed to staging, looking at the staging branch, the code doesn't seem to be there. We are CP'ing the changes again and we can try QA'ing it once more.

  6. luacmartins commented on Nov 23, 2021

    @luacmartins
    Contributor

    Code is on staging, @isagoico would you mind retesting #6319 please? If all looks good we can check it off the list.

  7. luacmartins commented on Nov 23, 2021

    @luacmartins
    Contributor

    Actually, I just tested it on staging and all looks good! Closing this issue and checking it off the list. Thanks!

    Screen Shot 2021-11-23 at 4 03 01 PM

    Screen Shot 2021-11-23 at 4 06 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions