Skip to content

[Due for payment 2025-07-17] [$250] Expense - App opens expense report after submitting per diem expense from empty report preview #64671

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.70-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #64212
Email or phone of affected tester (no customers): applausetester+200602kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace has per diem rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create report.
  4. Click Add expense button on the expense preview.
  5. Click Create new expense.
  6. Switch to Per diem.
  7. Select a destination and complete the flow to reach the confirmation page.
  8. Click Create expense.

Expected Result:

After submitting the per diem expense, app will stay in the main workspace chat because user submits the expense from the main workspace chat. (This is the behavior when manual expense is submitted from the empty report preview in the main workspace chat).

Actual Result:

After submitting per diem expense from the empty report preview in the main workspace chat, app opens the expense report instead of staying in main workspace chat.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021936144088452680602
  • Upwork Job ID: 1936144088452680602
  • Last Price Increase: 2025-06-20
  • Automatic offers:
    • allgandalf | Reviewer | 107779210
    • FitseTLT | Contributor | 107779211
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @NicMendonca

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 20, 2025
  2. github-actions commented on Jun 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jun 20, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jun 20, 2025

    @melvin-bot

    Triggered auto assignment to @JS00001 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jun 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. vincdargento commented on Jun 20, 2025

    @vincdargento
    Author

    @NicMendonca FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. 23 remaining items

  8. allgandalf commented on Jul 4, 2025

    @allgandalf
    Contributor

    PR approved

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 10, 2025
  10. changed the title [-][$250] Expense - App opens expense report after submitting per diem expense from empty report preview[/-] [+][Due for payment 2025-07-17] [$250] Expense - App opens expense report after submitting per diem expense from empty report preview[/+] on Jul 10, 2025
  11. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-17. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    @allgandalf @NicMendonca The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. allgandalf commented on Jul 13, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NO offending PR , check this comment

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Workspace has per diem rates.

    Test:

    1. Go to workspace chat.
    2. Click + > Create report.
    3. Click Add expense button on the expense preview.
    4. Click Create new expense.
    5. Switch to Per diem.
    6. Select a destination and complete the flow to reach the confirmation page.
    7. Click Create expense.

    Verify that After submitting the per diem expense, app will stay in the main workspace chat.

    Do we agree 👍 or 👎

  15. allgandalf commented on Jul 17, 2025

    @allgandalf
    Contributor

    payment today!

  16. NicMendonca commented on Jul 17, 2025

    @NicMendonca
    Contributor

    Payment summary

    Contributor: @FitseTLT - $250 via Upwork (done ✅ )
    Contributor+: @allgandalf - $250 via Upwork (done ✅ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions