Skip to content

iOS - VBA - User not directed with the secondary login model open tapping "Add work" email #6475

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app and login with gmail account
  2. Initiate VBA flow and add an "Open" bank account.
  3. At the last step tap "Add work email address"

Expected Result:

Opens new browser tab on OldDot and directs user to Settings > Account Details > Add secondary login with the secondary login modal open

Actual Result:

User is taken OldDot app with login screen

Workaround:

Uknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Desktop App

Version Number: 1.1.16-6

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5343624_Image_from_iOS.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Nov 25, 2021
  2. MelvinBot commented on Nov 25, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Nov 25, 2021
  4. changed the title [-]User not directed with the secondary login model open[/-] [+]iOS - VBA - User not directed with the secondary login model open[/+] on Nov 25, 2021
  5. OSBotify commented on Nov 25, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Nov 25, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. changed the title [-]iOS - VBA - User not directed with the secondary login model open[/-] [+]iOS - VBA - User not directed with the secondary login model open tapping Add work email[/+] on Nov 25, 2021
  8. changed the title [-]iOS - VBA - User not directed with the secondary login model open tapping Add work email[/-] [+]iOS - VBA - User not directed with the secondary login model open tapping "Add work" email[/+] on Nov 25, 2021
  9. luacmartins commented on Nov 25, 2021

    @luacmartins
    Contributor

    I can take this since I worked on this code.

  10. luacmartins commented on Nov 25, 2021

    @luacmartins
    Contributor

    It seems that iOS handles URL encoding differently. Working on a fix now.

  11. luacmartins commented on Nov 25, 2021

    @luacmartins
    Contributor

    Fix up #6479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions