[Due for payment 2025-07-18] [Due for payment 2025-07-15] [$250] Export to Xero-"Export to Xero" option is not displayed in the menu after paying the expense

@VictoriaExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.70-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6346816
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions: user is logged in to ND with a gmail account, has a workspace, which is connected to Xero. Xero auto-sync is enabled

Navigate to the workspace chat and create an expense
Open the expense details page, submit, approve and pay elsewhere the expense
Click the "More" menu

Expected Result:

"Export to Xero" option is displayed in the menu after paying the expense

Actual Result:

"Export to Xero" option is not displayed in the menu after paying the expense

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

Bug6867806_1750712079799.Export_to_Xero.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021937645701058425037
Upwork Job ID: 1937645701058425037
Last Price Increase: 2025-06-24
Automatic offers:

daledah | Contributor | 107877589

Issue Owner

Current Issue Owner: @VictoriaExpensify

@VictoriaExpensify

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Export to Xero" option is not displayed in the menu after paying the expense

What is the root cause of that problem?

We are checking with only isReportClosed and isReportApproved here

App/src/libs/ReportSecondaryActionUtils.ts

Lines 290 to 292 in ac8e0f3

    
           if (isReportPayer && arePaymentsEnabled && (isReportApproved || isReportClosed)) { 
        
               return true; 
        
           }

What changes do you think we should make in order to solve the problem?

We should isReportSettled to make sure that we can show the export to integration option after paying the expense

    const isReportSettled = isSettled(report);
    if (isReportPayer && arePaymentsEnabled && (isReportApproved || isReportClosed || isReportSettled)) {
        return true;
    }

App/src/libs/ReportSecondaryActionUtils.ts

Lines 290 to 292 in ac8e0f3

    
           if (isReportPayer && arePaymentsEnabled && (isReportApproved || isReportClosed)) { 
        
               return true; 
        
           }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update the isExportAction function test to cover this scenario

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Job added to Upwork: https://www.upwork.com/jobs/~021937645701058425037

@c3024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@c3024

@c3024 Huh... This is 4 days overdue. Who can take care of this?

I am checking this. Will update soon.

@c3024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.77-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-07-15. 🎊

For reference, here are some details about the assignees on this issue:

@c3024 requires payment through NewDot Manual Requests
@daledah requires payment automatic offer (Contributor)

@c3024

@c3024 @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@c3024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: allow export for settled expense #65672

If no regressions arise, payment will be issued on 2025-07-18. 🎊

For reference, here are some details about the assignees on this issue:

@c3024 requires payment through NewDot Manual Requests
@daledah requires payment automatic offer (Contributor)

@c3024

@c3024 @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@daledah

Payment Summary:
C: @daledah paid $250 via Upwork
C+: @c3024 owed $250 via NewDot

@c3024

@c3024 has submitted payment for this report on ND here.

SO: https://stackoverflowteams.com/c/expensify/questions/7582

Vendor found in VML: True. Status: Active
Amount requested: $250.00 (Matches the payment summary: [Due for payment 2025-07-18] [Due for payment 2025-07-15] [$250] Export to Xero-"Export to Xero" option is not displayed in the menu after paying the expense #64766 (comment))
I, @twisterdotcom am not already the BZ assignee. I have approved this payment.

Zapier Logs

Run ID: 00040eee-132a-a493-bf7f-c049505b84e1

Navigation Menu

Repository navigation

[Due for payment 2025-07-18] [Due for payment 2025-07-15] [$250] Export to Xero-"Export to Xero" option is not displayed in the menu after paying the expense #64766

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

44 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isReportPayer && arePaymentsEnabled && (isReportApproved \|\| isReportClosed)) {
	return true;
	}

[Due for payment 2025-07-18] [Due for payment 2025-07-15] [$250] Export to Xero-"Export to Xero" option is not displayed in the menu after paying the expense #64766

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 23, 2025

daledah commented on Jun 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jun 24, 2025

melvin-bot commented on Jun 24, 2025

melvin-bot commented on Jun 30, 2025

c3024 commented on Jun 30, 2025

44 remaining items

melvin-bot commented on Jul 8, 2025

melvin-bot commented on Jul 8, 2025

melvin-bot commented on Jul 11, 2025

melvin-bot commented on Jul 11, 2025

VictoriaExpensify commented on Jul 16, 2025

twisterdotcom commented on Jul 28, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions