Skip to content

[Due for payment 2025-07-04] [$250] Status - Vacation delegate without display name has a blank area instead of email as display name #64840

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.71-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): sdoijnsdoijswoij@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account > Status.
  3. Click Vacation delegate.
  4. Enter an existing user without display name (applausetester+sjdoids3jo@applause.expensifail.com
    ) and select it.
  5. Click Confirm.
  6. Click on the vacation delegate.

Expected Result:

The selected delegate will show email as display name

Actual Result:

The selected delegate has a blank area instead of showing display nam

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6868841_1750799050978.20250625_035525.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021937632333908955870
  • Upwork Job ID: 1937632333908955870
  • Last Price Increase: 2025-06-24
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Jun 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. samranahm commented on Jun 24, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Vacation delegate without display name has a blank area instead of email as display name

    What is the root cause of that problem?

    We have title for delegate here

    ...delegatePersonalDetails,
    text: delegatePersonalDetails?.displayName ?? '',

    if there is no displayName we fall back to empty string instead of using user's email/login

    What changes do you think we should make in order to solve the problem?

    We should fallBack to delegatePersonalDetails?.login in case of there is no displayName for user

    text: delegatePersonalDetails?.displayName ?? delegatePersonalDetails?.login,

    here

    ...delegatePersonalDetails,
    text: delegatePersonalDetails?.displayName ?? '',

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. rushatgabhane commented on Jun 24, 2025

    @rushatgabhane
    Member

    Part of vacation delegate project. Fixing this

  6. samranahm commented on Jun 24, 2025

    @samranahm
    Contributor

    @rushatgabhane I can submit a quick PR, if you allow

  7. rushatgabhane commented on Jun 24, 2025

    @rushatgabhane
    Member

    (not upto me 😅 )

  8. 7 remaining items

  9. deetergp commented on Jun 25, 2025

    @deetergp
    Contributor

    The PR for this has been merged.

  10. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. IuliiaHerets commented on Jun 26, 2025

    @IuliiaHerets

    Issue nor repro, Windows 11/ Chrome, Build v9.1.71-8

    video_21.mp4
  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 26, 2025
  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 27, 2025
  14. changed the title [-][$250] Status - Vacation delegate without display name has a blank area instead of email as display name[/-] [+][Due for payment 2025-07-04] [$250] Status - Vacation delegate without display name has a blank area instead of email as display name[/+] on Jun 27, 2025
  15. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-04. 🎊

    For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions