You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-04] [$250] Status - Vacation delegate without display name has a blank area instead of email as display name #64840
Version Number: 9.1.71-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail:#61845 Email or phone of affected tester (no customers):sdoijnsdoijswoij@gmail.com Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Status - Vacation delegate without display name has a blank area instead of email as display name[/-][+][Due for payment 2025-07-04] [$250] Status - Vacation delegate without display name has a blank area instead of email as display name[/+]on Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Jun 24, 2025
Triggered auto assignment to @inimaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 24, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 24, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon Jun 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Vacation delegate without display name has a blank area instead of email as display name
What is the root cause of that problem?
We have title for delegate here
App/src/pages/settings/Profile/CustomStatus/VacationDelegatePage.tsx
Lines 111 to 112 in 0dc8bd5
if there is no
displayNamewe fall back to empty string instead of using user's email/loginWhat changes do you think we should make in order to solve the problem?
We should fallBack to
delegatePersonalDetails?.loginin case of there is nodisplayNamefor userhere
App/src/pages/settings/Profile/CustomStatus/VacationDelegatePage.tsx
Lines 111 to 112 in 0dc8bd5
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
rushatgabhane commentedon Jun 24, 2025
Part of vacation delegate project. Fixing this
samranahm commentedon Jun 24, 2025
@rushatgabhane I can submit a quick PR, if you allow
rushatgabhane commentedon Jun 24, 2025
(not upto me 😅 )
7 remaining items
deetergp commentedon Jun 25, 2025
The PR for this has been merged.
melvin-bot commentedon Jun 25, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
IuliiaHerets commentedon Jun 26, 2025
Issue nor repro, Windows 11/ Chrome, Build v9.1.71-8
video_21.mp4
[-][$250] Status - Vacation delegate without display name has a blank area instead of email as display name[/-][+][Due for payment 2025-07-04] [$250] Status - Vacation delegate without display name has a blank area instead of email as display name[/+]melvin-bot commentedon Jun 27, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-04. 🎊
For reference, here are some details about the assignees on this issue: