You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-04] Expense - Amount change system message appears when amount is saved without edit #64857
Version Number: 9.1.71-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#56092 Email or phone of affected tester (no customers):jsndojdsosjdo@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Account has self DM.
Go to staging.new.expensify.com
Go to self DM.
Track a manual expense.
Click on the expense preview.
Click Amount.
Without editing the amount, click Save.
Expected Result:
There will be no system message for amount change when the amount is saved without edit.
Actual Result:
System message for amount change shows up every time the amount is saved without edit.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
we check if newAmount and currentTransaction is same but since newAmount was store as negative value and inside getAmount we remove the negative sign from track expense report that does not pass this check due to different sign with values
and we end up calling this function that make the lastAction MODIFIED_EXPENSE
What changes do you think we should make in order to solve the problem?
We should only consider the value by checking only absolute values that make sure if newAmount and transaction?.amount are same we don't call updateMoneyRequestAmountAndCurrency function
changed the title [-]Expense - Amount change system message appears when amount is saved without edit[/-][+][Due for payment 2025-07-04] Expense - Amount change system message appears when amount is saved without edit[/+]on Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@roryabraham@roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jun 24, 2025
Triggered auto assignment to @Valforte (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 24, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 24, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 24, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Valforte commentedon Jun 25, 2025
Offending PR is likely #56092 This bug is very minor as it only affect self DM so I'm ok demoting it, still needs to be fixed
can you take a look @pasyukevich ?
samranahm commentedon Jun 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Amount change system message appears when amount is saved without edit
What is the root cause of that problem?
-from amountApp/src/libs/TransactionUtils/index.ts
Lines 564 to 570 in 0dc8bd5
But for expense reports we store the amount with opposite sign (plus value)
App/src/libs/TransactionUtils/index.ts
Lines 576 to 582 in 0dc8bd5
then inside IOURequestStepAmount
App/src/pages/iou/request/step/IOURequestStepAmount.tsx
Lines 277 to 280 in 0dc8bd5
we check if
newAmountandcurrentTransactionis same but sincenewAmountwas store as negative value and insidegetAmountwe remove the negative sign from track expense report that does not pass this check due to different sign with valuesand we end up calling this function that make the lastAction
MODIFIED_EXPENSEApp/src/pages/iou/request/step/IOURequestStepAmount.tsx
Line 295 in 0dc8bd5
What changes do you think we should make in order to solve the problem?
We should only consider the value by checking only absolute values that make sure if
newAmountandtransaction?.amountare same we don't callupdateMoneyRequestAmountAndCurrencyfunctionhere
App/src/pages/iou/request/step/IOURequestStepAmount.tsx
Lines 277 to 280 in 0dc8bd5
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
we can explicitly check if it's Track expense report and apply math.abs on those reports only
here
App/src/pages/iou/request/step/IOURequestStepAmount.tsx
Lines 277 to 280 in 0dc8bd5
18 remaining items
[-]Expense - Amount change system message appears when amount is saved without edit[/-][+][Due for payment 2025-07-04] Expense - Amount change system message appears when amount is saved without edit[/+]melvin-bot commentedon Jun 27, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-04. 🎊
melvin-bot commentedon Jun 27, 2025
@roryabraham @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Sep 22, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Sep 22, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Sep 22, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 9, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.