Skip to content

[Due for payment 2025-08-13] [$250] User Settings-Undefined is stated instead of vacation delegate email #64879

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.71-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): agexptest+pr2406a@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 15
App Component: User Settings

Action Performed:

Precondition: Have a workspace with workflows enabled and an Approver user set.
The Approver user has set a vacation delegate who is not a workspace member.
The submitter can be the admin user or an employee.

  1. Go to staging.new.expensify.com
  2. Log in with the workspace admin
  3. Submit a manual expense to the workspace
  4. Go to the expense details (refresh if the system message in the chat is not shown)

Expected Result:

A system message appears in the chat stating the vacation delegate's email after "sent this report to..."

Actual Result:

The system message contains "undefined" instead of stating the vacation delegate's email.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6869039_1750815265314.Undefined_vacation_delegate.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021937914530637304542
  • Upwork Job ID: 1937914530637304542
  • Last Price Increase: 2025-08-14
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 25, 2025
  2. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jun 25, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Eskalifer1 commented on Jun 25, 2025

    @Eskalifer1
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User Settings-Undefined is stated instead of vacation delegate email

    What is the root cause of that problem?

    We currently have a type:

    type DelegateSubmitParams = {delegateUser: string; originalManager: string};

    which has delegateUser in it, but in fact we get the delegate field from the backend:

    Image

    What changes do you think we should make in order to solve the problem?

    There are 2 ways to solve the problem:

    1. Fix the field name on the backend, in this case you will not have to fix anything on the frontend

    2. Change the name of the field to delegate, then display this field (Perhaps on accounts that already had delegate users, the delegateUser field still comes, so you will need to take this into account here as well)

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. rushatgabhane commented on Jun 25, 2025

    @rushatgabhane
    Member

    @deetergp this message should not be sent to newDot, this is a oldDot message right?

    Or maybe we should handle this on frontend and display it properly.

    happens for vacation delegates that are not on the workspace

  8. 57 remaining items

  9. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @rushatgabhane requires payment through NewDot Manual Requests
    • @eh2077 requires payment through NewDot Manual Requests
  11. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    @rushatgabhane / @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  13. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @isabelastisser you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  14. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@isabelastisser)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1937914530637304542/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. melvin-bot commented on Aug 14, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  16. isabelastisser commented on Aug 15, 2025

    @isabelastisser
    Contributor

    I confirmed with @rushatgabhane that no payment is due here; this relates to the vacation delegate project.

  17. isabelastisser commented on Aug 15, 2025

    @isabelastisser
    Contributor

    Closing!

  18. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions