Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.71-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): agexptest+pr2406a@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 15
App Component: User Settings
Action Performed:
Precondition: Have a workspace with workflows enabled and an Approver user set.
The Approver user has set a vacation delegate who is not a workspace member.
The submitter can be the admin user or an employee.
- Go to staging.new.expensify.com
- Log in with the workspace admin
- Submit a manual expense to the workspace
- Go to the expense details (refresh if the system message in the chat is not shown)
Expected Result:
A system message appears in the chat stating the vacation delegate's email after "sent this report to..."
Actual Result:
The system message contains "undefined" instead of stating the vacation delegate's email.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6869039_1750815265314.Undefined_vacation_delegate.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021937914530637304542
- Upwork Job ID: 1937914530637304542
- Last Price Increase: 2025-08-14
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 25, 2025
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 25, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Eskalifer1 commentedon Jun 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User Settings-Undefined is stated instead of vacation delegate email
What is the root cause of that problem?
We currently have a type:
App/src/languages/params.ts
Line 382 in 014edee
which has delegateUser in it, but in fact we get the delegate field from the backend:
What changes do you think we should make in order to solve the problem?
There are 2 ways to solve the problem:
Fix the field name on the backend, in this case you will not have to fix anything on the frontend
Change the name of the field to delegate, then display this field (Perhaps on accounts that already had delegate users, the delegateUser field still comes, so you will need to take this into account here as well)
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
rushatgabhane commentedon Jun 25, 2025
@deetergp this message should not be sent to newDot, this is a oldDot message right?
Or maybe we should handle this on frontend and display it properly.
happens for vacation delegates that are not on the workspace
57 remaining items
melvin-bot commentedon Aug 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 6, 2025
@rushatgabhane / @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Aug 7, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Aug 13, 2025
Issue is ready for payment but no BZ is assigned. @isabelastisser you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Aug 13, 2025
Payment Summary
Upwork Job
BugZero Checklist (@isabelastisser)
melvin-bot commentedon Aug 14, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
isabelastisser commentedon Aug 15, 2025
I confirmed with @rushatgabhane that no payment is due here; this relates to the vacation delegate project.
isabelastisser commentedon Aug 15, 2025
Closing!