You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-04] [$250] Vacation delegate - User is not navigated back to status page after assigning a delegate #64885
Version Number: v9.1.71-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail:#61845 Email or phone of affected tester (no customers):htad26+ryuwey@gmail.com Issue reported by: Applause Internal Team Device used: Web App Component: User Settings
Action Performed:
Precondition:
During onboarding select any choice that wouldn't create a workspace
Navigate to staging.new.expensify.com and sign in with a new account
Go to Settings > Profile > Status
Click on the "Vacation delegate" section
Search for and select a user
Expected Result:
The user is navigated back to status page
Actual Result:
The user stays on the vacation delegate selector page and isn't navigated back to status page
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@rushatgabhane User isn't navigated back to status page when user doesn't have a workspace. There's no confirm modal shown up, which should be expected as there's no workspace created.
changed the title [-][$250] Vacation delegate - User is not navigated back to status page after assigning a delegate[/-][+][Due for payment 2025-07-04] [$250] Vacation delegate - User is not navigated back to status page after assigning a delegate[/+]on Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rushatgabhane / @eh2077@sakluger@rushatgabhane / @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @deetergp (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 25, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 25, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Eskalifer1 commentedon Jun 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Vacation delegate - User is not navigated back to status page after assigning a delegate
What is the root cause of that problem?
We only send the user back if it's a deletion or if a modal window opens
App/src/pages/settings/Profile/CustomStatus/VacationDelegatePage.tsx
Lines 168 to 189 in 014edee
What changes do you think we should make in order to solve the problem?
You need to redirect in a successful case:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
rushatgabhane commentedon Jun 25, 2025
Kindly demote this and assign it to me as part of vacation delegate project
eh2077 commentedon Jun 25, 2025
@rushatgabhane User isn't navigated back to status page when user doesn't have a workspace. There's no confirm modal shown up, which should be expected as there's no workspace created.
Screen.Recording.2025-06-25.at.10.48.34.PM.mov
19 remaining items
[-][$250] Vacation delegate - User is not navigated back to status page after assigning a delegate[/-][+][Due for payment 2025-07-04] [$250] Vacation delegate - User is not navigated back to status page after assigning a delegate[/+]melvin-bot commentedon Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 27, 2025
@rushatgabhane / @eh2077 @sakluger @rushatgabhane / @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jul 4, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
eh2077 commentedon Jul 6, 2025
The original PR has been reverted, so no payment needed here.
melvin-bot commentedon Jul 7, 2025
@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
sakluger commentedon Jul 7, 2025
@eh2077 (or @rushatgabhane) - could you please complete the BZ checklist?
sakluger commentedon Jul 8, 2025
@eh2077 I missed your comment about no payment being required. Thanks everyone!