Skip to content

[Due for payment 2025-07-04] [$250] Vacation delegate - User is not navigated back to status page after assigning a delegate #64885

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.71-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): htad26+ryuwey@gmail.com
Issue reported by: Applause Internal Team
Device used: Web
App Component: User Settings

Action Performed:

Precondition:
During onboarding select any choice that wouldn't create a workspace

  1. Navigate to staging.new.expensify.com and sign in with a new account
  2. Go to Settings > Profile > Status
  3. Click on the "Vacation delegate" section
  4. Search for and select a user

Expected Result:

The user is navigated back to status page

Actual Result:

The user stays on the vacation delegate selector page and isn't navigated back to status page

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021937889524656643777
  • Upwork Job ID: 1937889524656643777
  • Last Price Increase: 2025-06-25
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 25, 2025
  2. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 25, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Eskalifer1 commented on Jun 25, 2025

    @Eskalifer1
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Vacation delegate - User is not navigated back to status page after assigning a delegate

    What is the root cause of that problem?

    We only send the user back if it's a deletion or if a modal window opens

    const onSelectRow = useCallback(
    (option: Participant) => {
    if (option?.login === vacationDelegate?.delegate) {
    deleteVacationDelegate(vacationDelegate);
    Navigation.goBack(ROUTES.SETTINGS_STATUS);
    return;
    }
    setVacationDelegate(currentUserLogin ?? '', option?.login ?? '').then((response) => {
    if (!response?.jsonCode) {
    Navigation.goBack(ROUTES.SETTINGS_STATUS);
    return;
    }
    if (response.jsonCode === CONST.JSON_CODE.POLICY_DIFF_WARNING) {
    setIsWarningModalVisible(true);
    setNewVacationDelegate(option?.login ?? '');
    }
    });
    },
    [currentUserLogin, vacationDelegate],
    );

    What changes do you think we should make in order to solve the problem?

    You need to redirect in a successful case:

    if (response.jsonCode === CONST.JSON_CODE.SUCCESS) {
     Navigation.goBack(ROUTES.SETTINGS_STATUS);
     }
    const onSelectRow = useCallback(
            (option: Participant) => {
                if (option?.login === vacationDelegate?.delegate) {
                    deleteVacationDelegate(vacationDelegate);
                    Navigation.goBack(ROUTES.SETTINGS_STATUS);
                    return;
                }
    
                setVacationDelegate(currentUserLogin ?? '', option?.login ?? '').then((response) => {
                    console.log(response?.jsonCode, 'response?.jsonCode');
                    if (!response?.jsonCode) {
                        Navigation.goBack(ROUTES.SETTINGS_STATUS);
                        return;
                    }
    
                    if (response.jsonCode === CONST.JSON_CODE.POLICY_DIFF_WARNING) {
                        setIsWarningModalVisible(true);
                        setNewVacationDelegate(option?.login ?? '');
                    }
    
                    if (response.jsonCode === CONST.JSON_CODE.SUCCESS) {
                        Navigation.goBack(ROUTES.SETTINGS_STATUS);
                    }
                });
            },
            [currentUserLogin, vacationDelegate],
        );

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. rushatgabhane commented on Jun 25, 2025

    @rushatgabhane
    Member

    Kindly demote this and assign it to me as part of vacation delegate project

  8. eh2077 commented on Jun 25, 2025

    @eh2077
    Contributor

    @rushatgabhane User isn't navigated back to status page when user doesn't have a workspace. There's no confirm modal shown up, which should be expected as there's no workspace created.

    Screen.Recording.2025-06-25.at.10.48.34.PM.mov
  9. 19 remaining items

  10. changed the title [-][$250] Vacation delegate - User is not navigated back to status page after assigning a delegate[/-] [+][Due for payment 2025-07-04] [$250] Vacation delegate - User is not navigated back to status page after assigning a delegate[/+] on Jun 27, 2025
  11. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @rushatgabhane requires payment through NewDot Manual Requests
    • @eh2077 requires payment through NewDot Manual Requests
  12. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    @rushatgabhane / @eh2077 @sakluger @rushatgabhane / @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Jul 4, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@sakluger)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1937889524656643777/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. eh2077 commented on Jul 6, 2025

    @eh2077
    Contributor

    The original PR has been reverted, so no payment needed here.

  15. melvin-bot commented on Jul 7, 2025

    @melvin-bot

    @sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. sakluger commented on Jul 7, 2025

    @sakluger
    Contributor

    @eh2077 (or @rushatgabhane) - could you please complete the BZ checklist?

  17. sakluger commented on Jul 8, 2025

    @sakluger
    Contributor

    @eh2077 I missed your comment about no payment being required. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions