You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-05] [$250] iOS - Chat - Expand button does not appear in composer when entering multiline text #64900
Version Number: 9.1.71-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6354433 Email or phone of affected tester (no customers):fischer9966+062425eee@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 16 Pro / 18.5 App Component: Chat Report View
Action Performed:
Open iOS App
Login with any account
Go to any chat
Enter multiline text more then 3 lines into Composer
Expected Result:
Expand button appears in composer when entering multiline text more then 3 lines long
Actual Result:
Expand button does not appear in composer when entering multiline text more then 3 lines long. Expand button appears if user re-enter the chat without sending this message.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
iOS - Chat - Expand button does not appear in composer when entering multiline text
What is the root cause of that problem?
The cause of the problem is the behavior of iOS with onContentSizeChange. On IOS, when enableScroll !== false, onContentSizeChange may not work because of the internal implementation of UITextView on IOS.
What changes do you think we should make in order to solve the problem?
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@getusha@muttmuure The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 25, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 25, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Eskalifer1 commentedon Jun 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
iOS - Chat - Expand button does not appear in composer when entering multiline text
What is the root cause of that problem?
The cause of the problem is the behavior of iOS with onContentSizeChange. On IOS, when enableScroll !== false, onContentSizeChange may not work because of the internal implementation of UITextView on IOS.
What changes do you think we should make in order to solve the problem?
To do this, we need to change the function:
App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
Lines 775 to 785 in 67e472c
Take out the internal logic as follows:
Add a check for IOS and call this function in onLayout:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
blimpich commentedon Jun 25, 2025
Looking into this. I don't think this is worth blocking deploy on, but I'll see if I can find the offending PR before demoting.
blimpich commentedon Jun 25, 2025
Ugh, this only reproduces on iOS. I'm just gonna put this out to contributors. Not worth debugging to prevent this from going out to production IMO.
48 remaining items
melvin-bot commentedon Jul 29, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 29, 2025
@getusha @muttmuure The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Aug 7, 2025
@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Aug 11, 2025
@muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
muttmuure commentedon Aug 11, 2025
Payment Summary
Contributor: @linhvovan29546 paid $250 via Upwork
Contributor+: @getusha due $250 via NewDot
muttmuure commentedon Aug 11, 2025
Do we need a regression test? @getusha?
getusha commentedon Aug 12, 2025
Looks like we already have one @muttmuure
flaviadefaria commentedon Oct 2, 2025
$250 approved for @getusha