Skip to content

[Due for payment 2025-07-14] [$250] Card - Card filter with old UI #64976

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.71-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #64240
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: better to use account with several cards.

  1. Go to Reports
  2. Click on Filters
  3. Choose Card
  4. Select a couple of cards

Expected Result:

New UI for multi-select filter: square checkboxes and Reset button

Actual Result:

Old UI for multi-select filter: circle checkboxes and no Reset button

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6869934_1750883952973.Screen_Recording_2025-06-25_at_11.35.37_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021938715446898360036
  • Upwork Job ID: 1938715446898360036
  • Last Price Increase: 2025-06-27
  • Automatic offers:
    • linhvovan29546 | Contributor | 107869625
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 25, 2025
  2. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Christinadobrzyn commented on Jun 27, 2025

    @Christinadobrzyn
    Contributor

    I don't have a test account with company cards so I'm going to just assign external assuming it's happening.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 27, 2025
  5. changed the title [-]Card - Card filter with old UI[/-] [+][$250] Card - Card filter with old UI[/+] on Jun 27, 2025
  6. melvin-bot commented on Jun 27, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 27, 2025
  8. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  9. starwarsnerd77 commented on Jun 28, 2025

    @starwarsnerd77

    Proposal

    Problem:
    The multi-select filter for the Card option in the Reports > Filters sidebar is displaying with circular radio buttons instead of square checkboxes, and it’s missing the expected Reset button.

    Solution:
    This likely stems from using an outdated component (e.g., RadioListItem) or incorrect container styling (e.g., border radius or layout variant). It’s also possible the issue stems from using the wrong list wrapper, which may omit the Reset logic entirely.

    To proceed with implementation and verification, I will need access to a test account with multiple cards associated for proper UI rendering and interaction testing.

  10. melvin-bot commented on Jun 28, 2025

    @melvin-bot

    📣 @starwarsnerd77! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. linhvovan29546 commented on Jun 28, 2025

    @linhvovan29546
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Card - Card filter with old UI

    What is the root cause of that problem?

    The SearchFiltersCardPage component is using an outdated UI, which lacks the square checkbox and the Reset button. As a result, this appears to be a feature request rather than a bug.

    What changes do you think we should make in order to solve the problem?

    We need to update the SearchFiltersCardPage UI to match the design mentioned in the PR referenced in the OP. Specifically, we should:

    1. Add a square checkbox: CardListItem is used in SearchFiltersCardPage, which renders a circular checkbox. We should replace it with a square checkbox.
      <PressableWithFeedback
      onPress={handleCheckboxPress}
      disabled={isDisabled}
      role={CONST.ROLE.BUTTON}
      accessibilityLabel={item.text ?? ''}
      style={[styles.ml2, styles.optionSelectCircle]}
      >
      <SelectCircle
      isChecked={item.isSelected ?? false}
      selectCircleStyles={styles.ml0}
      />
      </PressableWithFeedback>
                    <Checkbox
                        shouldSelectOnPressEnter
                        isChecked={item.isSelected ?? false}
                        accessibilityLabel={item.text ?? ''}
                        onPress={() => onSelectRow(item)}
                        disabled={!!isDisabled}
                        style={styles.ml2}
                     />
    1. Add a Reset button to the footer: Add a Reset button to the footer by reusing the SearchFilterPageFooterButtons component.
      const footerContent = useMemo(
      () => (
      <Button
      success
      text={translate('common.save')}
      pressOnEnter
      onPress={handleConfirmSelection}
      large
      />
      ),
      [translate, handleConfirmSelection],
      );
        const resetChanges=useCallback(()=>{
            setSelectedCards([]);
        },[setSelectedCards]);
    
        const footerContent = useMemo(
            () => (
                <SearchFilterPageFooterButtons
                applyChanges={handleConfirmSelection}
                resetChanges={resetChanges}
                />
            ),
            [resetChanges, handleConfirmSelection],
        );

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A, UI change

    What alternative solutions did you explore? (Optional)

    Results

    Image
  12. 16 remaining items

  13. changed the title [-][$250] Card - Card filter with old UI[/-] [+][Due for payment 2025-07-14] [$250] Card - Card filter with old UI[/+] on Jul 7, 2025
  14. melvin-bot commented on Jul 7, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.76-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-14. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jul 7, 2025

    @melvin-bot

    @c3024 @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. c3024 commented on Jul 7, 2025

    @c3024
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  18. Christinadobrzyn commented on Jul 14, 2025

    @Christinadobrzyn
    Contributor

    Let us know about a regression test @c3024

    Payment summary here - #64976 (comment)

  19. Christinadobrzyn commented on Jul 15, 2025

    @Christinadobrzyn
    Contributor

    Dm'd @c3024 to find out about regression test

  20. c3024 commented on Jul 15, 2025

    @c3024
    Contributor

    No, this doesn't need a regression test.

  21. Christinadobrzyn commented on Jul 15, 2025

    @Christinadobrzyn
    Contributor

    thanks @c3024!

    Payment summary here - #64976 (comment)

    Please make sure to request payment through ND @c3024.

    Closing

  22. twisterdotcom commented on Jul 28, 2025

    @twisterdotcom
    Contributor

    @c3024 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-d3be-a698-986b-d52929cca891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions