Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.71-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #64240
Issue reported by: Applause - Internal Team
Action Performed:
Precondition: better to use account with several cards.
- Go to Reports
- Click on Filters
- Choose Card
- Select a couple of cards
Expected Result:
New UI for multi-select filter: square checkboxes and Reset button
Actual Result:
Old UI for multi-select filter: circle checkboxes and no Reset button
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6869934_1750883952973.Screen_Recording_2025-06-25_at_11.35.37_PM.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021938715446898360036
- Upwork Job ID: 1938715446898360036
- Last Price Increase: 2025-06-27
- Automatic offers:
- linhvovan29546 | Contributor | 107869625
Issue Owner
Current Issue Owner: @ChristinadobrzynMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Jun 25, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Christinadobrzyn commentedon Jun 27, 2025
I don't have a test account with company cards so I'm going to just assign external assuming it's happening.
[-]Card - Card filter with old UI[/-][+][$250] Card - Card filter with old UI[/+]melvin-bot commentedon Jun 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021938715446898360036
melvin-bot commentedon Jun 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)starwarsnerd77 commentedon Jun 28, 2025
Proposal
Problem:
The multi-select filter for the Card option in the Reports > Filters sidebar is displaying with circular radio buttons instead of square checkboxes, and it’s missing the expected Reset button.
Solution:
This likely stems from using an outdated component (e.g., RadioListItem) or incorrect container styling (e.g., border radius or layout variant). It’s also possible the issue stems from using the wrong list wrapper, which may omit the Reset logic entirely.
To proceed with implementation and verification, I will need access to a test account with multiple cards associated for proper UI rendering and interaction testing.
melvin-bot commentedon Jun 28, 2025
📣 @starwarsnerd77! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
linhvovan29546 commentedon Jun 28, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Card - Card filter with old UI
What is the root cause of that problem?
The SearchFiltersCardPage component is using an outdated UI, which lacks the square checkbox and the Reset button. As a result, this appears to be a feature request rather than a bug.
What changes do you think we should make in order to solve the problem?
We need to update the SearchFiltersCardPage UI to match the design mentioned in the PR referenced in the OP. Specifically, we should:
CardListItemis used inSearchFiltersCardPage, which renders a circular checkbox. We should replace it with a square checkbox.App/src/components/SelectionList/Search/CardListItem.tsx
Lines 147 to 158 in a8bf844
Resetbutton to the footer by reusing theSearchFilterPageFooterButtonscomponent.App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Lines 150 to 161 in a8bf844
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A, UI change
What alternative solutions did you explore? (Optional)
Results
16 remaining items
[-][$250] Card - Card filter with old UI[/-][+][Due for payment 2025-07-14] [$250] Card - Card filter with old UI[/+]melvin-bot commentedon Jul 7, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.76-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 7, 2025
@c3024 @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
c3024 commentedon Jul 7, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Christinadobrzyn commentedon Jul 14, 2025
Let us know about a regression test @c3024
Payment summary here - #64976 (comment)
Christinadobrzyn commentedon Jul 15, 2025
Dm'd @c3024 to find out about regression test
c3024 commentedon Jul 15, 2025
No, this doesn't need a regression test.
Christinadobrzyn commentedon Jul 15, 2025
thanks @c3024!
Payment summary here - #64976 (comment)
Please make sure to request payment through ND @c3024.
Closing
twisterdotcom commentedon Jul 28, 2025
@c3024 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-d3be-a698-986b-d52929cca891