Skip to content

Vacation delegate - After splitting expense as vacation delegate, "Hold" is not shown, two self DMs appear in LHN #65004

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.71-8
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): sdnjoidsjosdjsojo4@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Invite User B to the workspace.
  4. Go to Account > Status > Vacation delegate.
  5. Add User B as vacation delegate and click Save.
  6. Go to workspace chat.
  7. Submit an expense to the workspace chat.
  8. Click Submit on the expense preview.
  9. As User B, open the expense report.
  10. Click More > Split > Save.
  11. Open any expense row.
  12. Click More.
  13. "Hold" option is missing.
  14. Refresh the page.
  15. Click More.
  16. "Hold" option is present after refreshing the page.
  17. Open the two self DMs in LHN with GBR.

Expected Result:

In Step 13, after splitting expense, Hold option will be displayed immediately.

In Step 17, there will be no self DMs in LHN after splitting the expense as vacation delegate.

Actual Result:

In Step 13, after splitting expense, Hold option is not displayed in More menu until the page is refreshed.

In Step 17, there are two self DMs in LHN with GBR after splitting the expense as vacation delegate. The report disappears from LHN and header loads infinitely after opening the report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @marcochavezf
Issue OwnerCurrent Issue Owner: @marcochavezf

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 26, 2025
  2. melvin-bot commented on Jun 26, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 26, 2025

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 26, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 26, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Jun 26, 2025

    @vincdargento
    Author

    @sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. rushatgabhane commented on Jun 26, 2025

    @rushatgabhane
    Member

    not App blocker. backend missing update related

    @deetergp probably some more things that pusher should send?

    (if it is vacation delegate related)

  8. sakluger commented on Jun 26, 2025

    @sakluger
    Contributor

    @rushatgabhane do you want to be assigned to this one too?

  9. 33 remaining items

  10. deetergp commented on Jul 25, 2025

    @deetergp
    Contributor

    @rushatgabhane Yep, I'll add it to the list! 😅

  11. self-assigned this
    on Jul 25, 2025
  12. changed the title [-]Vacation delegate - After splitting expense as vacation delegate, "Hold" is not shown, two self DMs appear in LHN[/-] [+][HOLD App #65838] Vacation delegate - After splitting expense as vacation delegate, "Hold" is not shown, two self DMs appear in LHN[/+] on Jul 29, 2025
  13. deetergp commented on Jul 29, 2025

    @deetergp
    Contributor

    Held on #65838

  14. changed the title [-][HOLD App #65838] Vacation delegate - After splitting expense as vacation delegate, "Hold" is not shown, two self DMs appear in LHN[/-] [+]Vacation delegate - After splitting expense as vacation delegate, "Hold" is not shown, two self DMs appear in LHN[/+] on Aug 12, 2025
  15. deetergp commented on Aug 12, 2025

    @deetergp
    Contributor

    No longer on hold

  16. added and removed on Aug 12, 2025
  17. deetergp commented on Aug 13, 2025

    @deetergp
    Contributor

    I walked through the testing steps, and aside from there no longer being a More option when you select one of the expenses (It shows 1 selected now), the Hold option does appear in the drop down when you click it. I've asked for a retest here and will close if it isn't reproducible.

    Image
  18. m-natarajan commented on Aug 13, 2025

    @m-natarajan

    Issue is not reproducible on Windows 11/ Chrome in v9.1.93-7

    65004.mp4
  19. deetergp commented on Aug 13, 2025

    @deetergp
    Contributor

    Thanks! I wasn't able to recreate it in Chrome on Mac either. Closing it out!

  20. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffJuly2025Cleanup

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions