Skip to content

[PAY 12TH SEP][$500] Expense - App crashes after deleting expense #65121

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.72-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6375775
Email or phone of affected tester (no customers): sdhiuhsisudhsdisi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open 1:1 DM.
  3. Submit two expenses to the user.
  4. Open expense report.
  5. Select all expenses via checkbox.
  6. Click + > Create expense > Manual.
  7. Submit another expense to the user.
  8. Click on the expense from Step 7.
  9. Send a reply to the expense thread.
  10. Click on the report header.
  11. Click Delete expense.
  12. Delete the expense.

Expected Result:

App will not crash.

Actual Result:

App crashes after deleting expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Logs.txt

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021939758283282467315
  • Upwork Job ID: 1939758283282467315
  • Last Price Increase: 2025-07-15
  • Automatic offers:
    • Krishna2323 | Contributor | 108131302
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 28, 2025
  2. melvin-bot commented on Jun 28, 2025

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 28, 2025

    @melvin-bot

    Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 28, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 28, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on Jun 30, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

    • perf: transactions and violations by reports derived value #63655: This PR overhauls how transactions and violations are aggregated via a new derived value configuration across many report components. The deletion of an expense triggers updates in these lists, and if the new aggregation logic does not gracefully handle the removal of an expense, it could lead to state or data inconsistencies that crash the app.
    • fix: calculate violations when changing transaction report #64787: This PR modifies the transaction report update logic (changeTransactionsReport) and recalculates transaction violations when expenses are added to reports. Not very likely to be the cause.
  7. rushatgabhane commented on Jun 30, 2025

    @rushatgabhane
    Member

    @hoangzinh @TMisiukiewicz do you think #63655 caused this?

  8. 90 remaining items

  9. melvin-bot commented on Sep 8, 2025

    @melvin-bot

    @puneetlath, @Ollyws, @jliexpensify, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. jliexpensify commented on Sep 9, 2025

    @jliexpensify
    Contributor

    Deployed to prod

  11. changed the title [-][$500] Expense - App crashes after deleting expense[/-] [+][PAY 12TH SEP][$500] Expense - App crashes after deleting expense[/+] on Sep 9, 2025
  12. jliexpensify commented on Sep 9, 2025

    @jliexpensify
    Contributor

    Automation is broken, @Ollyws can we get the checklist please?

  13. Ollyws commented on Sep 12, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/52740/files#r2344847970

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Open 1:1 DM with a new user.
    2. Submit two expenses to the user.
    3. Open expense report.
    4. Select all expenses via checkbox.
    5. Click + > Create expense > Manual.
    6. Submit another expense to the user.
    7. Click on the expense from Step 7.
    8. Send a reply to the expense thread.
    9. Click on the report header.
    10. Click Delete expense.
    11. Delete the expense.
    12. Verify the app does not crash and the expense is deleted
    

    Do we agree 👍 or 👎

  14. jliexpensify commented on Sep 14, 2025

    @jliexpensify
    Contributor

    Payment Summary

    • C: @Krishna2323 $500 (to be paid via New Expensify requests)
    • C+: @Ollyws $500 (to be paid via New Expensify requests)
  15. Krishna2323 commented on Sep 14, 2025

    @Krishna2323
    Contributor

    Requested in ND!

  16. Ollyws commented on Sep 15, 2025

    @Ollyws
    Contributor

    Requested in ND.

  17. quinthar commented on Sep 17, 2025

    @quinthar
    Contributor

    Approved $250 for @Krishna2323

  18. flaviadefaria commented on Sep 19, 2025

    @flaviadefaria
    Contributor

    Approved $500 for for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions