Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6374176
Email or phone of affected tester (no customers): applausetester+ag2305ec@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome
App Component: Workspace Settings
Action Performed:
Precondition: Have a workspace with QBD connected, Expensify card enabled, and some cards issued.
Use an Expensifail account.
- Go to staging.new.expensify.com
- Log in as workspace admin
- Go to workspace settings > Accounting
- Click on the "Card reconciliation" option
Expected Result:
After clicking the "Card reconciliation" option, a right-hand panel is displayed, similar to when QBO is connected.
Actual Result:
The "Card reconciliation" option is unresponsive.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6872100_1751082394438.Card_reconciliation_unresponsive.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021940334966708474199
- Upwork Job ID: 1940334966708474199
- Last Price Increase: 2025-07-02
- Automatic offers:
- daledah | Contributor | 107905061
Issue Owner
Current Issue Owner: @daledahMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Jun 29, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Jun 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Card reconciliation" option is unresponsive.
What is the root cause of that problem?
For QBD, we do nothing when clicking "Card reconciliation" option
App/src/pages/workspace/accounting/utils.tsx
Line 284 in a8bf844
What changes do you think we should make in order to solve the problem?
We should navigate to Card Reconciliation page, similar to other integrations:
App/src/pages/workspace/accounting/utils.tsx
Line 256 in a8bf844
App/src/pages/workspace/accounting/utils.tsx
Line 198 in a8bf844
Fix here
App/src/pages/workspace/accounting/utils.tsx
Line 284 in a8bf844
There's another bug in Card Reconciliation page:
if we have QBD option, the auto sync link is unresponsive:
Screen.Recording.2025-06-30.at.02.40.30.mov
It's because we don't handle QBD integration here
App/src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx
Lines 88 to 105 in a8bf844
We should navigate to QBD Advanced settings here:
Also another bug where after navigating to QBD Advanced settings page, when clicking back button we dismiss modal. We can address this bug in the PR phase or handle it in a different issue
Screen.Recording.2025-06-30.at.02.48.56.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None, it's a UI bug.
What alternative solutions did you explore? (Optional)
I don't think there's a reason this button should not work. But in the case we designed to not want "Card reconciliation" option to be displayed, we can modify
shouldShowCardReconciliationOptionhere to befalseif integration is QBDApp/src/pages/workspace/accounting/PolicyAccountingPage.tsx
Line 116 in a8bf844
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
JmillsExpensify commentedon Jul 2, 2025
Opening up to the community
[-]QBD-Card reconciliation is unresponsive[/-][+][$250] QBD-Card reconciliation is unresponsive[/+]melvin-bot commentedon Jul 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021940334966708474199
melvin-bot commentedon Jul 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)10 remaining items
daledah commentedon Jul 7, 2025
@s77rt PR is ready.
melvin-bot commentedon Jul 31, 2025
This issue has not been updated in over 15 days. @JmillsExpensify, @marcochavezf, @s77rt, @daledah eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
s77rt commentedon Jul 31, 2025
Looks like automation failed, PR was deployed to production 2 weeks ago
s77rt commentedon Aug 10, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [QBD] Handle the initial connection for QBD #50216 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No. This issue was caused due to a forgotten todo item
s77rt commentedon Aug 10, 2025
@JmillsExpensify Can you please handle payment here
daledah commentedon Aug 22, 2025
Friendly bump @JmillsExpensify #65148 (comment).
JmillsExpensify commentedon Aug 22, 2025
Payment summary:
JmillsExpensify commentedon Aug 22, 2025
Upwork contract paid out. Going to close out, though please request via ND for remaining payment.
garrettmknight commentedon Aug 26, 2025
$250 approved for @s77rt