Skip to content

[$250] QBD-Card reconciliation is unresponsive #65148

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6374176
Email or phone of affected tester (no customers): applausetester+ag2305ec@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome
App Component: Workspace Settings

Action Performed:

Precondition: Have a workspace with QBD connected, Expensify card enabled, and some cards issued.
Use an Expensifail account.

  1. Go to staging.new.expensify.com
  2. Log in as workspace admin
  3. Go to workspace settings > Accounting
  4. Click on the "Card reconciliation" option

Expected Result:

After clicking the "Card reconciliation" option, a right-hand panel is displayed, similar to when QBO is connected.

Actual Result:

The "Card reconciliation" option is unresponsive.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6872100_1751082394438.Card_reconciliation_unresponsive.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021940334966708474199
  • Upwork Job ID: 1940334966708474199
  • Last Price Increase: 2025-07-02
  • Automatic offers:
    • daledah | Contributor | 107905061
Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 29, 2025
  2. melvin-bot commented on Jun 29, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Jun 29, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "Card reconciliation" option is unresponsive.

    What is the root cause of that problem?

    For QBD, we do nothing when clicking "Card reconciliation" option

    onCardReconciliationPagePress: () => {},

    What changes do you think we should make in order to solve the problem?

    We should navigate to Card Reconciliation page, similar to other integrations:

    onCardReconciliationPagePress: () => Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_CARD_RECONCILIATION.getRoute(policyID, CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT)),

    onCardReconciliationPagePress: () => Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_CARD_RECONCILIATION.getRoute(policyID, CONST.POLICY.CONNECTIONS.ROUTE.NETSUITE)),

    Fix here

    onCardReconciliationPagePress: () => {},

    onCardReconciliationPagePress: () => Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_CARD_RECONCILIATION.getRoute(policyID, CONST.POLICY.CONNECTIONS.ROUTE.QBD))

    There's another bug in Card Reconciliation page:

    if we have QBD option, the auto sync link is unresponsive:

    Screen.Recording.2025-06-30.at.02.40.30.mov

    It's because we don't handle QBD integration here

    const navigateToAdvancedSettings = useCallback(() => {
    switch (connection) {
    case CONST.POLICY.CONNECTIONS.ROUTE.QBO:
    Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC.getRoute(policyID, Navigation.getActiveRoute()));
    break;
    case CONST.POLICY.CONNECTIONS.ROUTE.XERO:
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_XERO_ADVANCED.getRoute(policyID));
    break;
    case CONST.POLICY.CONNECTIONS.ROUTE.NETSUITE:
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_AUTO_SYNC.getRoute(policyID, Navigation.getActiveRoute()));
    break;
    case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED.getRoute(policyID));
    break;
    default:
    break;
    }
    }, [connection, policyID]);

    We should navigate to QBD Advanced settings here:

        case CONST.POLICY.CONNECTIONS.ROUTE.QBD:
            Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED.getRoute(policyID));
        break;

    Also another bug where after navigating to QBD Advanced settings page, when clicking back button we dismiss modal. We can address this bug in the PR phase or handle it in a different issue

    Screen.Recording.2025-06-30.at.02.48.56.mov

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None, it's a UI bug.

    What alternative solutions did you explore? (Optional)

    I don't think there's a reason this button should not work. But in the case we designed to not want "Card reconciliation" option to be displayed, we can modify shouldShowCardReconciliationOption here to be false if integration is QBD

    const shouldShowCardReconciliationOption = Object.values(allCardSettings ?? {})?.some((cardSetting) => isExpensifyCardFullySetUp(policy, cardSetting));

    const shouldShowCardReconciliationOption = Object.values(allCardSettings ?? {})?.some((cardSetting) => isExpensifyCardFullySetUp(policy, cardSetting)) && connectedIntegration !== CONST.POLICY.CONNECTIONS.NAME.QBD
    Image

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. JmillsExpensify commented on Jul 2, 2025

    @JmillsExpensify
    Contributor

    Opening up to the community

  5. changed the title [-]QBD-Card reconciliation is unresponsive[/-] [+][$250] QBD-Card reconciliation is unresponsive[/+] on Jul 2, 2025
  6. melvin-bot commented on Jul 2, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 2, 2025
  8. melvin-bot commented on Jul 2, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  9. 10 remaining items

  10. daledah commented on Jul 7, 2025

    @daledah
    Contributor

    @s77rt PR is ready.

  11. melvin-bot commented on Jul 31, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @JmillsExpensify, @marcochavezf, @s77rt, @daledah eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. s77rt commented on Jul 31, 2025

    @s77rt
    Member

    Looks like automation failed, PR was deployed to production 2 weeks ago

  13. s77rt commented on Aug 10, 2025

    @s77rt
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [QBD] Handle the initial connection for QBD #50216 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: n/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      Bug requires regression test: No. This issue was caused due to a forgotten todo item

  14. s77rt commented on Aug 10, 2025

    @s77rt
    Member

    @JmillsExpensify Can you please handle payment here

  15. daledah commented on Aug 22, 2025

    @daledah
    Contributor
  16. JmillsExpensify commented on Aug 22, 2025

    @JmillsExpensify
    Contributor

    Payment summary:

    • Contributor: $250 @daledah via Upwork
    • Contributor+: $250 @s77rt via New Expensify
  17. JmillsExpensify commented on Aug 22, 2025

    @JmillsExpensify
    Contributor

    Upwork contract paid out. Going to close out, though please request via ND for remaining payment.

  18. garrettmknight commented on Aug 26, 2025

    @garrettmknight
    Contributor

    $250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions