Skip to content

[$250] [Due for payment 2025-07-15] To-do-Expense from 1:1 chat is included in the Approve and Pay To-do sections #65346

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.74-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6417797
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.5 Chrome, iPhone 15 iOS 18.5
App Component: Search

Action Performed:

  1. Navigate to staging.new.expensify.com and log in with gmail account, create a workspace
  2. From another account send a manual expense to the main user
  3. As the main user, navigate to the Reports tab, in the To-do section open Approve, then Pay

Expected Result:

Expense from 1:1 chat is displayed in the Pay section, since the only action possible here is "Pay"

Actual Result:

Expense from 1:1 chat is included in the Approve and Pay To-do sections at the same time

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021944762919009636335
  • Upwork Job ID: 1944762919009636335
  • Last Price Increase: 2025-07-14

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 2, 2025
  2. github-actions commented on Jul 2, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jul 2, 2025

    @melvin-bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jul 2, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Jul 2, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. BlameGPT commented on Jul 2, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

    If not above, check these

    • Bring back new sign-in page #64786: PR modifies libs/actions/Report.ts and related report state logic, which drives the To-do Approve/Pay categorization, so its changes could cause an expense to appear in both sections.
  7. JS00001 commented on Jul 2, 2025

    @JS00001
    Contributor

    Not a deploy blocker, happens on prod:

    Image

  8. 22 remaining items

  9. johncschuster commented on Jul 14, 2025

    @johncschuster
    Contributor

    Applying External so the Upwork job is created automatically. @getusha, can you apply to the job above?

  10. johncschuster commented on Jul 14, 2025

    @johncschuster
    Contributor

    Oh nevermind! I see you get paid via ND. Ignore that!

  11. johncschuster commented on Jul 14, 2025

    @johncschuster
    Contributor

    Payment Summary

    Contributor+: @getusha due $125 via NewDot

  12. johncschuster commented on Jul 15, 2025

    @johncschuster
    Contributor

    @getusha can you complete the BZ Checklist above when you get a moment?

  13. JS00001 commented on Jul 15, 2025

    @JS00001
    Contributor

    Let's make this one $125, it was mostly a BE fix, (The FE one was 2 lines) and was technically a regression as well. However, open to hearing @getusha 's opinion as well!

  14. getusha commented on Jul 15, 2025

    @getusha
    Contributor

    Yeah, that sounds good. It was a simple, straightforward PR.

    and was technically a regression as well.

    I remember logging this issue (or a similar one) during a review, and we decided to take no action.

  15. JS00001 commented on Jul 15, 2025

    @JS00001
    Contributor

    I remember logging this issue (or a similar one) during a review, and we decided to take no action.

    Oh yeah I completely forgot about that, thats true. Either way, I still think the change itself was probably a $125 value issue, LMK if you disagree

  16. getusha commented on Jul 15, 2025

    @getusha
    Contributor

    Either way, I still think the change itself was probably a $125 value issue, LMK if you disagree

    Yeah, like I said, that works for me. It was just a small PR. Just mentioned that because i shouldn't be paid if it was a regression.

  17. JS00001 commented on Jul 15, 2025

    @JS00001
    Contributor

    Sounds good, thanks! @johncschuster I've updated your comment for the payment summary

  18. garrettmknight commented on Jul 17, 2025

    @garrettmknight
    Contributor

    $125 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions