You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2025-07-15] To-do-Expense from 1:1 chat is included in the Approve and Pay To-do sections #65346
Version Number: 9.1.74-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6417797 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: MacBook Air 15.5 Chrome, iPhone 15 iOS 18.5 App Component: Search
Action Performed:
Navigate to staging.new.expensify.com and log in with gmail account, create a workspace
From another account send a manual expense to the main user
As the main user, navigate to the Reports tab, in the To-do section open Approve, then Pay
Expected Result:
Expense from 1:1 chat is displayed in the Pay section, since the only action possible here is "Pay"
Actual Result:
Expense from 1:1 chat is included in the Approve and Pay To-do sections at the same time
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Bring back new sign-in page #64786: PR modifies libs/actions/Report.ts and related report state logic, which drives the To-do Approve/Pay categorization, so its changes could cause an expense to appear in both sections.
Let's make this one $125, it was mostly a BE fix, (The FE one was 2 lines) and was technically a regression as well. However, open to hearing @getusha 's opinion as well!
Activity
github-actions commentedon Jul 2, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 2, 2025
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 2, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 2, 2025
💬 A slack conversation has been started in #expensify-open-source
BlameGPT commentedon Jul 2, 2025
Possible culprit PRs for this issue
If not above, check these
JS00001 commentedon Jul 2, 2025
Not a deploy blocker, happens on prod:
22 remaining items
johncschuster commentedon Jul 14, 2025
Applying
Externalso the Upwork job is created automatically. @getusha, can you apply to the job above?johncschuster commentedon Jul 14, 2025
Oh nevermind! I see you get paid via ND. Ignore that!
johncschuster commentedon Jul 14, 2025
Payment Summary
Contributor+: @getusha due $125 via NewDot
johncschuster commentedon Jul 15, 2025
@getusha can you complete the BZ Checklist above when you get a moment?
JS00001 commentedon Jul 15, 2025
Let's make this one $125, it was mostly a BE fix, (The FE one was 2 lines) and was technically a regression as well. However, open to hearing @getusha 's opinion as well!
getusha commentedon Jul 15, 2025
Yeah, that sounds good. It was a simple, straightforward PR.
I remember logging this issue (or a similar one) during a review, and we decided to take no action.
JS00001 commentedon Jul 15, 2025
Oh yeah I completely forgot about that, thats true. Either way, I still think the change itself was probably a $125 value issue, LMK if you disagree
getusha commentedon Jul 15, 2025
Yeah, like I said, that works for me. It was just a small PR. Just mentioned that because i shouldn't be paid if it was a regression.
JS00001 commentedon Jul 15, 2025
Sounds good, thanks! @johncschuster I've updated your comment for the payment summary
garrettmknight commentedon Jul 17, 2025
$125 approved for @getusha