Skip to content

ND instead of OD after await NVP.set("tryNewDot", undefined); #65395

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.74-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #64786
Email or phone of affected tester (no customers): applausetester+dp222@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows / Chrome
App Component: Other

Action Performed:

Preconditions: While logged in under OD set tryNewDot to undefined
by running in console following: await NVP.set("tryNewDot", undefined);

  1. Open ND app
  2. Log in using preset account described in preconditions

Expected Result:

user is moved straight to OD and Try New Expensify button is no visible

Actual Result:

User is moved to ND

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 3, 2025
  2. melvin-bot commented on Jul 3, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Eskalifer1 commented on Jul 3, 2025

    @Eskalifer1
    Contributor

    Uh... I'm not sure, but if we set it to undefined, then we don't know if the user is from the old platform or the new one, in which case everything works as if the user is here for the first time and just opened ND, so to me this is the expected behavior

    But I may be wrong

  4. clarajones-expensify commented on Jul 7, 2025

    @clarajones-expensify
    Contributor

    @jponikarchuk - can you clarify more on the actual result versus the expected result? I am not sure I understand what you are expecting to happen and why. Thanks!

  5. jponikarchuk commented on Jul 8, 2025

    @jponikarchuk
    Author

    @clarajones-expensify Expected Result according to this PR: user is moved to OD after log in and Try New Expensify button is no visible

    Image
  6. mallenexpensify commented on Jul 9, 2025

    @mallenexpensify
    Contributor

    @inimaga ) @Julesssss @mateuuszzzzz y'all worked on the PR this came from. Do you also want to work on this??!?

  7. Julesssss commented on Jul 10, 2025

    @Julesssss
    Contributor

    This is expected behaviour, but I understand the confusion.

    • For web, users on NewDot URL should remain there
    • For HybridApp, users should be routed depending on the tryNewDot NVP

    That linked PR only modified HybridApp, but we could make that a bit clearer in the test steps 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions