You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-22] [$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline #65413
Version Number: 9.1.74-9 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/6414951 Email or phone of affected tester (no customers):jiodnjsoijdoi@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace has per diem rates.
Go to staging.new.expensify.com
Go to workspace chat.
Submit two per diem expenses to the workspace chat.
Open the expense report.
Click More > Delete.
Delete the report.
Go to self DM.
Open the unreported per diem expense.
Go offline.
Expected Result:
"moved this expense to your personal space" will not gray out in offline mode.
Actual Result:
"moved this expense to your personal space" grays out in offline mode.
Please re-state the problem that we are trying to solve in this issue.
"moved this expense to your personal space" grays out in offline mode.
What is the root cause of that problem?
We added the unreported action in optimistic data, but we forgot to update pendingAction as null in success data then this action is still grayed out after going offline.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update deleteAppReport test to verify the pending action of unreported action is updated after the API is success.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - "moved this expense to personal space" in per diem expense grays out when offline[/-][+][$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline[/+]on Jul 3, 2025
changed the title [-][$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline[/-][+][Due for payment 2025-07-22] [$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline[/+]on Jul 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@NicMendonca The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Workspace with per diem rates
Test:
Open workspace chat
Submit 2 per diem expenses
Open the expense report and delete it
Go to self DM
Verify you see the previously submitted expenses (they are now moved to self DM)
Open one of the two expenses
Verify "moved this expense to your personal space" message is displayed
Go offline
Verify "moved this expense to your personal space" is not grayed out
Activity
melvin-bot commentedon Jul 3, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon Jul 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"moved this expense to your personal space" grays out in offline mode.
What is the root cause of that problem?
We added the unreported action in optimistic data, but we forgot to update
pendingActionasnullin success data then this action is still grayed out after going offline.App/src/libs/actions/Report.ts
Lines 4874 to 4878 in 9e3b5bd
What changes do you think we should make in order to solve the problem?
We should update
pendingActiontonullin success data and for failure data we can add an error message or remove this action if neededApp/src/libs/actions/Report.ts
Lines 4874 to 4878 in 9e3b5bd
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update
deleteAppReporttest to verify the pending action of unreported action is updated after the API is success.What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Expense - "moved this expense to personal space" in per diem expense grays out when offline[/-][+][$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline[/+]melvin-bot commentedon Jul 3, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021940923188688861275
melvin-bot commentedon Jul 3, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)s77rt commentedon Jul 4, 2025
@thelullabyy Thanks for the proposal. Your RCA and solution look good to me.
🎀 👀 🎀 C+ reviewed
Link to proposal
melvin-bot commentedon Jul 4, 2025
Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
6 remaining items
[-][$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline[/-][+][Due for payment 2025-07-22] [$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline[/+]melvin-bot commentedon Jul 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2025
@s77rt @NicMendonca The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
s77rt commentedon Jul 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Simplified Actions] Implement DeleteAppReport #58020 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
NicMendonca commentedon Jul 22, 2025
Payment summary
C+: @s77rt paid $250 via NewDot
Contributor: @thelullabyy paid $250 via Upwork (done ✅ )
JmillsExpensify commentedon Jul 25, 2025
$250 approved for @s77rt