[Due for payment 2025-07-15] [Due for payment 2025-07-14] [$125] Filters - Category and tag lists are missing in the advanced filters

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.76-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6424550&group_by=cases:section_id&group_order=asc&group_id=319502
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.4.1 Safari, Desktop, iPhone 13 iOS 18.5 Safari, Hybrid
App Component: Search

Action Performed:

Preconditions: User is an admin of a workspace that has tag and categories enabled.

Navigate to https://staging.new.expensify.com
Navigate to "Reports"
Click the "Advanced Filters"
Select Tags
Select Categories

Expected Result:

The user can see the list of tags and categories in the advanced filters

Actual Result:

Category and tag lists are missing in the advanced filters

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021942148887174937779
Upwork Job ID: 1942148887174937779
Last Price Increase: 2025-07-07

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mjasikowski

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

Possible culprit PRs for this issue

Support for Multi workspace filter in search #63706: This PR rewrote SearchFiltersTagPage.tsx and SearchFiltersCategoryPage.tsx to handle multi-workspace filters, changing how tag and category lists are loaded and likely causing them to appear empty in advanced filters.
Refactor usages of useOnyx to use the App wrapper #64746: Mass refactor replaced useOnyx imports (including in Tag and Category filter pages), and any mistake in the new hook usage could stop those lists from populating.

If not above, check these

Bump react-native-onyx to 2.0.113 #65161: Updating react-native-onyx alters how Onyx data (including policy categories and tags used to populate Advanced Filters) is stored/read, so the lists no longer load and appear missing.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Filters - Category and tag lists are missing in the advanced filters

What is the root cause of that problem?

Simple mistake during initial implementation
This condition was ment to check of selectedPoliciesCategories is an empty array but even an empty array is truthy value and hence this condition never executes.

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx

Line 38 in c71d38e

if (!selectedPoliciesCategories) {

What changes do you think we should make in order to solve the problem?

instead check the length of selectedPoliciesCategories array.

        if (!selectedPoliciesCategories.length) {

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx

Line 38 in c71d38e

if (!selectedPoliciesCategories) {

Do the same for tags page.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Use same logic as used on taxRates page to filter tags and categories, which is working as expected.

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx

Lines 21 to 41 in c71d38e

    
           const allTaxRates = getAllTaxRates(); 
        
           const selectedTaxesItems: SearchMultipleSelectionPickerItem[] = []; 
        
           Object.entries(allTaxRates).forEach(([taxRateName, taxRateKeys]) => { 
        
               searchAdvancedFiltersForm?.taxRate?.forEach((taxRateKey) => { 
        
                   if (!taxRateKeys.includes(taxRateKey) || selectedTaxesItems.some((item) => item.name === taxRateName)) { 
        
                       return; 
        
                   } 
        
                   selectedTaxesItems.push({name: taxRateName, value: taxRateKeys}); 
        
               }); 
        
           }); 
        
           const policyIDs = searchAdvancedFiltersForm?.policyID ?? []; 
        
           const [policies] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}`, { 
        
               selector: (allPolicies) => (allPolicies ? Object.values(allPolicies).filter((policy) => policy && policyIDs.includes(policy.id)) : undefined), 
        
               canBeMissing: true, 
        
           }); 
        
           const selectedPoliciesTaxRates = policies?.map((policy) => policy?.taxRates?.taxes).filter((taxRates) => !!taxRates); 
        
           const taxItems = useMemo(() => { 
        
               if (!selectedPoliciesTaxRates) { 
        
                   return Object.entries(allTaxRates).map(([taxRateName, taxRateKeys]) => ({name: taxRateName, value: taxRateKeys})); 
        
               }

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@parasharrajat

@parasharrajat @luacmartins loooks related to your PR #65453 (comment)

@shubham1206agra

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.76-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-07-14. 🎊

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment through NewDot Manual Requests

@shubham1206agra

@shubham1206agra @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@shubham1206agra

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.77-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-07-15. 🎊

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment through NewDot Manual Requests

@shubham1206agra

@shubham1206agra @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@shubham1206agra

Testrail caught this one and original issue/PR identified. No checklist needed.

Payment Summary:

Reviewer: @shubham1206agra $125 via NewDot

@garrettmknight

@garrettmknight I receive payment via NewDot.

Ah, typo. Updatded.

@shubham1206agra

Payment summary: @shubham1206agra $125 via NewDot

@shubham1206agra

$250 approved for @shubham1206agra

Navigation Menu

Repository navigation

[Due for payment 2025-07-15] [Due for payment 2025-07-14] [$125] Filters - Category and tag lists are missing in the advanced filters #65453

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Possible culprit PRs for this issue

If not above, check these

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

40 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const allTaxRates = getAllTaxRates();
	const selectedTaxesItems: SearchMultipleSelectionPickerItem[] = [];
	Object.entries(allTaxRates).forEach(([taxRateName, taxRateKeys]) => {
	searchAdvancedFiltersForm?.taxRate?.forEach((taxRateKey) => {
	if (!taxRateKeys.includes(taxRateKey) \|\| selectedTaxesItems.some((item) => item.name === taxRateName)) {
	return;
	}
	selectedTaxesItems.push({name: taxRateName, value: taxRateKeys});
	});
	});
	const policyIDs = searchAdvancedFiltersForm?.policyID ?? [];
	const [policies] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}`, {
	selector: (allPolicies) => (allPolicies ? Object.values(allPolicies).filter((policy) => policy && policyIDs.includes(policy.id)) : undefined),
	canBeMissing: true,
	});
	const selectedPoliciesTaxRates = policies?.map((policy) => policy?.taxRates?.taxes).filter((taxRates) => !!taxRates);

	const taxItems = useMemo(() => {
	if (!selectedPoliciesTaxRates) {
	return Object.entries(allTaxRates).map(([taxRateName, taxRateKeys]) => ({name: taxRateName, value: taxRateKeys}));
	}

[Due for payment 2025-07-15] [Due for payment 2025-07-14] [$125] Filters - Category and tag lists are missing in the advanced filters #65453

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jul 3, 2025

melvin-bot commented on Jul 3, 2025

melvin-bot commented on Jul 3, 2025

melvin-bot commented on Jul 3, 2025

BlameGPT commented on Jul 3, 2025

Possible culprit PRs for this issue

If not above, check these

ChavdaSachin commented on Jul 3, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

rushatgabhane commented on Jul 3, 2025

40 remaining items

melvin-bot commented on Jul 7, 2025

melvin-bot commented on Jul 7, 2025

melvin-bot commented on Jul 8, 2025

melvin-bot commented on Jul 8, 2025

garrettmknight commented on Jul 15, 2025

shubham1206agra commented on Jul 15, 2025

garrettmknight commented on Jul 15, 2025

JmillsExpensify commented on Jul 21, 2025

garrettmknight commented on Jul 22, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions