Skip to content

[Due for payment 2025-09-17] [$250] Report field violations aren't showing on reports page #65460

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.76-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation (hyperlinked to channel name): #Expensify bugs

Action Performed:

  1. Click workspaces > new workspace > enter name and confirm
  2. Go to workspace editor for that workspace > Reports > Switch on Report fields
  3. Click add field > press name and add a name > press type and select text > don't set an initial value > press save
  4. Create a report on that workspace

Expected Result:

Violation shows on the report fields

Actual Result:

no violation shows on the report fields in New Dot. If you load the report in Old Dot you should see a violation

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

Recording.1379.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021941183565821524059
  • Upwork Job ID: 1941183565821524059
  • Last Price Increase: 2025-07-04
  • Automatic offers:
    • Tony-MK | Contributor | 108009026
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 4, 2025
  2. melvin-bot commented on Jul 4, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 4, 2025
  4. melvin-bot commented on Jul 4, 2025

    @melvin-bot
  5. changed the title [-]Report field violations aren't showing on reports page[/-] [+][$250] Report field violations aren't showing on reports page[/+] on Jul 4, 2025
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 4, 2025
  7. melvin-bot commented on Jul 4, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  8. trjExpensify commented on Jul 4, 2025

    @trjExpensify
    Contributor

    Dunno if this will really be FE-only, but we'll see.

  9. Tony-MK commented on Jul 4, 2025

    @Tony-MK
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Report field violations aren't showing on the reports page.

    What is the root cause of that problem?

    The front end and the back end are not validating and merging the fieldRequired violation.

    What changes do you think we should make in order to solve the problem?

    In ViolationUtils.getViolationsOnyxData, check if the transaction's report field is an empty value, and add the fieldRequired violation. We should create a property in the PolicyReportField, such as required, to check whether the violation should be added in ViolationUtils.getViolationsOnyxData.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Create tests to check if the report field violations are being pushed optimistically to the onyx.

    What alternative solutions did you explore? (Optional)

    N/A

  10. melvin-bot commented on Jul 8, 2025

    @melvin-bot

    @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. 53 remaining items

  12. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-17. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    @rushatgabhane @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. trjExpensify commented on Sep 17, 2025

    @trjExpensify
    Contributor

    👋 checklist time here @rushatgabhane!

  16. rushatgabhane commented on Sep 19, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N.A. frontend backend mismatch issue

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create a workspace, if none.
    2. Enable report fields for the workspace.
    3. Create a report field.
    4. Enter a name.
    5. Leave the value empty.
    6. Create an expense.
    7. Open the expense thread.
    8. Verify the report field has an error.

    Do we agree 👍 or 👎

  17. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    @trjExpensify Eep! 4 days overdue now. Issues have feelings too...

  18. trjExpensify commented on Sep 23, 2025

    @trjExpensify
    Contributor

    Payment summary as follows:

    All set, closing!

  19. garrettmknight commented on Sep 30, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions