[Due for payment 2025-08-20] [$250] mWeb- LHN - Double chat messages when move expense to other workspace

@DylanDylann

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.77-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65310
Email or phone of affected tester (no customers): gocemate+b2153682approver@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A02s/12
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

Create a workspace with Admin, Approver and Member.

Steps

Go to the app
[Member] Submit an expense in the workspace chat.
[Member] Click Submit on the expense preview.
[Approver] Create a new workspace.
[Approver] Open workspace chat with member.
[Approver] Open the expense report.
[Approver] Click More > Change workspace.
[Approver] Select the new workspace.
[Approver] Open the workspace chat with member from Step 5.

Expected Result:

There should be only one message " User owes..."

Actual Result:

Double chat messages when move expense to other workspace

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021942581813581610068
Upwork Job ID: 1942581813581610068
Last Price Increase: 2025-07-15
Automatic offers:

truph01 | Contributor | 108079583

Issue Owner

Current Issue Owner: @DylanDylann

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicate chat messages appear when an expense is moved to another workspace.

What is the root cause of that problem?

When changing the workspace, we have logic here:

App/src/libs/actions/Report.ts

Lines 5575 to 5586 in 46b6aef

    
           // 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID 
        
           // and set it as a parent of the moved report 
        
           const policyExpenseChat = getPolicyExpenseChat(currentUserAccountID, policyID); 
        
           const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report); 
        
           const newPolicyExpenseChatReportID = policyExpenseChat?.reportID; 
        
           optimisticData.push({ 
        
               onyxMethod: Onyx.METHOD.MERGE, 
        
               key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${newPolicyExpenseChatReportID}`, 
        
               value: {[optimisticReportPreviewAction.reportActionID]: optimisticReportPreviewAction}, 
        
           });

This logic creates a new REPORT_PREVIEW report action and adds it to the policy expense chat. However, we are always adding it to the current user's policy expense chat, instead of the policy expense chat of the user who owns the expense report (optimistically).

Meanwhile, the backend also creates a new REPORT_PREVIEW report action, but it correctly adds it to the policy expense chat of the actual owner of the expense report.
As a result, the "User owes..." message appears twice in the LHN.

What changes do you think we should make in order to solve the problem?

In this function:

App/src/libs/actions/Report.ts

Line 5451 in 46b6aef

function buildOptimisticChangePolicyData(report: Report, policyID: string, reportNextStep?: ReportNextStep) {

Introduce a third parameter: optimisticPolicyExpenseChatReport?: Report. This will help handle two cases:

When the policy expense chat hasn’t been created yet.
When the policy expense chat has already been created.

Then, update the logic here:

App/src/libs/actions/Report.ts

Lines 5575 to 5580 in 46b6aef

    
           // 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID 
        
           // and set it as a parent of the moved report 
        
           const policyExpenseChat = getPolicyExpenseChat(currentUserAccountID, policyID); 
        
           const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report); 
        
           const newPolicyExpenseChatReportID = policyExpenseChat?.reportID;

Update it as follows:


    // 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID
    // and set it as a parent of the moved report
    const policyExpenseChat = optimisticPolicyExpenseChatReport ?? getPolicyExpenseChat(report.ownerAccountID, policyID);
    const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report);

    const newPolicyExpenseChatReportID = policyExpenseChat?.reportID;

In:

App/src/libs/actions/Report.ts

Line 5713 in 46b6aef

} = buildOptimisticChangePolicyData(report, policyID);

pass membersChats.reportCreationData[submitterEmail] as 3rd param.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None.

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021942581813581610068

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@DylanDylann

@DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@DylanDylann

@DylanDylann have you had a chance to review the proposal?

Reviewing label has been removed, please complete the "BugZero Checklist".

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Double chat messages when move expense to other workspace #66711

If no regressions arise, payment will be issued on 2025-08-20. 🎊

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment through NewDot Manual Requests
@truph01 requires payment automatic offer (Contributor)

@DylanDylann

@DylanDylann / @truph01 @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@DylanDylann

Payment summary:

@DylanDylann $250 through NewDot Manual Requests - please complete the checklist
@truph01 $250 paid in upwork ✔️

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Feature: Implement ChangeReportPolicy #57553 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:https://github.com/Expensify/Expensify/issues/540281

Regression Test Proposal

Precondition:

Create a workspace with Admin, Approver and Member

Test:

[Member] Submit an expense in the workspace chat.
[Member] Click Submit on the expense preview.
[Approver] Create a new workspace.
[Approver] Open workspace chat with member.
[Approver] Open the expense report.
[Approver] Click More > Change workspace.
[Approver] Select the new workspace.
[Approver] Open the workspace chat with member from Step 5.
There should be only one message " User owes..."

Do we agree 👍 or 👎

@DylanDylann

$250 approved for @DylanDylann

Navigation Menu

Repository navigation

[Due for payment 2025-08-20] [$250] mWeb- LHN - Double chat messages when move expense to other workspace #65561

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

23 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID
	// and set it as a parent of the moved report
	const policyExpenseChat = getPolicyExpenseChat(currentUserAccountID, policyID);
	const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report);

	const newPolicyExpenseChatReportID = policyExpenseChat?.reportID;

	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${newPolicyExpenseChatReportID}`,
	value: {[optimisticReportPreviewAction.reportActionID]: optimisticReportPreviewAction},
	});

[Due for payment 2025-08-20] [$250] mWeb- LHN - Double chat messages when move expense to other workspace #65561

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 7, 2025

truph01 commented on Jul 7, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 8, 2025

melvin-bot commented on Jul 8, 2025

melvin-bot commented on Jul 11, 2025

sonialiap commented on Jul 15, 2025

23 remaining items

melvin-bot commented on Aug 13, 2025

melvin-bot commented on Aug 13, 2025

melvin-bot commented on Aug 13, 2025

sonialiap commented on Aug 22, 2025

DylanDylann commented on Aug 25, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

garrettmknight commented on Oct 24, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions